[Bug][UI Next]Fix global variable validation condition for save butto…

…n in workflow definition. (#9454)
apache · Apr 12, 2022 · 8440baa · 8440baa
1 parent 51c1d8f
commit 8440baa
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/dolphinscheduler-ui-next/src/views/projects/workflow/components/dag/dag-save-modal.tsx b/dolphinscheduler-ui-next/src/views/projects/workflow/components/dag/dag-save-modal.tsx
@@ -114,16 +114,19 @@ export default defineComponent({
       globalParams: {
         validator() {
           const props = new Set()
+
+          const keys = formValue.value.globalParams.map(item => item.key)
+          const keysSet = new Set(keys)
+          if (keysSet.size !== keys.length) {
+            return new Error(t('project.dag.prop_repeat'))
+          }
+
           for (const param of formValue.value.globalParams) {
             const prop = param.value
             if (!prop) {
               return new Error(t('project.dag.prop_empty'))
             }
 
-            if (props.has(prop)) {
-              return new Error(t('project.dag.prop_repeat'))
-            }
-
             props.add(prop)
           }
         }