descriptor

apache · Jan 12, 2025 · 2928660 · 2928660
1 parent 0f82df0
commit 2928660
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 2 deletions.
diff --git a/be/src/runtime/descriptors.cpp b/be/src/runtime/descriptors.cpp
@@ -138,6 +138,15 @@ std::string OlapTableDescriptor::debug_string() const {
     return out.str();
 }
 
+DictionaryTableDescriptor::DictionaryTableDescriptor(const TTableDescriptor& tdesc)
+        : TableDescriptor(tdesc) {}
+
+std::string DictionaryTableDescriptor::debug_string() const {
+    std::stringstream out;
+    out << "Dictionary(" << TableDescriptor::debug_string() << ")";
+    return out.str();
+}
+
 SchemaTableDescriptor::SchemaTableDescriptor(const TTableDescriptor& tdesc)
         : TableDescriptor(tdesc), _schema_table_type(tdesc.schemaTable.tableType) {}
 SchemaTableDescriptor::~SchemaTableDescriptor() = default;
@@ -577,6 +586,9 @@ Status DescriptorTbl::create(ObjectPool* pool, const TDescriptorTable& thrift_tb
         case TTableType::TRINO_CONNECTOR_TABLE:
             desc = pool->add(new TrinoConnectorTableDescriptor(tdesc));
             break;
+        case TTableType::DICTIONARY_TABLE:
+            desc = pool->add(new DictionaryTableDescriptor(tdesc));
+            break;
         default:
             DCHECK(false) << "invalid table type: " << tdesc.tableType;
         }

diff --git a/be/src/runtime/descriptors.h b/be/src/runtime/descriptors.h
@@ -168,6 +168,12 @@ class OlapTableDescriptor : public TableDescriptor {
     std::string debug_string() const override;
 };
 
+class DictionaryTableDescriptor : public TableDescriptor {
+public:
+    DictionaryTableDescriptor(const TTableDescriptor& tdesc);
+    std::string debug_string() const override;
+};
+
 class SchemaTableDescriptor : public TableDescriptor {
 public:
     SchemaTableDescriptor(const TTableDescriptor& tdesc);

diff --git a/fe/fe-core/src/main/java/org/apache/doris/dictionary/Dictionary.java b/fe/fe-core/src/main/java/org/apache/doris/dictionary/Dictionary.java
@@ -199,7 +199,7 @@ public LayoutType getLayout() {
 
     @Override
     public TTableDescriptor toThrift() {
-        TDictionaryTable tDictionaryTable = new TDictionaryTable(getName());
+        TDictionaryTable tDictionaryTable = new TDictionaryTable();
         // TODO: use this to replace TDictionarySink.name
         TTableDescriptor tTableDescriptor = new TTableDescriptor(id, TTableType.DICTIONARY_TABLE, fullSchema.size(), 0,
                 getName(), dbName);

diff --git a/gensrc/thrift/Descriptors.thrift b/gensrc/thrift/Descriptors.thrift
@@ -381,7 +381,6 @@ struct TLakeSoulTable {
 }
 
 struct TDictionaryTable {
-  1: required string name
 }
 
 // "Union" of all table types.
-Original file line number
+Diff line change
@@ Expand Up / @@ -381,7 +381,6 @@ struct TLakeSoulTable { @@
     }
     struct TDictionaryTable {
-: required string name
     }
     // "Union" of all table types.
@@ Expand Down @@