[nereids] consider numNulls in filter estimation

apache · Dec 29, 2023 · 393db64 · 393db64
1 parent bc344c0
commit 393db64
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/stats/FilterEstimation.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/stats/FilterEstimation.java
@@ -107,7 +107,6 @@ public Statistics visitCompoundPredicate(CompoundPredicate predicate, Estimation
             Set<Slot> rightInputSlots = rightExpr.getInputSlots();
             for (Slot slot : context.keyColumns) {
                 if (leftInputSlots.contains(slot) && rightInputSlots.contains(slot)) {
-                    ColumnStatistic origColStats = context.statistics.findColumnStatistics(slot);
                     ColumnStatistic leftColStats = leftStats.findColumnStatistics(slot);
                     ColumnStatistic rightColStats = rightStats.findColumnStatistics(slot);
                     StatisticRange leftRange = StatisticRange.from(leftColStats, slot.getDataType());
@@ -118,11 +117,8 @@ public Statistics visitCompoundPredicate(CompoundPredicate predicate, Estimation
                     colBuilder.setMinValue(union.getLow()).setMinExpr(union.getLowExpr())
                             .setMaxValue(union.getHigh()).setMaxExpr(union.getHighExpr())
                             .setNdv(union.getDistinctValues());
-                    if (!(leftExpr instanceof IsNull || rightExpr instanceof IsNull)) {
-                        colBuilder.setNumNulls(0);
-                    } else {
-                        colBuilder.setNumNulls(origColStats.numNulls);
-                    }
+                    double maxNumNulls = Math.max(leftColStats.numNulls, rightColStats.numNulls);
+                    colBuilder.setNumNulls(Math.min(colBuilder.getCount(), maxNumNulls));
                     orStats.addColumnStats(slot, colBuilder.build());
                 }
             }