fix comments

apache · Nov 5, 2024 · b572696 · b572696
1 parent b40c3ed
commit b572696
Showing 1 changed file with 0 additions and 4 deletions.
diff --git a/be/src/vec/columns/column_complex.h b/be/src/vec/columns/column_complex.h
@@ -82,7 +82,6 @@ class ColumnComplexType final : public COWHelper<IColumn, ColumnComplexType<T>>
             pvalue->deserialize(Slice(pos, length));
         } else {
             throw doris::Exception(ErrorCode::INTERNAL_ERROR, "Unexpected type in column complex");
-            __builtin_unreachable();
         }
     }
 
@@ -126,13 +125,11 @@ class ColumnComplexType final : public COWHelper<IColumn, ColumnComplexType<T>>
     [[noreturn]] void get_permutation(bool reverse, size_t limit, int nan_direction_hint,
                                       IColumn::Permutation& res) const override {
         throw doris::Exception(ErrorCode::INTERNAL_ERROR, "get_permutation not implemented");
-        __builtin_unreachable();
     }
 
     void get_indices_of_non_default_rows(IColumn::Offsets64& indices, size_t from,
                                          size_t limit) const override {
         throw doris::Exception(ErrorCode::INTERNAL_ERROR, "get_int not implemented");
-        __builtin_unreachable();
     }
     [[noreturn]] ColumnPtr index(const IColumn& indexes, size_t limit) const override {
         LOG(FATAL) << "index not implemented";
@@ -217,7 +214,6 @@ class ColumnComplexType final : public COWHelper<IColumn, ColumnComplexType<T>>
         throw doris::Exception(ErrorCode::INTERNAL_ERROR,
                                "deserialize_and_insert_from_arena not implemented");
         __builtin_unreachable();
-        LOG(FATAL) << "deserialize_and_insert_from_arena not implemented";
     }
 
     // maybe we do not need to impl the function