[Enhance](fe) Iceberg table in HMS catalog supports broker scan #28107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run buildall |
|
@morningman @chenlinzhong @luozenglin Please have a review, thx |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
run p0 |
morningman
reviewed
Dec 10, 2023
|
|
||
| if (props.containsKey(HMSExternalCatalog.BIND_BROKER_NAME)) { | ||
| // Set Iceberg FileIO implementation as `IcebergBrokerIO` when Catalog binding broker is specified. | ||
| props.put("io-impl", "org.apache.doris.datasource.iceberg.broker.IcebergBrokerIO"); |
There was a problem hiding this comment.
I think this property should be added when creating catalog?
There was a problem hiding this comment.
OK, I'll edit the docs to illustrate the usage of this property
|
run buildall |
WinkerDu
force-pushed
the
master-iceberg-broker-scan
branch
from
181af7b to
1479075
Compare
|
run buildall |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools |
|
TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run p0 |
morningman
force-pushed
the
master-iceberg-broker-scan
branch
from
1479075 to
57432eb
Compare
|
run buildall |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
PR approved by anyone and no changes requested. |
morningman
approved these changes
Jan 3, 2024
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jan 3, 2024
…he#28107) My organization uses HMS catalog to accelerate Lake query. Sine we have custom distributed file system and hard to integrate to FE / BE, we introduce HMS Catalog broker scan support (apache#24830) and implement custom distributed file system adaption in broker. We want to expand the scope of use to Iceberg table scan in HMS Catalog. This PR introduces broker-scan-related `IcebergBrokerIO`, `BrokerInputFile`, `BrokerInputStream` for Iceberg table scan
HappenLee
pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Jan 12, 2024
…he#28107) My organization uses HMS catalog to accelerate Lake query. Sine we have custom distributed file system and hard to integrate to FE / BE, we introduce HMS Catalog broker scan support (apache#24830) and implement custom distributed file system adaption in broker. We want to expand the scope of use to Iceberg table scan in HMS Catalog. This PR introduces broker-scan-related `IcebergBrokerIO`, `BrokerInputFile`, `BrokerInputStream` for Iceberg table scan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
My organization uses HMS catalog to accelerate Lake query. Sine we have custom distributed file system and hard to integrate to FE / BE, we introduce HMS Catalog broker scan support (#24830) and implement custom distributed file system adaption in broker.
We want to expand the scope of use to Iceberg table scan in HMS Catalog. This PR introduces broker-scan-related
IcebergBrokerIO,BrokerInputFile,BrokerInputStreamfor Iceberg table scanFurther comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...