[bugfix](scannerscheduler) should minus num_of_scanners before check should schedule #28926
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
TeamCity be ut coverage result: |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run compile |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run p0 |
1 similar comment
|
run p0 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -318,8 +318,8 @@ Status VScanNode::_init_profile() { | |||
| return Status::OK(); | |||
| } | |||
|
|
|||
| Status VScanNode::_start_scanners(const std::list<VScannerSPtr>& scanners, | |||
| const int query_parallel_instance_num) { | |||
| void VScanNode::_start_scanners(const std::list<std::shared_ptr<ScannerDelegate>>& scanners, | |||
There was a problem hiding this comment.
warning: method '_start_scanners' can be made const [readability-make-member-function-const]
be/src/vec/exec/scan/vscan_node.cpp:321:
- const int query_parallel_instance_num) {
+ const int query_parallel_instance_num) const {| public: | ||
| VScannerSPtr _scanner; | ||
| ScannerDelegate(VScannerSPtr& scanner_ptr) : _scanner(scanner_ptr) {} | ||
| ~ScannerDelegate() { static_cast<void>(_scanner->close(_scanner->runtime_state())); } |
There was a problem hiding this comment.
warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
~ScannerDelegate() { static_cast<void>(_scanner->close(_scanner->runtime_state())); }
^| Status _start_scanners(const std::list<VScannerSPtr>& scanners, | ||
| const int query_parallel_instance_num); | ||
| void _start_scanners(const std::list<std::shared_ptr<ScannerDelegate>>& scanners, | ||
| const int query_parallel_instance_num); |
There was a problem hiding this comment.
warning: parameter 'query_parallel_instance_num' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
| const int query_parallel_instance_num); | |
| int query_parallel_instance_num); |
|
run compile |
|
run p0 10 |
|
run buildall |
|
TeamCity be ut coverage result: |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run p0 10 |
|
run p0 |
1 similar comment
|
run p0 |
|
run p0 10 |
|
run buildall |
1 similar comment
|
run buildall |
|
TeamCity be ut coverage result: |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
TeamCity be ut coverage result: |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run p0 10 |
|
run buildall |
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
run p0 10 |
1 similar comment
|
run p0 10 |
|
PR approved by anyone and no changes requested. |
|
run buildall |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools |
|
TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
TeamCity be ut coverage result: |
…should schedule #28926 (#29331) --------- Co-authored-by: yiguolei <[email protected]>
…e check should schedule apache#28926 (apache#29331)" This reverts commit bd8113f.
…e check should schedule apache#28926 (apache#29331)" This reverts commit bd8113f.
…should schedule apache#28926 (apache#29331) --------- Co-authored-by: yiguolei <[email protected]>
Proposed changes
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...