[fix](stream_load)fix bug when stream without content-length or chunk… #27752 #29169
Conversation
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
| @@ -285,6 +285,19 @@ Status StreamLoadAction::_on_header(HttpRequest* http_req, std::shared_ptr<Strea | |||
| } | |||
| } | |||
|
|
|||
| if (UNLIKELY((http_req->header(HttpHeaders::CONTENT_LENGTH).empty() && | |||
There was a problem hiding this comment.
Does master branch also has this problem?
be/src/http/action/stream_load.cpp
Outdated
| !ctx->is_chunked_transfer))) { | ||
| LOG(WARNING) << "content_length is empty and transfer-encoding!=chunked, please set " | ||
| "content_length or transfer-encoding=chunked"; | ||
| return Status::InternalError( |
There was a problem hiding this comment.
DO NOT use internal error, because it is not an internal error. Maybe invalid input or invalid parameters?
xingyingone
force-pushed
the
branch-2.0
branch
from
f00f235 to
bf12c5f
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
xingyingone
force-pushed
the
branch-2.0
branch
from
bf12c5f to
0331e7d
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
1. forbid thed stream_load without content-length or chunked Transfer Encoding 2. forbid thed stream_load both with content-length and chunked Transfer Encoding
xingyingone
force-pushed
the
branch-2.0
branch
from
0331e7d to
a2f3b77
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
xiaokang
changed the title
…or chunk… apache#27752 (apache#29169)" This reverts commit f207976.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...