Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[branch-2.0-pick] Pick "[fix](partial update) Fix error message when doing strict mode partial update on a table with column that is non-nullable and has no default value #29218" #29225

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Dec 28, 2023

Proposed changes

picks #29218

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@bobhan1
Copy link
Contributor Author

bobhan1 commented Dec 28, 2023

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.87% (8022/21181)
Line Coverage: 29.55% (65227/220746)
Region Coverage: 28.99% (33521/115628)
Branch Coverage: 24.84% (17193/69210)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c95ec3d5767a34efe4aa45c75df351bf6313a769_c95ec3d5767a34efe4aa45c75df351bf6313a769/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.98 seconds
stream load tsv: 567 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.9 seconds inserted 10000000 Rows, about 334K ops/s
storage size: 17162325984 Bytes

@bobhan1 bobhan1 force-pushed the branch-2.0-pick-29218 branch from c95ec3d to d874f21 Compare December 28, 2023 10:43
@bobhan1
Copy link
Contributor Author

bobhan1 commented Dec 28, 2023

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.85% (8017/21182)
Line Coverage: 29.53% (65193/220759)
Region Coverage: 28.97% (33498/115633)
Branch Coverage: 24.83% (17188/69220)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d874f21d4116698e5aaaea73d9c10aad7baf7c40_d874f21d4116698e5aaaea73d9c10aad7baf7c40/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.11 seconds
stream load tsv: 565 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17162424982 Bytes

@bobhan1 bobhan1 force-pushed the branch-2.0-pick-29218 branch from d874f21 to 1e21ee1 Compare December 28, 2023 15:44
@bobhan1
Copy link
Contributor Author

bobhan1 commented Dec 28, 2023

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 51.13 seconds
stream load tsv: 566 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.9 seconds inserted 10000000 Rows, about 334K ops/s
storage size: 17162751568 Bytes

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.85% (8014/21172)
Line Coverage: 29.53% (65171/220663)
Region Coverage: 28.97% (33490/115596)
Branch Coverage: 24.83% (17183/69214)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1e21ee174ea42d563cc93fd7fa04416122053b17_1e21ee174ea42d563cc93fd7fa04416122053b17/report/index.html

@xiaokang xiaokang merged commit 89c8b3a into apache:branch-2.0 Dec 29, 2023
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants