Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0-pick-26525](workflow) Fix security issues with pull_request_target #26525 #29289

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

CalvinKirs
Copy link
Member

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@CalvinKirs
Copy link
Member Author

run buildall

@xiaokang
Copy link
Contributor

#26525

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 2, 2024
Copy link
Contributor

github-actions bot commented Jan 2, 2024

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Jan 2, 2024

PR approved by anyone and no changes requested.

CalvinKirs added a commit to CalvinKirs/incubator-doris that referenced this pull request Jan 2, 2024
JNSimba pushed a commit that referenced this pull request Jan 2, 2024
CalvinKirs added a commit to CalvinKirs/incubator-doris that referenced this pull request Jan 3, 2024
apache#29289
I modified the shell-check attribute, once the PR was combined, I revert this
@CalvinKirs
Copy link
Member Author

run buildall

JNSimba pushed a commit that referenced this pull request Jan 3, 2024
#29440)

#29289
I modified the shell-check attribute, once the PR was combined, I revert this
Copy link
Member

@JNSimba JNSimba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CalvinKirs
Copy link
Member Author

run buildall

@JNSimba JNSimba merged commit 357e5ef into apache:branch-2.0 Jan 3, 2024
25 of 27 checks passed
CalvinKirs added a commit to CalvinKirs/incubator-doris that referenced this pull request Jan 3, 2024
@CalvinKirs CalvinKirs deleted the branch-2.0-pt branch January 3, 2024 03:45
seawinde pushed a commit to seawinde/doris that referenced this pull request Jan 3, 2024
apache#29440)

apache#29289
I modified the shell-check attribute, once the PR was combined, I revert this
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Jan 12, 2024
apache#29440)

apache#29289
I modified the shell-check attribute, once the PR was combined, I revert this
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants