[bugfix](scannerscheduler) should minus num_of_scanners before check should schedule #28926 #29331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -318,8 +322,8 @@ Status VScanNode::_init_profile() { | |||
| return Status::OK(); | |||
| } | |||
|
|
|||
| Status VScanNode::_start_scanners(const std::list<VScannerSPtr>& scanners, | |||
| const int query_parallel_instance_num) { | |||
| void VScanNode::_start_scanners(const std::list<std::shared_ptr<ScannerDelegate>>& scanners, | |||
There was a problem hiding this comment.
warning: method '_start_scanners' can be made const [readability-make-member-function-const]
be/src/vec/exec/scan/vscan_node.cpp:325:
- const int query_parallel_instance_num) {
+ const int query_parallel_instance_num) const {
be/src/vec/exec/scan/vscan_node.h
Outdated
| public: | ||
| VScannerSPtr _scanner; | ||
| ScannerDelegate(VScannerSPtr& scanner_ptr) : _scanner(scanner_ptr) {} | ||
| ~ScannerDelegate() { static_cast<void>(_scanner->close(_scanner->runtime_state())); } |
There was a problem hiding this comment.
warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
~ScannerDelegate() { static_cast<void>(_scanner->close(_scanner->runtime_state())); }
^| Status _start_scanners(const std::list<VScannerSPtr>& scanners, | ||
| const int query_parallel_instance_num); | ||
| void _start_scanners(const std::list<std::shared_ptr<ScannerDelegate>>& scanners, | ||
| const int query_parallel_instance_num); |
There was a problem hiding this comment.
warning: parameter 'query_parallel_instance_num' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
Suggested change
| const int query_parallel_instance_num); | |
| int query_parallel_instance_num); |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools |
|
TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
TeamCity be ut coverage result: |
|
run p0 10 |
1 similar comment
|
run p0 10 |
yiguolei
force-pushed
the
fix_core1
branch
2 times, most recently
from
8dc606c to
5810b1f
Compare
|
run compile |
|
run buildall |
|
run p0 10 |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools |
|
TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
TeamCity be ut coverage result: |
|
run buildall |
|
TeamCity be ut coverage result: |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools |
|
TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run p0 10 |
1 similar comment
|
run p0 10 |
|
run buildall |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools |
|
run p0 10 |
|
run buildall |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools |
|
TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
TeamCity be ut coverage result: |
|
run p0 |
1 similar comment
|
run p0 |
|
run buildall |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools |
|
TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
TeamCity be ut coverage result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
shuke987
added a commit
to shuke987/doris
that referenced
this pull request
Jan 4, 2024
…e check should schedule apache#28926 (apache#29331)" This reverts commit bd8113f.
shuke987
added a commit
to shuke987/doris
that referenced
this pull request
Jan 4, 2024
…e check should schedule apache#28926 (apache#29331)" This reverts commit bd8113f.
HappenLee
pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Jan 12, 2024
…should schedule apache#28926 (apache#29331) --------- Co-authored-by: yiguolei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...