Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix](partition) Skip rowset partition id eq 0 smaller than config wh… #29363

Merged
merged 5 commits into from
Jan 5, 2024
Merged

[Fix](partition) Skip rowset partition id eq 0 smaller than config wh… #29363

merged 5 commits into from
Jan 5, 2024

Conversation

deardeng
Copy link
Contributor

@deardeng deardeng commented Jan 1, 2024

…en be start

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@deardeng
Copy link
Contributor Author

deardeng commented Jan 1, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 1, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.46 seconds
stream load tsv: 582 seconds loaded 74807831229 Bytes, about 122 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 30.0 seconds inserted 10000000 Rows, about 333K ops/s
storage size: 17163016343 Bytes

@deardeng
Copy link
Contributor Author

deardeng commented Jan 1, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 1, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.85% (8020/21189)
Line Coverage: 29.54% (65258/220951)
Region Coverage: 28.98% (33541/115735)
Branch Coverage: 24.83% (17209/69304)
Coverage Report: http://coverage.selectdb-in.cc/coverage/57773ddc4cf0c489f164f3a113fd7cf05c760c80_57773ddc4cf0c489f164f3a113fd7cf05c760c80/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.7 seconds
stream load tsv: 571 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.8 seconds inserted 10000000 Rows, about 335K ops/s
storage size: 17163066497 Bytes

dataroaring
dataroaring approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jan 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024

PR approved by anyone and no changes requested.

@dataroaring dataroaring added the usercase Important user case type label label Jan 2, 2024
@dataroaring
Copy link
Contributor

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.84% (8018/21189)
Line Coverage: 29.52% (65236/220956)
Region Coverage: 28.97% (33532/115739)
Branch Coverage: 24.83% (17212/69308)
Coverage Report: http://coverage.selectdb-in.cc/coverage/07edc03955eeaf5a5e73e4406eefb6fcb6c8b541_07edc03955eeaf5a5e73e4406eefb6fcb6c8b541/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.52 seconds
stream load tsv: 573 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.7 seconds inserted 10000000 Rows, about 336K ops/s
storage size: 17162230920 Bytes

yiguolei
yiguolei reviewed Jan 3, 2024
View reviewed changes
be/src/olap/data_dir.cpp
@@ -486,6 +505,13 @@ Status DataDir::load() {
continue;
}

if (rowset_meta->partition_id() == 0) {
LOG(WARNING) << "skip tablet_id=" << tablet->tablet_id()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is a committed rowset with partition id = 0; and you ignore it. Then publish version will success and FE will finish the txn. But BE will not have this data, then data loss and query will failed

@deardeng
Copy link
Contributor Author

deardeng commented Jan 3, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.85% (8020/21189)
Line Coverage: 29.54% (65264/220956)
Region Coverage: 28.99% (33549/115739)
Branch Coverage: 24.84% (17216/69308)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e2d052d9717936ed7d413462e2e7bfffc2c46280_e2d052d9717936ed7d413462e2e7bfffc2c46280/report/index.html

@deardeng
Copy link
Contributor Author

deardeng commented Jan 3, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.84% (8018/21189)
Line Coverage: 29.53% (65244/220956)
Region Coverage: 28.97% (33533/115739)
Branch Coverage: 24.83% (17208/69308)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e2d052d9717936ed7d413462e2e7bfffc2c46280_e2d052d9717936ed7d413462e2e7bfffc2c46280/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.42 seconds
stream load tsv: 566 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.6 seconds inserted 10000000 Rows, about 337K ops/s
storage size: 17162942261 Bytes

@deardeng
Copy link
Contributor Author

deardeng commented Jan 5, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.85% (8020/21189)
Line Coverage: 29.53% (65256/220963)
Region Coverage: 28.98% (33546/115758)
Branch Coverage: 24.84% (17215/69314)
Coverage Report: http://coverage.selectdb-in.cc/coverage/bb1b2cfea902955b43070c792fd3abc916f9f2d4_bb1b2cfea902955b43070c792fd3abc916f9f2d4/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.52 seconds
stream load tsv: 566 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17163038720 Bytes

@dataroaring dataroaring merged commit 23e6372 into apache:branch-2.0 Jan 5, 2024
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deardeng @doris-robot @dataroaring @yiguolei