-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opt](scanner) optimize the number of threads of scanners, follow up #28640 #30030
Conversation
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
clang-tidy review says "All clean, LGTM! 👍" |
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38978 ms
|
TPC-DS: Total hot run time: 177775 ms
|
ClickBench: Total hot run time: 30.39 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
…pache#28640 (apache#30030) follow up apache#28640, doris_scanner_thread_pool_thread_num may be to large in machines with 128 cores.
Proposed changes
follow up #28640,
doris_scanner_thread_pool_thread_num
may be to large in machines with 128 cores.Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...