Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](http) Remove file if downloading faile is failed #41778 #41829

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Oct 15, 2024

cherry pick from #41778

@w41ter
Copy link
Contributor Author

w41ter commented Oct 15, 2024

run buildall

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.85% (8158/21552)
Line Coverage: 29.57% (67131/227024)
Region Coverage: 29.05% (34618/119159)
Branch Coverage: 25.00% (17865/71472)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1c09f9cf8c8bf74ae58b30836ecc45cf2b3ae0c1_1c09f9cf8c8bf74ae58b30836ecc45cf2b3ae0c1/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 49273 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1c09f9cf8c8bf74ae58b30836ecc45cf2b3ae0c1, data reload: false

------ Round 1 ----------------------------------
q1	17972	4466	4379	4379
q2	2067	150	152	150
q3	10457	1952	1932	1932
q4	10302	1292	1316	1292
q5	8418	3925	3904	3904
q6	230	121	119	119
q7	2106	1622	1583	1583
q8	9372	2754	2741	2741
q9	10355	9732	9887	9732
q10	8661	3561	3514	3514
q11	421	245	249	245
q12	473	299	293	293
q13	18329	3987	4011	3987
q14	364	320	343	320
q15	522	462	459	459
q16	546	483	470	470
q17	1126	965	954	954
q18	7215	6908	6957	6908
q19	1699	1596	1487	1487
q20	552	311	305	305
q21	4463	4215	4109	4109
q22	483	402	390	390
Total cold run time: 116133 ms
Total hot run time: 49273 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4309	4306	4348	4306
q2	325	225	224	224
q3	4168	4120	4155	4120
q4	2752	2746	2746	2746
q5	7147	7081	7115	7081
q6	237	114	116	114
q7	3221	2873	2871	2871
q8	4351	4465	4533	4465
q9	13736	13623	13561	13561
q10	4226	4220	4252	4220
q11	753	680	722	680
q12	1028	865	840	840
q13	6805	3765	3727	3727
q14	443	418	427	418
q15	504	453	455	453
q16	659	611	587	587
q17	3806	3854	3855	3854
q18	8919	8792	8733	8733
q19	1736	1690	1686	1686
q20	2357	2089	2107	2089
q21	8497	8426	8442	8426
q22	985	948	941	941
Total cold run time: 80964 ms
Total hot run time: 76142 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 211499 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1c09f9cf8c8bf74ae58b30836ecc45cf2b3ae0c1, data reload: false

query1	938	423	382	382
query2	6547	2343	2164	2164
query3	6921	201	202	201
query4	23337	21741	21150	21150
query5	19736	6531	6483	6483
query6	285	220	237	220
query7	4332	302	323	302
query8	254	272	260	260
query9	3092	2675	2591	2591
query10	474	318	307	307
query11	15796	15583	15146	15146
query12	127	76	72	72
query13	1033	446	445	445
query14	17064	13041	13312	13041
query15	377	218	234	218
query16	6481	277	268	268
query17	1786	932	905	905
query18	902	312	314	312
query19	219	150	149	149
query20	102	94	95	94
query21	192	96	94	94
query22	5248	5089	5000	5000
query23	34164	33589	33319	33319
query24	7849	6332	6347	6332
query25	514	441	436	436
query26	1268	163	162	162
query27	2426	299	297	297
query28	6130	2225	2215	2215
query29	2940	2773	2778	2773
query30	238	171	164	164
query31	972	736	733	733
query32	72	64	61	61
query33	455	258	262	258
query34	871	478	479	478
query35	1131	934	933	933
query36	1405	1166	1007	1007
query37	175	57	62	57
query38	3095	2935	2904	2904
query39	1376	1333	1328	1328
query40	309	87	98	87
query41	39	38	37	37
query42	83	94	86	86
query43	639	553	615	553
query44	1162	724	722	722
query45	242	230	229	229
query46	1225	942	974	942
query47	1915	1772	1893	1772
query48	502	403	396	396
query49	653	369	382	369
query50	856	599	596	596
query51	4720	4641	4637	4637
query52	100	89	84	84
query53	233	187	196	187
query54	2663	2439	2469	2439
query55	85	90	84	84
query56	227	209	210	209
query57	1334	1167	1159	1159
query58	222	214	212	212
query59	3411	3477	3274	3274
query60	224	198	211	198
query61	95	93	93	93
query62	778	463	491	463
query63	204	177	177	177
query64	3525	1590	1513	1513
query65	3636	3562	3534	3534
query66	766	428	427	427
query67	15621	14746	16519	14746
query68	10937	673	639	639
query69	498	280	269	269
query70	1871	1329	1574	1329
query71	411	312	311	311
query72	6864	4759	4828	4759
query73	768	318	319	318
query74	6320	5894	5915	5894
query75	5337	3718	3693	3693
query76	6703	1150	1183	1150
query77	1156	264	267	264
query78	12610	11866	12481	11866
query79	7834	650	634	634
query80	840	394	378	378
query81	492	241	241	241
query82	1349	97	99	97
query83	176	140	129	129
query84	257	73	70	70
query85	886	319	317	317
query86	330	297	302	297
query87	3208	3013	3050	3013
query88	4177	2302	2313	2302
query89	463	297	295	295
query90	1943	222	210	210
query91	160	129	124	124
query92	60	53	52	52
query93	5882	585	560	560
query94	686	212	205	205
query95	2005	1937	1963	1937
query96	645	324	323	323
query97	6424	6385	6300	6300
query98	223	205	210	205
query99	2843	832	838	832
Total cold run time: 320151 ms
Total hot run time: 211499 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.71 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1c09f9cf8c8bf74ae58b30836ecc45cf2b3ae0c1, data reload: false

query1	0.02	0.03	0.03
query2	0.07	0.02	0.02
query3	0.24	0.04	0.05
query4	1.78	0.06	0.06
query5	0.54	0.53	0.52
query6	1.29	0.61	0.61
query7	0.01	0.00	0.01
query8	0.04	0.03	0.02
query9	0.55	0.48	0.47
query10	0.54	0.54	0.53
query11	0.12	0.08	0.09
query12	0.12	0.09	0.09
query13	0.62	0.61	0.61
query14	0.79	0.78	0.78
query15	0.78	0.76	0.76
query16	0.38	0.37	0.38
query17	1.01	1.02	1.01
query18	0.22	0.27	0.26
query19	1.94	1.89	1.86
query20	0.01	0.02	0.01
query21	15.44	0.56	0.56
query22	1.97	1.71	1.45
query23	16.56	1.10	0.99
query24	5.32	1.04	1.26
query25	0.36	0.08	0.06
query26	0.61	0.16	0.14
query27	0.05	0.03	0.04
query28	7.99	0.73	0.71
query29	12.59	2.37	2.30
query30	0.54	0.53	0.49
query31	2.80	0.38	0.38
query32	3.37	0.49	0.50
query33	3.07	3.04	3.05
query34	15.26	4.83	4.80
query35	4.86	4.83	4.85
query36	1.06	1.02	1.01
query37	0.06	0.04	0.04
query38	0.03	0.02	0.02
query39	0.02	0.02	0.01
query40	0.16	0.15	0.15
query41	0.06	0.02	0.01
query42	0.02	0.01	0.02
query43	0.02	0.02	0.02
Total cold run time: 103.29 s
Total hot run time: 30.71 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 1c09f9cf8c8bf74ae58b30836ecc45cf2b3ae0c1 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          57 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.5 seconds inserted 10000000 Rows, about 465K ops/s

@w41ter w41ter merged commit 2e41623 into apache:branch-2.0 Oct 15, 2024
20 of 24 checks passed
@w41ter w41ter deleted the pick_41778_to_origin_branch-2.0 branch October 15, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants