Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](metrics) fix compaction_used_permits are negative numbers #32440 #42526

Merged
merged 3 commits into from
Oct 29, 2024
Merged

[fix](metrics) fix compaction_used_permits are negative numbers #32440 #42526

merged 3 commits into from
Oct 29, 2024

Conversation

cambyzju
Copy link
Contributor

pick #32440 to branch-2.0

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@cambyzju
Copy link
Contributor Author

run buildall

@cambyzju
Copy link
Contributor Author

run buildall

github-actions[bot]
github-actions bot reviewed Oct 28, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/olap/task/engine_storage_migration_task.h
#include <gen_cpp/olap_file.pb.h>
#include <stdint.h>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'gen_cpp/olap_file.pb.h' file not found [clang-diagnostic-error]

#include <gen_cpp/olap_file.pb.h>
         ^

lide-reed
lide-reed approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Oct 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

github-actions[bot]
github-actions bot reviewed Oct 28, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/olap/task/engine_storage_migration_task.h
@@ -18,9 +18,8 @@
#ifndef DORIS_BE_SRC_OLAP_TASK_ENGINE_STORAGE_MIGRATION_TASK_H
#define DORIS_BE_SRC_OLAP_TASK_ENGINE_STORAGE_MIGRATION_TASK_H

#include <stdint.h>

#include <gen_cpp/olap_file.pb.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'gen_cpp/olap_file.pb.h' file not found [clang-diagnostic-error]

#include <gen_cpp/olap_file.pb.h>
         ^

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.86% (8159/21553)
Line Coverage: 29.57% (67144/227044)
Region Coverage: 29.06% (34628/119174)
Branch Coverage: 25.00% (17874/71484)
Coverage Report: http://coverage.selectdb-in.cc/coverage/82669da44bc11332443a4d3f834ea13fe2bc5c53_82669da44bc11332443a4d3f834ea13fe2bc5c53/report/index.html

@cambyzju cambyzju merged commit bb50ce1 into apache:branch-2.0 Oct 29, 2024
21 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@lide-reed lide-reed lide-reed approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.16-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cambyzju @doris-robot @lide-reed @yuxuan-luo