Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](Nereids) simplify decimal comparison wrong when cast to smaller scale (#41151) #42871

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

morrySnow
Copy link
Contributor

pick from master #41151

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 49236 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7683b58a39874e291d5a0de227f18d71355e79cb, data reload: false

------ Round 1 ----------------------------------
q1	17818	4384	4321	4321
q2	2061	150	142	142
q3	10269	1901	1928	1901
q4	10330	1212	1300	1212
q5	8673	3915	3900	3900
q6	232	124	124	124
q7	2058	1632	1602	1602
q8	9385	2721	2761	2721
q9	10616	10081	10038	10038
q10	8612	3525	3482	3482
q11	413	232	250	232
q12	467	303	299	299
q13	18370	4006	3995	3995
q14	363	330	329	329
q15	525	459	457	457
q16	538	460	453	453
q17	1122	962	945	945
q18	7274	6814	6904	6814
q19	1681	1536	1528	1528
q20	522	327	282	282
q21	4397	4137	4059	4059
q22	477	400	413	400
Total cold run time: 116203 ms
Total hot run time: 49236 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4331	4370	4312	4312
q2	322	225	227	225
q3	4144	4129	4091	4091
q4	2733	2738	2732	2732
q5	7227	7145	7151	7145
q6	240	121	123	121
q7	3264	2868	2859	2859
q8	4383	4495	4513	4495
q9	14287	13888	13926	13888
q10	4224	4312	4249	4249
q11	750	686	685	685
q12	1027	863	888	863
q13	7183	3796	3764	3764
q14	457	442	429	429
q15	502	462	447	447
q16	622	587	603	587
q17	3881	3833	3989	3833
q18	9162	9198	8869	8869
q19	1721	1701	1699	1699
q20	2414	2142	2148	2142
q21	8529	8531	8420	8420
q22	995	887	899	887
Total cold run time: 82398 ms
Total hot run time: 76742 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 212667 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7683b58a39874e291d5a0de227f18d71355e79cb, data reload: false

query1	952	385	411	385
query2	6556	2268	2080	2080
query3	6920	192	198	192
query4	22925	21391	21486	21391
query5	19747	6505	6490	6490
query6	426	221	243	221
query7	5298	304	305	304
query8	296	262	248	248
query9	2997	2614	2548	2548
query10	440	305	309	305
query11	15561	14873	14830	14830
query12	125	84	73	73
query13	1003	447	444	444
query14	19220	13501	13730	13501
query15	359	226	219	219
query16	6440	280	257	257
query17	1579	943	909	909
query18	891	314	317	314
query19	205	147	154	147
query20	98	96	98	96
query21	189	100	96	96
query22	5117	5333	5459	5333
query23	34456	33642	33582	33582
query24	6793	6266	6304	6266
query25	520	432	427	427
query26	1271	164	158	158
query27	2241	290	285	285
query28	6103	2224	2191	2191
query29	2884	2668	2869	2668
query30	243	169	163	163
query31	920	718	740	718
query32	77	63	59	59
query33	466	259	257	257
query34	868	484	474	474
query35	1144	924	938	924
query36	1330	1263	1236	1236
query37	96	61	60	60
query38	3009	2968	2891	2891
query39	1351	1334	1325	1325
query40	312	96	95	95
query41	40	38	37	37
query42	87	82	85	82
query43	665	632	577	577
query44	1149	716	723	716
query45	249	227	230	227
query46	1219	959	973	959
query47	1906	1621	1827	1621
query48	501	419	428	419
query49	645	371	383	371
query50	849	638	592	592
query51	4816	4669	4736	4669
query52	106	80	91	80
query53	229	185	190	185
query54	2641	2464	2482	2464
query55	84	81	88	81
query56	233	211	205	205
query57	1317	1266	1142	1142
query58	222	212	218	212
query59	3467	3367	3168	3168
query60	235	194	202	194
query61	100	96	98	96
query62	804	412	447	412
query63	205	172	179	172
query64	3574	1638	1501	1501
query65	3603	3556	3587	3556
query66	775	425	414	414
query67	17138	15512	15474	15474
query68	8239	628	628	628
query69	500	278	275	275
query70	1695	1381	1413	1381
query71	412	295	314	295
query72	6803	4647	5082	4647
query73	757	304	308	304
query74	6246	5903	5818	5818
query75	4642	3710	3658	3658
query76	4562	1156	1190	1156
query77	549	252	250	250
query78	12795	11856	12224	11856
query79	5742	635	631	631
query80	2508	393	381	381
query81	525	241	238	238
query82	1644	102	98	98
query83	198	136	135	135
query84	256	74	70	70
query85	1473	322	328	322
query86	366	299	293	293
query87	3229	2981	3022	2981
query88	4642	2260	2283	2260
query89	347	314	279	279
query90	1868	208	208	208
query91	166	135	126	126
query92	61	50	53	50
query93	3111	597	519	519
query94	1010	205	210	205
query95	2094	2016	2020	2016
query96	636	322	324	322
query97	6621	6420	6434	6420
query98	221	193	210	193
query99	2767	864	869	864
Total cold run time: 314972 ms
Total hot run time: 212667 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.76 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7683b58a39874e291d5a0de227f18d71355e79cb, data reload: false

query1	0.03	0.02	0.03
query2	0.07	0.02	0.03
query3	0.25	0.04	0.04
query4	1.78	0.07	0.08
query5	0.54	0.52	0.52
query6	1.26	0.64	0.61
query7	0.02	0.01	0.01
query8	0.03	0.02	0.02
query9	0.53	0.49	0.48
query10	0.54	0.54	0.53
query11	0.12	0.09	0.09
query12	0.12	0.09	0.09
query13	0.61	0.61	0.61
query14	0.79	0.78	0.78
query15	0.78	0.75	0.77
query16	0.36	0.37	0.38
query17	1.00	0.99	1.03
query18	0.23	0.26	0.25
query19	1.92	1.86	1.86
query20	0.01	0.01	0.02
query21	15.48	0.55	0.55
query22	1.95	1.94	1.50
query23	17.07	1.12	0.97
query24	5.29	1.04	1.64
query25	0.33	0.10	0.06
query26	0.70	0.16	0.15
query27	0.04	0.03	0.03
query28	7.39	0.76	0.72
query29	12.63	2.29	2.27
query30	0.60	0.53	0.50
query31	2.81	0.38	0.38
query32	3.38	0.49	0.51
query33	3.13	3.06	3.06
query34	15.25	4.82	4.78
query35	4.89	4.87	4.87
query36	1.06	1.01	1.03
query37	0.06	0.05	0.05
query38	0.03	0.02	0.02
query39	0.01	0.01	0.02
query40	0.16	0.14	0.14
query41	0.06	0.01	0.02
query42	0.02	0.02	0.01
query43	0.02	0.03	0.02
Total cold run time: 103.35 s
Total hot run time: 30.76 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 7683b58a39874e291d5a0de227f18d71355e79cb with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.3 seconds inserted 10000000 Rows, about 469K ops/s

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 48903 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9306484ba08006e3201f92618fa1ba1792301707, data reload: false

------ Round 1 ----------------------------------
q1	17987	4385	4315	4315
q2	2061	155	145	145
q3	10264	1893	1920	1893
q4	10354	1235	1324	1235
q5	8498	3895	3877	3877
q6	221	123	120	120
q7	2063	1610	1620	1610
q8	9301	2713	2689	2689
q9	10257	9861	9743	9743
q10	8655	3500	3542	3500
q11	417	250	257	250
q12	471	298	299	298
q13	18342	3925	4070	3925
q14	346	320	330	320
q15	525	458	464	458
q16	538	455	452	452
q17	1127	945	917	917
q18	7302	6925	6861	6861
q19	1687	1579	1515	1515
q20	529	325	314	314
q21	4398	4121	4076	4076
q22	499	390	402	390
Total cold run time: 115842 ms
Total hot run time: 48903 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4349	4297	4295	4295
q2	321	230	217	217
q3	4166	4160	4122	4122
q4	2723	2740	2753	2740
q5	7158	7101	7050	7050
q6	241	123	118	118
q7	3223	2845	2791	2791
q8	4436	4501	4504	4501
q9	13654	13524	13499	13499
q10	4242	4251	4285	4251
q11	750	674	722	674
q12	1033	871	860	860
q13	7072	3760	3715	3715
q14	445	438	428	428
q15	499	458	457	457
q16	645	605	607	605
q17	3810	3811	3881	3811
q18	8850	8853	8768	8768
q19	1730	1649	1667	1649
q20	2331	2149	2119	2119
q21	8446	8448	8465	8448
q22	1026	963	901	901
Total cold run time: 81150 ms
Total hot run time: 76019 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 212089 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9306484ba08006e3201f92618fa1ba1792301707, data reload: false

query1	932	393	432	393
query2	6546	2233	2169	2169
query3	6926	204	199	199
query4	23344	21823	21567	21567
query5	19733	6545	6522	6522
query6	286	219	253	219
query7	4160	296	306	296
query8	246	272	257	257
query9	3063	2648	2568	2568
query10	412	294	294	294
query11	15336	14676	14977	14676
query12	132	76	72	72
query13	1026	439	433	433
query14	17260	13423	13293	13293
query15	397	221	229	221
query16	6490	273	268	268
query17	1943	948	911	911
query18	898	323	320	320
query19	209	148	146	146
query20	98	92	97	92
query21	191	96	98	96
query22	5265	5017	4972	4972
query23	34267	33539	33774	33539
query24	7883	6274	6271	6271
query25	527	431	422	422
query26	1278	165	158	158
query27	2495	292	289	289
query28	6137	2224	2193	2193
query29	2862	2754	2836	2754
query30	239	167	167	167
query31	936	739	764	739
query32	72	63	63	63
query33	459	267	249	249
query34	863	468	488	468
query35	1128	959	926	926
query36	1336	1133	1385	1133
query37	174	61	63	61
query38	3037	2892	2931	2892
query39	1366	1331	1328	1328
query40	308	97	95	95
query41	39	40	35	35
query42	88	96	98	96
query43	639	562	657	562
query44	1156	728	723	723
query45	246	233	228	228
query46	1222	970	948	948
query47	1934	1647	1755	1647
query48	505	415	406	406
query49	647	377	382	377
query50	849	604	628	604
query51	4820	4650	4674	4650
query52	95	79	81	79
query53	222	183	186	183
query54	2650	2445	2491	2445
query55	100	87	87	87
query56	216	206	211	206
query57	1288	1179	1134	1134
query58	225	209	217	209
query59	3456	3547	3239	3239
query60	219	214	199	199
query61	98	95	94	94
query62	873	504	470	470
query63	196	177	181	177
query64	3511	1573	1330	1330
query65	3645	3531	3557	3531
query66	807	417	403	403
query67	15411	15401	15561	15401
query68	9207	621	636	621
query69	502	280	275	275
query70	1840	1345	1464	1345
query71	400	310	315	310
query72	6714	4968	4888	4888
query73	757	320	314	314
query74	6240	5852	5819	5819
query75	4569	3748	3677	3677
query76	4715	1167	1193	1167
query77	646	248	249	248
query78	13818	12143	11641	11641
query79	9678	644	647	644
query80	1934	379	390	379
query81	507	235	242	235
query82	1346	100	96	96
query83	172	136	132	132
query84	262	70	70	70
query85	737	328	313	313
query86	372	284	283	283
query87	3300	3050	3013	3013
query88	4796	2303	2277	2277
query89	430	285	280	280
query90	1946	222	214	214
query91	158	127	125	125
query92	63	53	55	53
query93	6627	580	567	567
query94	894	212	214	212
query95	1981	2008	1965	1965
query96	649	328	324	324
query97	6388	6401	6334	6334
query98	228	199	209	199
query99	2866	875	909	875
Total cold run time: 320159 ms
Total hot run time: 212089 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.52 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9306484ba08006e3201f92618fa1ba1792301707, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.02
query3	0.25	0.05	0.05
query4	1.78	0.05	0.06
query5	0.54	0.52	0.52
query6	1.25	0.63	0.61
query7	0.01	0.01	0.01
query8	0.04	0.02	0.02
query9	0.53	0.50	0.47
query10	0.53	0.54	0.54
query11	0.12	0.09	0.09
query12	0.11	0.09	0.10
query13	0.62	0.62	0.60
query14	0.80	0.79	0.78
query15	0.78	0.77	0.76
query16	0.39	0.36	0.38
query17	0.96	0.99	1.03
query18	0.23	0.26	0.24
query19	1.86	1.79	1.86
query20	0.01	0.01	0.01
query21	15.47	0.55	0.54
query22	2.28	2.46	1.52
query23	16.89	1.02	0.97
query24	7.32	1.30	0.86
query25	0.39	0.12	0.04
query26	0.79	0.15	0.15
query27	0.04	0.04	0.04
query28	5.73	0.75	0.79
query29	12.64	2.32	2.32
query30	0.61	0.53	0.55
query31	2.82	0.38	0.37
query32	3.38	0.51	0.50
query33	3.12	3.08	3.06
query34	15.27	4.80	4.77
query35	4.84	4.84	4.81
query36	1.05	1.03	1.01
query37	0.06	0.05	0.05
query38	0.04	0.02	0.02
query39	0.02	0.01	0.02
query40	0.16	0.14	0.15
query41	0.06	0.02	0.01
query42	0.02	0.01	0.02
query43	0.03	0.02	0.01
Total cold run time: 103.94 s
Total hot run time: 30.52 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 9306484ba08006e3201f92618fa1ba1792301707 with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.8 seconds inserted 10000000 Rows, about 458K ops/s

@morrySnow
Copy link
Contributor Author

run feut

@morrySnow morrySnow merged commit 3877a7a into apache:branch-2.0 Oct 31, 2024
21 of 23 checks passed
@morrySnow morrySnow deleted the 2.0_41151 branch October 31, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants