Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat](restore) Support compressed snapshot meta and job info (#43516) #43568

Merged
merged 2 commits into from
Nov 11, 2024
Merged

[feat](restore) Support compressed snapshot meta and job info (#43516) #43568

merged 2 commits into from
Nov 11, 2024

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Nov 11, 2024

Cherry-pick #43516

@w41ter
[feat](restore) Support compressed snapshot meta and job info (apache…
0d08de4 
…#43516)

Related PR: selectdb/ccr-syncer#223

The backup meta and snapshot info are larger and might exceed the thrift
max message size limitation. This PR compresses the backup meta and job
info in both the `GetSnapshot` and `RestoreSnapshot` methods to avoid
this.

To keep compatibility, the field `compressed` is added to
`TGetSnapshotResult` to indicate whether the meta and job info are
compressed; config `enable_restore_snapshot_rpc_compression` indicates
whether the FE support reads the compressed meta and job info, the
ccr-syncer should read this config before issuing a restore snapshot
request with compressed meta and job info.

Support compressing large backup meta and snapshot job info, to avoid
exceeding the thrift server limitation.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@w41ter
Copy link
Contributor Author

w41ter commented Nov 11, 2024

run buildall

@w41ter
Copy link
Contributor Author

w41ter commented Nov 11, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@w41ter w41ter merged commit 677de34 into apache:branch-2.0 Nov 11, 2024
20 of 23 checks passed
@w41ter w41ter deleted the pick_43516_to_origin_branch-2.0 branch November 11, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@w41ter @doris-robot