Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](memory) Fix jemalloc hook deadlock at BE start #44009

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

xinyiZzz
Copy link
Contributor

@xinyiZzz xinyiZzz commented Nov 15, 2024

What problem does this PR solve?

Problem Summary:

It should be caused by the third-party library, but in any case, this fix should be possible.

Fix:

#0  0x00007f738432318c in __lll_lock_wait_private () from /lib64/libc.so.6
#1  0x00007f73843505ed in __internal_atexit () from /lib64/libc.so.6
#2  0x0000563f6a54db30 in malloc ()
#3  0x0000563f74e82b08 in operator new(unsigned long) ()
#4  0x0000563f6a6144bd in doris::ThreadContextPtr::ThreadContextPtr() ()
#5  0x0000563f6a54e21c in doris_calloc ()
#6  0x00007f7384350557 in __new_exitfn () from /lib64/libc.so.6
#7  0x00007f73843505fc in __internal_atexit () from /lib64/libc.so.6
#8  0x0000563f72c79c03 in ?? ()
#9  0x0000563f74e3b5fd in __libc_csu_init ()
#10 0x00007f7384339d18 in __libc_start_main () from /lib64/libc.so.6
#11 0x0000563f69ae302a in _start ()

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/service/doris_main.cpp Show resolved Hide resolved
@xiaokang
Copy link
Contributor

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.56% (8310/21553)
Line Coverage: 30.26% (68707/227087)
Region Coverage: 29.68% (35385/119209)
Branch Coverage: 25.45% (18196/71506)
Coverage Report: http://coverage.selectdb-in.cc/coverage/07aaf8d4ddce3aade604d7503dd897cb3d05d9bd_07aaf8d4ddce3aade604d7503dd897cb3d05d9bd/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 16, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@xiaokang xiaokang changed the title [branch-2.0](memory) Fix jemalloc hook deadlock at BE start [fix](memory) Fix jemalloc hook deadlock at BE start Nov 16, 2024
@xiaokang xiaokang merged commit c2732d4 into apache:branch-2.0 Nov 16, 2024
21 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.16-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants