Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug](runtime-filter) set inited to true on BloomFilterFuncBase::assi… #39335 #45388

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

BiteTheDDDDt
Copy link
Contributor

…gn (#39335)

Proposed changes

set inited to true on BloomFilterFuncBase::assign

*** SIGABRT unknown detail explain (@0x1ba2) received by PID 7074 (TID 9018 OR 0x7f4adf5df640) from PID 7074; stack trace: ***
 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /home/zcp/repo_center/doris_master/doris/be/src/common/signal_handler.h:421
 1# 0x00007F525A7F6520 in /lib/x86_64-linux-gnu/libc.so.6
 2# pthread_kill at ./nptl/pthread_kill.c:89
 3# raise at ../sysdeps/posix/raise.c:27
 4# abort at ./stdlib/abort.c:81
 5# 0x0000560BDC6CE8DD in /mnt/hdd01/ci/master-deploy/be/lib/doris_be
 6# 0x0000560BDC6C0F1A in /mnt/hdd01/ci/master-deploy/be/lib/doris_be
 7# google::LogMessage::SendToLog() in /mnt/hdd01/ci/master-deploy/be/lib/doris_be
 8# google::LogMessage::Flush() in /mnt/hdd01/ci/master-deploy/be/lib/doris_be
 9# google::LogMessageFatal::~LogMessageFatal() in /mnt/hdd01/ci/master-deploy/be/lib/doris_be
10# doris::BloomFilterFuncBase::merge(doris::BloomFilterFuncBase*) at /home/zcp/repo_center/doris_master/doris/be/src/exprs/bloom_filter_func.h:159
11# doris::RuntimePredicateWrapper::merge(doris::RuntimePredicateWrapper const*) at /home/zcp/repo_center/doris_master/doris/be/src/exprs/runtime_filter.cpp:539
12# doris::IRuntimeFilter::merge_from(doris::RuntimePredicateWrapper const*) in /mnt/hdd01/ci/master-deploy/be/lib/doris_be
13# doris::RuntimeFilterMergeControllerEntity::merge(doris::PMergeFilterRequest const*, butil::IOBufAsZeroCopyInputStream*) at /home/zcp/repo_center/doris_master/doris/be/src/runtime/runtime_filter_mgr.cpp:399
14# doris::FragmentMgr::merge_filter(doris::PMergeFilterRequest const*, butil::IOBufAsZeroCopyInputStream*) at /home/zcp/repo_center/doris_master/doris/be/src/runtime/fragment_mgr.cpp:1170
15# std::_Function_handler::_M_invoke(std::_Any_data const&) at /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:291
16# doris::WorkThreadPool::work_thread(int) at /home/zcp/repo_center/doris_master/doris/be/src/util/work_thread_pool.hpp:159
17# execute_native_thread_routine at ../../../../../libstdc++-v3/src/c++11/thread.cc:84
18# start_thread at ./nptl/pthread_create.c:442
19# 0x00007F525A8DA850 at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:83
172.20.50.47 last coredump sql: 

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…gn (#39335)

## Proposed changes
set inited to true on BloomFilterFuncBase::assign
```cpp
*** SIGABRT unknown detail explain (@0x1ba2) received by PID 7074 (TID 9018 OR 0x7f4adf5df640) from PID 7074; stack trace: ***
 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /home/zcp/repo_center/doris_master/doris/be/src/common/signal_handler.h:421
 1# 0x00007F525A7F6520 in /lib/x86_64-linux-gnu/libc.so.6
 2# pthread_kill at ./nptl/pthread_kill.c:89
 3# raise at ../sysdeps/posix/raise.c:27
 4# abort at ./stdlib/abort.c:81
 5# 0x0000560BDC6CE8DD in /mnt/hdd01/ci/master-deploy/be/lib/doris_be
 6# 0x0000560BDC6C0F1A in /mnt/hdd01/ci/master-deploy/be/lib/doris_be
 7# google::LogMessage::SendToLog() in /mnt/hdd01/ci/master-deploy/be/lib/doris_be
 8# google::LogMessage::Flush() in /mnt/hdd01/ci/master-deploy/be/lib/doris_be
 9# google::LogMessageFatal::~LogMessageFatal() in /mnt/hdd01/ci/master-deploy/be/lib/doris_be
10# doris::BloomFilterFuncBase::merge(doris::BloomFilterFuncBase*) at /home/zcp/repo_center/doris_master/doris/be/src/exprs/bloom_filter_func.h:159
11# doris::RuntimePredicateWrapper::merge(doris::RuntimePredicateWrapper const*) at /home/zcp/repo_center/doris_master/doris/be/src/exprs/runtime_filter.cpp:539
12# doris::IRuntimeFilter::merge_from(doris::RuntimePredicateWrapper const*) in /mnt/hdd01/ci/master-deploy/be/lib/doris_be
13# doris::RuntimeFilterMergeControllerEntity::merge(doris::PMergeFilterRequest const*, butil::IOBufAsZeroCopyInputStream*) at /home/zcp/repo_center/doris_master/doris/be/src/runtime/runtime_filter_mgr.cpp:399
14# doris::FragmentMgr::merge_filter(doris::PMergeFilterRequest const*, butil::IOBufAsZeroCopyInputStream*) at /home/zcp/repo_center/doris_master/doris/be/src/runtime/fragment_mgr.cpp:1170
15# std::_Function_handler::_M_invoke(std::_Any_data const&) at /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:291
16# doris::WorkThreadPool::work_thread(int) at /home/zcp/repo_center/doris_master/doris/be/src/util/work_thread_pool.hpp:159
17# execute_native_thread_routine at ../../../../../libstdc++-v3/src/c++11/thread.cc:84
18# start_thread at ./nptl/pthread_create.c:442
19# 0x00007F525A8DA850 at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:83
172.20.50.47 last coredump sql: 


```
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@BiteTheDDDDt BiteTheDDDDt merged commit b9bc792 into branch-2.0 Dec 13, 2024
24 of 28 checks passed
@BiteTheDDDDt BiteTheDDDDt deleted the cp_1213 branch December 17, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants