[Feat](Nereids) Support use mv hint #45855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 40176 ms |
TPC-DS: Total hot run time: 191442 ms |
ClickBench: Total hot run time: 33.65 s |
LiBinfeng-01
force-pushed
the
support_use_mv_hint
branch
from
ba21a85 to
1d16c55
Compare
|
run buildall |
TPC-H: Total hot run time: 32428 ms |
TPC-DS: Total hot run time: 196772 ms |
ClickBench: Total hot run time: 31.39 s |
seawinde
reviewed
Dec 25, 2024
| } | ||
| explain { | ||
| sql """select /*+ use_mv(mv3, mv1) */ c1 from t1""" | ||
| contains("Used: use_mv([mv3].[mv1] )") |
There was a problem hiding this comment.
should add mv_rewrite_success in Suite.groovy to check if use mv or not
There was a problem hiding this comment.
replace by explain memo plan
seawinde
reviewed
Dec 25, 2024
| explain { | ||
| sql """select /*+ no_use_mv(mv1, mv3) */ c1 from t1""" | ||
| contains("Used: no_use_mv([mv1].[mv3] )") | ||
| notContains("internal.test_cbo_use_mv.mv3") |
There was a problem hiding this comment.
notContains should use mv_not_part_in in Suite.groovy
There was a problem hiding this comment.
replace by explain memo plan
seawinde
reviewed
Dec 25, 2024
|
|
||
| sql """use ${db};""" | ||
| explain { | ||
| sql """select /*+ use_mv(mv1)*/ * from t1;""" |
There was a problem hiding this comment.
Maybe we should add three part names for async materialized view and for part names for sync materialized view test
seawinde
reviewed
Dec 25, 2024
| List<MaterializationContext> hintMTMVs = new ArrayList<>(); | ||
| if (useMvHint.isAllMv()) { | ||
| useMvHint.setStatus(Hint.HintStatus.SUCCESS); | ||
| return hintMTMVs; |
There was a problem hiding this comment.
this means no mv can be written?
|
run buildall |
TPC-H: Total hot run time: 32769 ms |
TPC-DS: Total hot run time: 190591 ms |
ClickBench: Total hot run time: 31.43 s |
|
run buildall |
TPC-H: Total hot run time: 32375 ms |
TPC-DS: Total hot run time: 196586 ms |
ClickBench: Total hot run time: 32.13 s |
|
run p0 |
|
run buildall |
TPC-H: Total hot run time: 32778 ms |
TPC-DS: Total hot run time: 195973 ms |
ClickBench: Total hot run time: 31.23 s |
|
run buildall |
TPC-H: Total hot run time: 32797 ms |
TPC-DS: Total hot run time: 196907 ms |
ClickBench: Total hot run time: 31.55 s |
seawinde
approved these changes
Dec 30, 2024
|
PR approved by anyone and no changes requested. |
englefly
approved these changes
Dec 30, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
support use_mv and no_use_mv hint to control mv chose strategy in cbo
explain select /*+ use_mv(mv1)*/ * from t1;Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)