Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch-3.0: [opt](recycler) Improve robustness and observability #45617 #45856

Merged
merged 1 commit into from
Dec 25, 2024
Merged

branch-3.0: [opt](recycler) Improve robustness and observability #45617 #45856

merged 1 commit into from
Dec 25, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #45617

@gavinchou
[opt](recycler) Improve robustness and observability (#45617)
419801e 
1. Fix delete non-existed object, the original impl. does not handle
correctly
2. Add recycle lag indicators: bvars for index, partition, rowset and
txn
    1. `recycle_index_earlest_ts_${instance_id}` dropped table/mv 
    2. `recycle_partition_earlest_ts_${instance_id}` dropped partitions
    3. `recycle_rowset_earlest_ts_${instance_id}` compacted rowset
4. `recycle_tmp_rowset_earlest_ts_${instance_id}` aborted transactions
tmp data
5. `recycle_expired_txn_label_earlest_ts_${instance_id}` expired labels
and transactions
4. Add retry for scan_and_recycle() to prevent KV error like "Request
future version"
6. Fix recycle delete instance may leak object data: we have to delete
data first before delete KV
7. Improve code readability: remove duplicated code and add more
comments
@Thearas
Copy link
Contributor

Thearas commented Dec 24, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Dec 24, 2024
@Thearas
Copy link
Contributor

Thearas commented Dec 24, 2024

run buildall

@dataroaring dataroaring merged commit 17ae38b into branch-3.0 Dec 25, 2024
21 checks passed
@github-actions github-actions bot deleted the auto-pick-45617-branch-3.0 branch December 25, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thearas @dataroaring @gavinchou