Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat](docker)Modify the init_be and start_be scripts to meet the requirements for rapid Docker startup(Merge 2.1). #45858

Merged

Conversation

FreeOnePlus
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #45267

Master PR: #45269

Problem Summary:

To meet the needs of rapid Docker startup, I have made adjustments to two related scripts in the Docker startup process. First, I added a env SKIP_CHECK_ULIMIT to the start_be.sh script, which will skip the size checks for swap, ulimit, and max_map_count. At the same time, I used --console to start the process and print logs. The reason why I did not use the --daemon daemon command to execute is that starting with a foreground log printing method in a Docker container is the correct and reliable approach.

At the same time, I added a check logic for a be.conf configuration item in the init_be.sh script: if it is the first time starting, append the export SKIP_CHECK_ULIMIT=true to skip the ulimit value check in the BE process. In summary, these adjustments can meet the basic requirements for rapid Docker startup usage.

Release note

None

Check List (For Author)

  • Test
    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  1. Set the ulimit, swap, and max_map_count check values on the host machine to values that do not meet the requirements.
  2. Run export SKIP_CHECK_ULIMIT=true and sh start_be.sh --console to start the BE process, which starts up normally.
  3. Run export SKIP_CHECK_ULIMIT=false,then using the --daemon or --console option to start, the BE process fails to start normally.
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 24, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@FreeOnePlus
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.48% (9575/26247)
Line Coverage: 27.95% (78732/281734)
Region Coverage: 26.61% (40411/151839)
Branch Coverage: 23.36% (20461/87586)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1bcc4efe0d903ea25067fa238f78a446e3c76947_1bcc4efe0d903ea25067fa238f78a446e3c76947/report/index.html

@yiguolei yiguolei merged commit 980f28f into apache:branch-2.1 Dec 25, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants