Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt](show) let all types table support show index #45861

Merged
merged 1 commit into from
Dec 25, 2024
Merged

[opt](show) let all types table support show index #45861

merged 1 commit into from
Dec 25, 2024

Conversation

morrySnow
Copy link
Contributor

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 24, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow morrySnow added area/mysql-compatibility Issues or PRs related to the mysql compatibility dev/2.1.x dev/3.0.x labels Dec 24, 2024
@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40037 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b3f4dc1ea8b54cc77e101f6d217749e1773b8465, data reload: false

------ Round 1 ----------------------------------
q1	17603	7474	7253	7253
q2	2049	181	166	166
q3	10553	1203	1154	1154
q4	10220	739	680	680
q5	7619	2678	2721	2678
q6	239	152	150	150
q7	1015	625	613	613
q8	9242	1847	1888	1847
q9	6679	6487	6494	6487
q10	6994	2330	2326	2326
q11	461	266	262	262
q12	437	226	218	218
q13	17768	2960	2956	2956
q14	239	203	207	203
q15	579	495	503	495
q16	671	600	599	599
q17	996	605	535	535
q18	7243	6758	6803	6758
q19	1345	913	988	913
q20	459	174	184	174
q21	4297	3252	3251	3251
q22	381	320	319	319
Total cold run time: 107089 ms
Total hot run time: 40037 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7226	7345	7233	7233
q2	330	230	225	225
q3	2923	2733	3012	2733
q4	2105	1815	1775	1775
q5	5580	5641	5600	5600
q6	217	137	141	137
q7	2179	1769	1782	1769
q8	3362	3480	3504	3480
q9	8890	8932	8881	8881
q10	3676	3567	3586	3567
q11	609	506	489	489
q12	798	625	579	579
q13	11543	3153	2988	2988
q14	305	270	262	262
q15	559	502	503	502
q16	677	646	648	646
q17	1819	1574	1555	1555
q18	7901	7396	7466	7396
q19	1662	1498	1427	1427
q20	2051	1832	1815	1815
q21	5384	5185	5234	5185
q22	641	581	577	577
Total cold run time: 70437 ms
Total hot run time: 58821 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190973 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b3f4dc1ea8b54cc77e101f6d217749e1773b8465, data reload: false

query1	988	377	378	377
query2	6520	2446	2400	2400
query3	6706	209	208	208
query4	33931	23724	23423	23423
query5	4416	456	461	456
query6	297	190	184	184
query7	4626	308	309	308
query8	308	246	235	235
query9	9455	2751	2753	2751
query10	507	258	254	254
query11	18159	15357	15240	15240
query12	167	102	106	102
query13	1685	424	427	424
query14	10263	8278	7229	7229
query15	328	181	179	179
query16	8159	446	471	446
query17	1776	563	542	542
query18	2139	285	289	285
query19	352	152	149	149
query20	114	111	107	107
query21	207	109	104	104
query22	4815	4560	4506	4506
query23	34322	33226	33846	33226
query24	11260	2439	2459	2439
query25	679	396	385	385
query26	1803	147	154	147
query27	2849	338	319	319
query28	7558	2440	2435	2435
query29	1029	404	408	404
query30	299	148	153	148
query31	1026	780	825	780
query32	95	57	60	57
query33	773	296	290	290
query34	1027	508	506	506
query35	905	747	718	718
query36	1099	934	969	934
query37	284	76	79	76
query38	4190	4143	4289	4143
query39	1501	1460	1428	1428
query40	285	101	98	98
query41	47	43	47	43
query42	113	100	101	100
query43	555	491	496	491
query44	1226	792	795	792
query45	184	168	166	166
query46	1151	697	697	697
query47	1994	1859	1906	1859
query48	405	318	326	318
query49	1261	395	405	395
query50	800	384	376	376
query51	7313	7103	7124	7103
query52	102	90	90	90
query53	256	188	180	180
query54	1105	389	409	389
query55	80	76	81	76
query56	261	278	229	229
query57	1280	1140	1137	1137
query58	230	215	222	215
query59	3351	3092	2944	2944
query60	289	240	240	240
query61	109	107	114	107
query62	915	718	773	718
query63	223	181	183	181
query64	5042	697	631	631
query65	3209	3181	3209	3181
query66	1412	315	320	315
query67	15839	15668	15670	15668
query68	5610	576	545	545
query69	429	258	252	252
query70	1197	1156	1104	1104
query71	325	252	266	252
query72	6320	4160	4090	4090
query73	793	370	359	359
query74	9393	8922	8792	8792
query75	3415	2656	2654	2654
query76	3534	1104	1070	1070
query77	530	267	287	267
query78	10194	9521	9434	9434
query79	1124	617	591	591
query80	838	428	521	428
query81	495	232	238	232
query82	1300	118	126	118
query83	274	168	145	145
query84	231	69	67	67
query85	1076	300	302	300
query86	319	298	306	298
query87	4474	4404	4535	4404
query88	3461	2207	2177	2177
query89	414	309	301	301
query90	2314	187	184	184
query91	141	105	107	105
query92	65	53	54	53
query93	1062	551	548	548
query94	942	287	287	287
query95	355	249	246	246
query96	617	279	282	279
query97	2862	2741	2668	2668
query98	229	201	253	201
query99	1639	1477	1439	1439
Total cold run time: 301626 ms
Total hot run time: 190973 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.74 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b3f4dc1ea8b54cc77e101f6d217749e1773b8465, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.03
query3	0.24	0.08	0.07
query4	1.60	0.10	0.10
query5	0.41	0.42	0.43
query6	1.20	0.67	0.66
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.58	0.50	0.53
query10	0.55	0.57	0.56
query11	0.14	0.10	0.11
query12	0.14	0.11	0.12
query13	0.60	0.61	0.59
query14	2.86	2.85	2.70
query15	0.89	0.83	0.82
query16	0.39	0.38	0.38
query17	1.01	1.03	1.04
query18	0.22	0.21	0.21
query19	1.90	1.73	2.07
query20	0.02	0.01	0.01
query21	15.36	0.59	0.56
query22	2.98	2.39	1.77
query23	16.77	0.91	0.80
query24	3.16	1.17	1.18
query25	0.22	0.14	0.09
query26	0.43	0.14	0.14
query27	0.06	0.04	0.04
query28	10.33	1.11	1.07
query29	12.59	3.26	3.25
query30	0.24	0.06	0.06
query31	2.86	0.40	0.39
query32	3.23	0.48	0.46
query33	3.10	3.12	3.07
query34	17.19	4.50	4.53
query35	4.57	4.47	4.56
query36	0.68	0.50	0.49
query37	0.10	0.06	0.05
query38	0.04	0.04	0.04
query39	0.03	0.03	0.02
query40	0.17	0.13	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 107.18 s
Total hot run time: 32.74 s

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Dec 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 091ba97 into apache:master Dec 25, 2024
28 of 29 checks passed
@morrySnow morrySnow deleted the show_key_for_all_table_type branch December 25, 2024 01:59
github-actions bot pushed a commit that referenced this pull request Dec 25, 2024
@morrySnow
[opt](show) let all types table support show index (#45861)
f62aa80
@github-actions github-actions bot mentioned this pull request Dec 25, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Dec 25, 2024
@morrySnow
[opt](show) let all types table support show index (#45861)
3879b02
@github-actions github-actions bot mentioned this pull request Dec 25, 2024
Merged
morrySnow added a commit that referenced this pull request Dec 25, 2024
@github-actions @morrySnow
branch-3.0: [opt](show) let all types table support show index #45861 (…
dda2469 
…#45895)

Cherry-picked from #45861

Co-authored-by: morrySnow <[email protected]>
morrySnow added a commit that referenced this pull request Jan 2, 2025
@github-actions @morrySnow
branch-2.1: [opt](show) let all types table support show index #45861 (…
068ff8d 
…#45898)

Cherry-picked from #45861

Co-authored-by: morrySnow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jibing-Li Jibing-Li Jibing-Li approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. area/mysql-compatibility Issues or PRs related to the mysql compatibility dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@morrySnow @Thearas @doris-robot @starocean999 @Jibing-Li