[fix](tvf) fix azure tvf: can not build s3() #45872

kaijchen · 2024-12-24T10:28:30Z

What problem does this PR solve?

Issue Number: DORIS-17644

Related PR: #37240

Problem Summary:

properties is an immutable map, trying to modify it will cause UnsupportedOperationException to be thrown.

2024-12-24 18:01:22,287 WARN (mysql-nio-pool-0|490) [StmtExecutor.executeByNereids():836] Nereids plan query failed:
SELECT * FROM S3 ( ... )
org.apache.doris.nereids.exceptions.AnalysisException: Can not build s3(): null
        at org.apache.doris.nereids.trees.expressions.functions.table.S3.toCatalogFunction(S3.java:55) ~[doris-fe.jar:1.2-SNAPSHOT]
        at com.google.common.base.Suppliers$NonSerializableMemoizingSupplier.get(Suppliers.java:186) ~[guava-33.2.1-jre.jar:?]
        at org.apache.doris.nereids.trees.expressions.functions.table.TableValuedFunction.lambda$new$0(TableValuedFunction.java:55) ~[doris-fe.jar:1.2-SNAPSHOT]
        at com.google.common.base.Suppliers$NonSerializableMemoizingSupplier.get(Suppliers.java:186) ~[guava-33.2.1-jre.jar:?]
        at org.apache.doris.nereids.trees.expressions.functions.table.TableValuedFunction.getTable(TableValuedFunction.java:103) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.nereids.trees.plans.logical.LogicalTVFRelation.computeOutput(LogicalTVFRelation.java:105) ~[doris-fe.jar:1.2-SNAPSHOT]
        at com.google.common.base.Suppliers$NonSerializableMemoizingSupplier.get(Suppliers.java:186) ~[guava-33.2.1-jre.jar:?]
        at org.apache.doris.nereids.properties.LogicalProperties.getOutput(LogicalProperties.java:104) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.nereids.trees.plans.AbstractPlan.getOutput(AbstractPlan.java:169) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.nereids.util.PlanUtils.fastGetChildrenOutputs(PlanUtils.java:161) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.nereids.rules.analysis.BindExpression.buildSimpleExprAnalyzer(BindExpression.java:1241) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.nereids.rules.analysis.BindExpression.bindProject(BindExpression.java:626) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.nereids.pattern.PatternMatcher$1.transform(PatternMatcher.java:92) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.nereids.rules.AppliedAwareRule.transform(AppliedAwareRule.java:55) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.nereids.jobs.rewrite.PlanTreeRewriteJob.rewrite(PlanTreeRewriteJob.java:57) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.nereids.jobs.rewrite.PlanTreeRewriteBottomUpJob.rewriteThis(PlanTreeRewriteBottomUpJob.java:91) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.nereids.jobs.rewrite.PlanTreeRewriteBottomUpJob.execute(PlanTreeRewriteBottomUpJob.java:75) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.nereids.jobs.scheduler.SimpleJobScheduler.executeJobPool(SimpleJobScheduler.java:44) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.nereids.jobs.rewrite.RootPlanTreeRewriteJob.execute(RootPlanTreeRewriteJob.java:66) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.nereids.jobs.executor.AbstractBatchJobExecutor.execute(AbstractBatchJobExecutor.java:139) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.nereids.jobs.executor.Analyzer.analyze(Analyzer.java:87) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.nereids.NereidsPlanner.lambda$analyze$4(NereidsPlanner.java:361) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.nereids.NereidsPlanner.keepOrShowPlanProcess(NereidsPlanner.java:888) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.nereids.NereidsPlanner.analyze(NereidsPlanner.java:361) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.nereids.NereidsPlanner.planWithoutLock(NereidsPlanner.java:250) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.nereids.NereidsPlanner.planWithLock(NereidsPlanner.java:224) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.nereids.NereidsPlanner.plan(NereidsPlanner.java:145) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.qe.StmtExecutor.executeByNereids(StmtExecutor.java:830) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.qe.StmtExecutor.execute(StmtExecutor.java:609) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.qe.StmtExecutor.queryRetry(StmtExecutor.java:572) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.qe.StmtExecutor.execute(StmtExecutor.java:562) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.qe.ConnectProcessor.executeQuery(ConnectProcessor.java:347) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.qe.ConnectProcessor.handleQuery(ConnectProcessor.java:250) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.qe.MysqlConnectProcessor.handleQuery(MysqlConnectProcessor.java:209) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.qe.MysqlConnectProcessor.dispatch(MysqlConnectProcessor.java:237) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.qe.MysqlConnectProcessor.processOnce(MysqlConnectProcessor.java:417) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.mysql.ReadListener.lambda$handleEvent$0(ReadListener.java:52) ~[doris-fe.jar:1.2-SNAPSHOT]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
        at java.lang.Thread.run(Thread.java:833) ~[?:?]
Caused by: java.lang.UnsupportedOperationException
        at com.google.common.collect.ImmutableMap.put(ImmutableMap.java:814) ~[guava-33.2.1-jre.jar:?]
        at org.apache.doris.tablefunction.S3TableValuedFunction.<init>(S3TableValuedFunction.java:66) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.nereids.trees.expressions.functions.table.S3.toCatalogFunction(S3.java:53) ~[doris-fe.jar:1.2-SNAPSHOT]
        ... 39 more

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2024-12-24T10:28:35Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

kaijchen · 2024-12-24T10:28:56Z

run buildall

doris-robot · 2024-12-24T10:53:19Z

TPC-H: Total hot run time: 39978 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 364e0a1688f58d5c72100283e29ffdff7048459b, data reload: false

------ Round 1 ----------------------------------
q1	17602	7482	7295	7295
q2	2051	185	175	175
q3	10537	1128	1191	1128
q4	10240	744	740	740
q5	7600	2691	2664	2664
q6	245	149	149	149
q7	992	622	611	611
q8	9235	1824	1896	1824
q9	6691	6467	6395	6395
q10	6995	2317	2369	2317
q11	460	258	260	258
q12	407	224	224	224
q13	17770	2977	2906	2906
q14	248	220	209	209
q15	533	506	496	496
q16	690	607	579	579
q17	972	631	666	631
q18	7407	6674	6688	6674
q19	1342	991	1010	991
q20	491	192	185	185
q21	4093	3226	3301	3226
q22	377	301	311	301
Total cold run time: 106978 ms
Total hot run time: 39978 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7251	7255	7236	7236
q2	329	228	239	228
q3	2939	2734	2997	2734
q4	2132	1815	1912	1815
q5	5628	5605	5623	5605
q6	227	139	139	139
q7	2167	1785	1758	1758
q8	3368	3493	3500	3493
q9	8865	8871	8952	8871
q10	3671	3580	3576	3576
q11	610	499	499	499
q12	788	598	602	598
q13	13297	3147	3013	3013
q14	285	272	271	271
q15	552	499	534	499
q16	699	658	653	653
q17	1846	1595	1576	1576
q18	7842	7472	7488	7472
q19	1682	1501	1465	1465
q20	2061	1792	1857	1792
q21	5343	5288	5326	5288
q22	657	580	563	563
Total cold run time: 72239 ms
Total hot run time: 59144 ms

doris-robot · 2024-12-24T11:05:31Z

TPC-DS: Total hot run time: 190952 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 364e0a1688f58d5c72100283e29ffdff7048459b, data reload: false

query1	976	381	389	381
query2	6527	2553	2440	2440
query3	6720	223	211	211
query4	33632	23441	23427	23427
query5	4370	490	444	444
query6	275	188	200	188
query7	4638	311	309	309
query8	301	237	243	237
query9	9824	2780	2770	2770
query10	475	257	264	257
query11	18109	15956	15486	15486
query12	155	104	103	103
query13	1746	441	428	428
query14	12163	6820	6956	6820
query15	289	176	182	176
query16	8131	472	493	472
query17	1752	595	605	595
query18	2144	299	288	288
query19	362	149	150	149
query20	121	108	111	108
query21	201	105	117	105
query22	4789	4577	4387	4387
query23	34317	33440	33596	33440
query24	11056	2581	2410	2410
query25	659	405	404	404
query26	1821	151	149	149
query27	2843	327	330	327
query28	8139	2456	2470	2456
query29	1038	404	406	404
query30	294	152	149	149
query31	1043	810	801	801
query32	95	85	57	57
query33	770	313	286	286
query34	961	510	515	510
query35	914	750	753	750
query36	1111	967	942	942
query37	284	68	77	68
query38	4157	3991	4039	3991
query39	1515	1426	1447	1426
query40	280	101	99	99
query41	48	42	46	42
query42	122	104	103	103
query43	528	502	494	494
query44	1253	804	800	800
query45	183	161	165	161
query46	1176	704	715	704
query47	1980	1876	1890	1876
query48	410	327	317	317
query49	1275	390	400	390
query50	813	373	392	373
query51	7276	7113	7133	7113
query52	104	92	92	92
query53	257	181	189	181
query54	1244	420	413	413
query55	86	79	78	78
query56	259	243	247	243
query57	1276	1183	1125	1125
query58	238	232	228	228
query59	3281	3125	2839	2839
query60	277	249	256	249
query61	111	110	115	110
query62	939	712	734	712
query63	213	192	191	191
query64	5043	655	648	648
query65	3275	3184	3210	3184
query66	1410	308	319	308
query67	15840	15551	15647	15551
query68	5859	617	556	556
query69	433	245	249	245
query70	1177	1091	1138	1091
query71	436	257	246	246
query72	7277	4181	4212	4181
query73	809	372	380	372
query74	10491	8809	9118	8809
query75	3414	2648	2645	2645
query76	3625	1156	1136	1136
query77	555	267	283	267
query78	10193	9392	9593	9392
query79	2443	611	616	611
query80	1059	428	441	428
query81	546	229	222	222
query82	831	115	120	115
query83	241	146	147	146
query84	236	75	79	75
query85	1395	310	306	306
query86	446	304	302	302
query87	4436	4581	4295	4295
query88	4162	2231	2208	2208
query89	408	294	291	291
query90	2182	187	186	186
query91	144	105	106	105
query92	68	53	52	52
query93	1472	561	562	561
query94	1133	294	289	289
query95	370	260	257	257
query96	623	297	285	285
query97	2859	2695	2667	2667
query98	216	196	195	195
query99	1654	1448	1441	1441
Total cold run time: 309107 ms
Total hot run time: 190952 ms

dataroaring

LGTM

github-actions · 2024-12-24T11:10:45Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-12-24T11:10:47Z

PR approved by anyone and no changes requested.

doris-robot · 2024-12-24T11:11:02Z

ClickBench: Total hot run time: 32.7 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 364e0a1688f58d5c72100283e29ffdff7048459b, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.03	0.04
query3	0.24	0.07	0.07
query4	1.60	0.10	0.10
query5	0.43	0.42	0.40
query6	1.18	0.65	0.65
query7	0.03	0.02	0.01
query8	0.04	0.03	0.03
query9	0.58	0.50	0.51
query10	0.54	0.59	0.55
query11	0.15	0.10	0.10
query12	0.14	0.10	0.11
query13	0.61	0.61	0.60
query14	2.69	2.86	2.74
query15	0.89	0.82	0.82
query16	0.39	0.38	0.39
query17	1.04	1.07	1.04
query18	0.22	0.21	0.21
query19	1.89	1.80	2.00
query20	0.02	0.01	0.01
query21	15.36	0.62	0.56
query22	3.11	2.43	1.71
query23	17.00	0.87	0.79
query24	2.93	1.26	1.15
query25	0.20	0.06	0.13
query26	0.42	0.14	0.15
query27	0.05	0.04	0.04
query28	10.48	1.10	1.07
query29	12.56	3.25	3.23
query30	0.25	0.07	0.07
query31	2.85	0.40	0.38
query32	3.24	0.46	0.46
query33	3.05	3.05	3.11
query34	16.53	4.54	4.51
query35	4.59	4.51	4.52
query36	0.69	0.48	0.48
query37	0.10	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.17	0.13	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 106.62 s
Total hot run time: 32.7 s

kaijchen · 2024-12-24T11:36:54Z

run buildall

dataroaring

LGTM

github-actions · 2024-12-25T01:33:58Z

PR approved by at least one committer and no changes requested.

kaijchen · 2024-12-25T02:53:27Z

run buildall

doris-robot · 2024-12-25T04:11:18Z

TPC-H: Total hot run time: 32717 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e1e228a39dff473459a442463532ba1d87b470b7, data reload: false

------ Round 1 ----------------------------------
q1	17955	6293	6161	6161
q2	2046	309	179	179
q3	10680	1225	774	774
q4	10280	870	442	442
q5	8473	2180	1982	1982
q6	209	184	158	158
q7	893	766	606	606
q8	9243	1343	1145	1145
q9	5276	4879	4889	4879
q10	6763	2317	1849	1849
q11	470	281	248	248
q12	358	378	226	226
q13	17773	3555	2942	2942
q14	242	228	217	217
q15	554	510	499	499
q16	633	637	593	593
q17	572	850	324	324
q18	7136	6512	6479	6479
q19	2218	972	571	571
q20	304	323	184	184
q21	2912	2245	1953	1953
q22	357	335	306	306
Total cold run time: 105347 ms
Total hot run time: 32717 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6359	6260	6246	6246
q2	233	330	233	233
q3	2219	2630	2356	2356
q4	1402	1835	1367	1367
q5	4336	4802	4886	4802
q6	184	184	144	144
q7	2069	2006	1808	1808
q8	2633	2817	2649	2649
q9	7321	7313	7329	7313
q10	3096	3365	2766	2766
q11	578	510	489	489
q12	708	805	633	633
q13	3393	3787	3152	3152
q14	281	316	288	288
q15	580	517	495	495
q16	642	707	649	649
q17	1270	1757	1266	1266
q18	7711	7516	7368	7368
q19	868	1189	1115	1115
q20	2036	2023	1896	1896
q21	5742	5300	4997	4997
q22	620	623	594	594
Total cold run time: 54281 ms
Total hot run time: 52626 ms

doris-robot · 2024-12-25T04:23:47Z

TPC-DS: Total hot run time: 197801 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e1e228a39dff473459a442463532ba1d87b470b7, data reload: false

query1	1255	971	913	913
query2	6462	2367	2393	2367
query3	11118	4952	5011	4952
query4	33229	23927	23500	23500
query5	4128	597	465	465
query6	291	189	177	177
query7	3998	487	305	305
query8	310	261	232	232
query9	9381	2733	2728	2728
query10	450	306	243	243
query11	18120	15361	15232	15232
query12	161	109	106	106
query13	1582	533	401	401
query14	9699	7388	7541	7388
query15	250	201	184	184
query16	7896	645	478	478
query17	1632	764	591	591
query18	2125	407	322	322
query19	217	184	160	160
query20	121	111	119	111
query21	200	156	105	105
query22	4648	4775	4578	4578
query23	34592	34000	34648	34000
query24	6883	2294	2377	2294
query25	468	463	387	387
query26	1171	273	159	159
query27	2317	453	335	335
query28	5606	2508	2501	2501
query29	697	569	424	424
query30	206	216	156	156
query31	1003	930	879	879
query32	73	64	58	58
query33	511	366	289	289
query34	791	853	518	518
query35	819	856	773	773
query36	1034	1076	988	988
query37	112	100	79	79
query38	4163	4241	4161	4161
query39	1578	1529	1503	1503
query40	213	111	103	103
query41	43	44	42	42
query42	116	104	102	102
query43	542	527	502	502
query44	1319	823	813	813
query45	183	174	170	170
query46	891	1074	683	683
query47	2017	2034	1964	1964
query48	383	420	331	331
query49	749	488	420	420
query50	652	667	413	413
query51	7303	7124	7180	7124
query52	104	99	95	95
query53	234	257	190	190
query54	472	490	403	403
query55	77	83	84	83
query56	270	270	250	250
query57	1258	1277	1167	1167
query58	247	226	224	224
query59	3268	3500	3232	3232
query60	275	261	265	261
query61	105	104	108	104
query62	851	819	772	772
query63	231	199	211	199
query64	4158	1013	674	674
query65	3384	3260	3278	3260
query66	770	410	307	307
query67	16546	15828	15526	15526
query68	9296	757	503	503
query69	483	292	256	256
query70	1224	1165	1101	1101
query71	428	293	250	250
query72	5910	3804	3885	3804
query73	659	757	361	361
query74	10405	9140	8777	8777
query75	4600	3140	2653	2653
query76	5327	1181	751	751
query77	968	371	376	371
query78	9990	10197	9435	9435
query79	5551	888	589	589
query80	730	522	438	438
query81	498	266	246	246
query82	256	152	129	129
query83	193	162	157	157
query84	276	96	72	72
query85	814	373	302	302
query86	352	323	268	268
query87	4408	4368	4478	4368
query88	4270	2206	2209	2206
query89	444	340	299	299
query90	2144	188	188	188
query91	129	138	109	109
query92	65	53	50	50
query93	3707	881	528	528
query94	693	390	291	291
query95	339	264	247	247
query96	478	622	283	283
query97	2743	2780	2664	2664
query98	221	217	204	204
query99	1634	1518	1445	1445
Total cold run time: 305193 ms
Total hot run time: 197801 ms

doris-robot · 2024-12-25T04:29:09Z

ClickBench: Total hot run time: 31.92 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e1e228a39dff473459a442463532ba1d87b470b7, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.62	0.10	0.11
query5	0.44	0.41	0.40
query6	1.16	0.64	0.65
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.59	0.50	0.51
query10	0.56	0.59	0.56
query11	0.15	0.10	0.10
query12	0.14	0.11	0.12
query13	0.61	0.61	0.60
query14	2.75	2.75	2.71
query15	0.88	0.82	0.82
query16	0.39	0.37	0.38
query17	1.08	1.06	1.01
query18	0.22	0.20	0.21
query19	1.96	1.77	2.00
query20	0.01	0.02	0.01
query21	15.35	0.94	0.58
query22	0.75	1.02	0.73
query23	15.05	1.53	0.60
query24	3.41	1.55	2.03
query25	0.14	0.20	0.11
query26	0.24	0.16	0.13
query27	0.08	0.05	0.06
query28	14.18	1.45	1.05
query29	12.56	3.93	3.24
query30	0.24	0.09	0.07
query31	2.82	0.60	0.38
query32	3.23	0.55	0.46
query33	3.08	3.23	3.07
query34	16.84	5.14	4.54
query35	4.53	4.53	4.48
query36	0.65	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.14	0.13
query41	0.07	0.02	0.03
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.57 s
Total hot run time: 31.92 s

kaijchen · 2024-12-25T05:03:28Z

run buildall

dataroaring added dev/2.1.x dev/3.0.x labels Dec 24, 2024

dataroaring previously approved these changes Dec 24, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 24, 2024

github-actions bot added the reviewed label Dec 24, 2024

kaijchen dismissed dataroaring’s stale review via 4e50a2e December 24, 2024 11:34

kaijchen force-pushed the fix-azure-tvf branch from 364e0a1 to 4e50a2e Compare December 24, 2024 11:34

[fix](tvf) fix azure tvf: can not build s3()

1b3aab1

github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 24, 2024

kaijchen force-pushed the fix-azure-tvf branch from 4e50a2e to 1b3aab1 Compare December 24, 2024 11:34

fixup

abc56fd

dataroaring previously approved these changes Dec 25, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 25, 2024

kaijchen dismissed dataroaring’s stale review via 83a66fb December 25, 2024 02:45

github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 25, 2024

fixup

e1e228a

kaijchen force-pushed the fix-azure-tvf branch from 83a66fb to e1e228a Compare December 25, 2024 02:53

improve

326379c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[fix](tvf) fix azure tvf: can not build s3() #45872

[fix](tvf) fix azure tvf: can not build s3() #45872

kaijchen commented Dec 24, 2024 •

edited

Loading

Thearas commented Dec 24, 2024

kaijchen commented Dec 24, 2024

doris-robot commented Dec 24, 2024

doris-robot commented Dec 24, 2024

dataroaring left a comment

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

doris-robot commented Dec 24, 2024

kaijchen commented Dec 24, 2024

dataroaring left a comment

github-actions bot commented Dec 25, 2024

kaijchen commented Dec 25, 2024

doris-robot commented Dec 25, 2024

doris-robot commented Dec 25, 2024

doris-robot commented Dec 25, 2024

kaijchen commented Dec 25, 2024

[fix](tvf) fix azure tvf: can not build s3() #45872

Are you sure you want to change the base?

[fix](tvf) fix azure tvf: can not build s3() #45872

Conversation

kaijchen commented Dec 24, 2024 • edited Loading

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Thearas commented Dec 24, 2024

kaijchen commented Dec 24, 2024

doris-robot commented Dec 24, 2024

doris-robot commented Dec 24, 2024

dataroaring left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

doris-robot commented Dec 24, 2024

kaijchen commented Dec 24, 2024

dataroaring left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 25, 2024

kaijchen commented Dec 25, 2024

doris-robot commented Dec 25, 2024

doris-robot commented Dec 25, 2024

doris-robot commented Dec 25, 2024

kaijchen commented Dec 25, 2024

kaijchen commented Dec 24, 2024 •

edited

Loading