[feature](nereids)support create function command in nereids #45874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 39927 ms |
TPC-DS: Total hot run time: 196454 ms |
ClickBench: Total hot run time: 32.2 s |
starocean999
force-pushed
the
nereids_create_function
branch
from
611affd to
f5249ed
Compare
|
run buildall |
TPC-H: Total hot run time: 32503 ms |
TPC-DS: Total hot run time: 196810 ms |
ClickBench: Total hot run time: 31.09 s |
starocean999
force-pushed
the
nereids_create_function
branch
from
f5249ed to
02ccc8e
Compare
|
run buildall |
TPC-H: Total hot run time: 32446 ms |
TPC-DS: Total hot run time: 190151 ms |
ClickBench: Total hot run time: 30.96 s |
|
run buildall |
TPC-H: Total hot run time: 32395 ms |
TPC-DS: Total hot run time: 192236 ms |
ClickBench: Total hot run time: 31.28 s |
morrySnow
reviewed
Jan 2, 2025
Comment on lines
4345
to
4418
| SetType setType; | ||
| if (ctx.GLOBAL() != null) { | ||
| setType = SetType.GLOBAL; | ||
| } else if (ctx.LOCAL() != null || ctx.SESSION() != null) { | ||
| setType = SetType.SESSION; | ||
| } else { | ||
| setType = SetType.DEFAULT; | ||
| } |
There was a problem hiding this comment.
This code is duplicated many times and needs to be abstracted.
| @@ -4331,6 +4340,117 @@ public LogicalPlan visitCreateTableLike(CreateTableLikeContext ctx) { | |||
| return new CreateTableLikeCommand(info); | |||
| } | |||
|
|
|||
| @Override | |||
| public Command visitCreateUserDefineFunction(CreateUserDefineFunctionContext ctx) { | |||
| SetType setType; | |||
There was a problem hiding this comment.
SetType is not a good name since it is not just used in SetCommand
| private Type[] argTypes; | ||
|
|
||
| public FunctionArgsDefInfo(List<DataType> argTypeDefs, boolean isVariadic) { | ||
| this.argTypeDefs = argTypeDefs; |
There was a problem hiding this comment.
Utils.fastToImmutableList(Objects.requireNonNull(argTypeDefs, "argTypeDefs should not be null"))
| /** | ||
| * represent function arguments | ||
| */ | ||
| public class FunctionArgsDefInfo { |
There was a problem hiding this comment.
if only have data types, maybe we should change it name to a better one
Comment on lines
4440
to
4446
| if (isTableFunction) { | ||
| return new CreateFunctionCommand(setType, ifNotExists, function, functionArgsDefInfo, returnType, | ||
| intermediateType, properties); | ||
| } else { | ||
| return new CreateFunctionCommand(setType, ifNotExists, isAggFunction, function, functionArgsDefInfo, | ||
| returnType, intermediateType, properties); | ||
| } |
There was a problem hiding this comment.
why use different ctor for table function?
| } else if (isAlias) { | ||
| analyzeAliasFunction(ctx); | ||
| } else if (isTableFunction) { | ||
| analyzeTableFunction(); |
There was a problem hiding this comment.
Suggested change
| analyzeTableFunction(); | |
| analyzeUdtf(); |
| return StmtType.CREATE; | ||
| } | ||
|
|
||
| private void validate(ConnectContext ctx) throws Exception { |
There was a problem hiding this comment.
Suggested change
| private void validate(ConnectContext ctx) throws Exception { | |
| private void analyze(ConnectContext ctx) throws Exception { |
| @@ -1831,4 +1834,243 @@ private static boolean supportCompare(DataType dataType) { | |||
| } | |||
| return true; | |||
| } | |||
|
|
|||
| public static void validateDataType(DataType dataType) { | |||
There was a problem hiding this comment.
should not add this function in TypeCoercionUtils. add this function in DataType and Type directly
| } | ||
| } | ||
|
|
||
| private Boolean parseBooleanFromProperties(String propertyString) throws AnalysisException { |
There was a problem hiding this comment.
parseOrDefault maybe better for use
| } | ||
| String expirationTimeString = properties.get(EXPIRATION_TIME); | ||
| if (expirationTimeString != null) { | ||
| long timeMinutes = Long.parseLong(expirationTimeString); |
There was a problem hiding this comment.
should we need to catch number exception for better error message?
starocean999
force-pushed
the
nereids_create_function
branch
from
02ccc8e to
2fa60f1
Compare
|
run buildall |
TPC-H: Total hot run time: 32649 ms |
TPC-DS: Total hot run time: 197418 ms |
ClickBench: Total hot run time: 31.67 s |
starocean999
force-pushed
the
nereids_create_function
branch
from
2fa60f1 to
d2a0fdf
Compare
|
run buildall |
TPC-H: Total hot run time: 32641 ms |
TPC-DS: Total hot run time: 194781 ms |
ClickBench: Total hot run time: 31.1 s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)