[refactor](exec) refactor analytic operator to improve performance #46181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 32773 ms |
|
TeamCity be ut coverage result: |
|
run buildall |
TPC-H: Total hot run time: 32571 ms |
|
TeamCity be ut coverage result: |
zhangstar333
force-pushed
the
support_range_between
branch
from
c2155d6 to
3cd5904
Compare
|
run buildall |
TPC-H: Total hot run time: 32757 ms |
|
TeamCity be ut coverage result: |
|
run buildall |
2 similar comments
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 33981 ms |
TPC-DS: Total hot run time: 194699 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 31.57 s |
|
run buildall |
TPC-H: Total hot run time: 33810 ms |
|
TeamCity be ut coverage result: |
|
run buildall |
TPC-H: Total hot run time: 33825 ms |
TPC-DS: Total hot run time: 195996 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 31.36 s |
|
run buildall |
TPC-H: Total hot run time: 33899 ms |
|
TeamCity be ut coverage result: |
|
run buildall |
TPC-DS: Total hot run time: 185728 ms |
ClickBench: Total hot run time: 30.46 s |
|
TeamCity be ut coverage result: |
zhangstar333
changed the title
|
run p1 |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 32606 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 192622 ms |
ClickBench: Total hot run time: 30.93 s |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 32583 ms |
TPC-DS: Total hot run time: 192536 ms |
ClickBench: Total hot run time: 31.34 s |
HappenLee
reviewed
Jan 10, 2025
| // For window frame `ROWS|RANGE BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING` | ||
| _executor.get_next_impl = &AnalyticSinkLocalState::_get_next_for_partition; | ||
| } else if (p._has_range_window) { | ||
| if (!p._has_window_start && !p._has_window_end) { |
There was a problem hiding this comment.
why try to do the work in FE？better add the check in FE set ！has_window？ consider update
|
run buildall |
TPC-H: Total hot run time: 32978 ms |
TPC-DS: Total hot run time: 185972 ms |
ClickBench: Total hot run time: 31.91 s |
|
TeamCity be ut coverage result: |
HappenLee
reviewed
Jan 13, 2025
| _destroy_agg_status(); | ||
| _agg_arena_pool = nullptr; | ||
|
|
||
| std::vector<vectorized::MutableColumnPtr> tmp_result_window_columns; |
HappenLee
reviewed
Jan 13, 2025
|
|
||
| private: | ||
| friend class AnalyticSinkOperatorX; | ||
| Status _execute_impl(); | ||
| bool _get_next_for_partition(int64_t batch_rows, int64_t current_block_base_pos); |
There was a problem hiding this comment.
add comment for all get_next function !
HappenLee
reviewed
Jan 13, 2025
| } else { | ||
| current_row_start = _current_row_position + _rows_start_offset; | ||
| } | ||
| // Make sure range_start <= range_end |
There was a problem hiding this comment.
what case happen? Fox exmaple in comment
HappenLee
reviewed
Jan 13, 2025
| _fn_place_ptr + _offsets_of_aggregate_states[i], | ||
| &dst->get_nested_column()); | ||
| } | ||
| continue; |
There was a problem hiding this comment.
why not use if else ? what are you doing ?
HappenLee
reviewed
Jan 13, 2025
| return shared_state.all_block_end; | ||
| // If the end is not greater than the start, the current window should be empty. | ||
| // _current_window_empty = false; | ||
| _current_window_empty = |
There was a problem hiding this comment.
if empty window? should we do add_range_single_place agg exec? maybe unelss?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)