-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor](exec) Remove unless code and add comment #46503
Open
HappenLee
wants to merge
2
commits into
apache:master
Choose a base branch
from
HappenLee:new_cache
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+27
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 32678 ms
|
TPC-DS: Total hot run time: 190635 ms
|
ClickBench: Total hot run time: 31.17 s
|
run buildall |
yiguolei
previously approved these changes
Jan 13, 2025
github-actions
bot
added
the
approved
Indicates a PR has been approved by one committer.
label
Jan 13, 2025
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 33819 ms
|
TPC-DS: Total hot run time: 195509 ms
|
ClickBench: Total hot run time: 31.7 s
|
run buildall |
github-actions
bot
removed
the
approved
Indicates a PR has been approved by one committer.
label
Jan 13, 2025
run buildall |
yiguolei
approved these changes
Jan 13, 2025
github-actions
bot
added
the
approved
Indicates a PR has been approved by one committer.
label
Jan 13, 2025
PR approved by at least one committer and no changes requested. |
TPC-H: Total hot run time: 32515 ms
|
TPC-DS: Total hot run time: 194148 ms
|
ClickBench: Total hot run time: 31.62 s
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Remove unless code and add comment be/src/pipeline/pipeline_task.h/ be/src/vec/runtime/vdatetime_value.h
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)