Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor](exec) Remove unless code and add comment #46503

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HappenLee
Copy link
Contributor

What problem does this PR solve?

Remove unless code and add comment be/src/pipeline/pipeline_task.h/ be/src/vec/runtime/vdatetime_value.h

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@HappenLee
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32678 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f9b474709a69284d1d9dba792a7f08101159344f, data reload: false

------ Round 1 ----------------------------------
q1	17594	6173	6065	6065
q2	2053	297	175	175
q3	10485	1297	721	721
q4	10222	889	447	447
q5	7548	2388	2011	2011
q6	211	186	149	149
q7	911	767	612	612
q8	9239	1401	1206	1206
q9	5400	4932	4960	4932
q10	6755	2316	1895	1895
q11	496	284	266	266
q12	352	356	218	218
q13	17768	3665	3008	3008
q14	244	231	213	213
q15	564	509	499	499
q16	627	632	586	586
q17	606	860	339	339
q18	7229	6638	6280	6280
q19	3047	973	560	560
q20	300	324	185	185
q21	2897	2174	1993	1993
q22	371	336	318	318
Total cold run time: 104919 ms
Total hot run time: 32678 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6567	6258	6262	6258
q2	232	326	236	236
q3	2234	2680	2344	2344
q4	1399	1833	1333	1333
q5	4363	4785	5009	4785
q6	189	191	144	144
q7	2127	1988	1806	1806
q8	2617	2784	2672	2672
q9	7360	7246	7364	7246
q10	3056	3357	2824	2824
q11	583	510	484	484
q12	662	746	614	614
q13	3461	3909	3189	3189
q14	287	321	290	290
q15	563	508	504	504
q16	666	684	647	647
q17	1236	1751	1256	1256
q18	7817	7621	7335	7335
q19	833	1202	1096	1096
q20	1973	2036	1908	1908
q21	5592	5333	4918	4918
q22	585	654	578	578
Total cold run time: 54402 ms
Total hot run time: 52467 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190635 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f9b474709a69284d1d9dba792a7f08101159344f, data reload: false

query1	977	386	366	366
query2	6515	2411	2400	2400
query3	6701	214	217	214
query4	33587	23505	23976	23505
query5	4308	604	491	491
query6	294	211	182	182
query7	4647	493	300	300
query8	299	255	235	235
query9	9534	2789	2741	2741
query10	470	312	250	250
query11	18112	15386	15260	15260
query12	164	111	110	110
query13	1685	539	425	425
query14	10967	6801	6748	6748
query15	248	201	193	193
query16	8033	597	445	445
query17	1578	738	568	568
query18	2098	382	286	286
query19	225	167	154	154
query20	127	110	131	110
query21	209	122	103	103
query22	4281	4515	4258	4258
query23	34857	33230	33680	33230
query24	6338	2253	2260	2253
query25	496	444	382	382
query26	1207	267	147	147
query27	2508	447	329	329
query28	5853	2486	2464	2464
query29	740	545	409	409
query30	226	181	164	164
query31	1011	898	827	827
query32	97	62	60	60
query33	521	333	296	296
query34	774	814	500	500
query35	814	807	755	755
query36	1018	1053	929	929
query37	113	99	80	80
query38	4185	4152	4058	4058
query39	1495	1427	1426	1426
query40	219	118	102	102
query41	47	46	46	46
query42	124	106	102	102
query43	528	553	502	502
query44	1272	812	797	797
query45	177	169	162	162
query46	856	1045	646	646
query47	1919	1982	1863	1863
query48	394	405	339	339
query49	759	480	418	418
query50	618	667	388	388
query51	7201	7168	7174	7168
query52	105	102	90	90
query53	229	252	186	186
query54	472	485	412	412
query55	77	76	79	76
query56	258	258	253	253
query57	1225	1197	1142	1142
query58	247	225	230	225
query59	3065	3105	3055	3055
query60	276	261	256	256
query61	110	109	114	109
query62	868	801	749	749
query63	240	193	193	193
query64	4651	1019	655	655
query65	3277	3210	3234	3210
query66	1054	437	342	342
query67	15912	15727	15644	15644
query68	7177	700	523	523
query69	446	340	254	254
query70	1234	1126	1167	1126
query71	399	283	267	267
query72	6094	3811	3908	3811
query73	648	809	354	354
query74	10039	9252	9100	9100
query75	4406	3172	2699	2699
query76	4141	1156	775	775
query77	825	361	283	283
query78	10226	10195	9479	9479
query79	3351	821	579	579
query80	682	517	436	436
query81	490	265	231	231
query82	683	152	121	121
query83	164	169	148	148
query84	234	90	71	71
query85	842	361	300	300
query86	401	318	307	307
query87	4477	4633	4306	4306
query88	5033	2230	2208	2208
query89	419	334	305	305
query90	1787	188	192	188
query91	137	150	105	105
query92	70	59	52	52
query93	1721	862	531	531
query94	659	398	282	282
query95	331	266	251	251
query96	487	619	278	278
query97	2875	3002	2871	2871
query98	230	201	203	201
query99	1649	1568	1410	1410
Total cold run time: 295849 ms
Total hot run time: 190635 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.17 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f9b474709a69284d1d9dba792a7f08101159344f, data reload: false

query1	0.05	0.04	0.03
query2	0.08	0.03	0.03
query3	0.24	0.07	0.07
query4	1.61	0.11	0.10
query5	0.42	0.43	0.42
query6	1.17	0.64	0.64
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.59	0.50	0.50
query10	0.56	0.57	0.55
query11	0.14	0.11	0.10
query12	0.14	0.11	0.11
query13	0.61	0.60	0.60
query14	2.84	2.77	2.75
query15	0.89	0.83	0.83
query16	0.38	0.38	0.37
query17	1.05	1.01	1.02
query18	0.23	0.21	0.22
query19	1.89	1.88	2.07
query20	0.01	0.01	0.01
query21	15.36	0.89	0.59
query22	0.75	0.80	0.59
query23	15.33	1.42	0.58
query24	2.85	0.91	1.65
query25	0.14	0.10	0.24
query26	0.21	0.14	0.13
query27	0.04	0.06	0.04
query28	14.21	1.55	1.05
query29	12.61	3.96	3.27
query30	0.25	0.08	0.06
query31	2.82	0.60	0.38
query32	3.23	0.55	0.45
query33	3.04	3.23	3.07
query34	16.83	5.09	4.47
query35	4.51	4.44	4.46
query36	0.68	0.50	0.48
query37	0.10	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.02	0.02
query40	0.16	0.14	0.12
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.33 s
Total hot run time: 31.17 s

@HappenLee
Copy link
Contributor Author

run buildall

yiguolei
yiguolei previously approved these changes Jan 13, 2025
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 13, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 33819 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 35907353e54068821fa1ef0eb7032238f765e1a9, data reload: false

------ Round 1 ----------------------------------
q1	17575	6517	6296	6296
q2	2054	320	178	178
q3	10426	1371	782	782
q4	10231	931	440	440
q5	7987	2384	2170	2170
q6	238	196	150	150
q7	989	770	599	599
q8	9246	1511	1283	1283
q9	5493	5185	5306	5185
q10	6808	2341	1839	1839
q11	512	290	270	270
q12	355	391	220	220
q13	17788	3826	3093	3093
q14	250	250	219	219
q15	599	501	504	501
q16	636	631	594	594
q17	589	907	343	343
q18	7152	6570	6531	6531
q19	4390	1082	582	582
q20	316	334	186	186
q21	3063	2257	2051	2051
q22	371	335	307	307
Total cold run time: 107068 ms
Total hot run time: 33819 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6948	6759	6728	6728
q2	251	356	231	231
q3	2364	2751	2354	2354
q4	1457	1886	1412	1412
q5	4495	5068	4993	4993
q6	216	195	150	150
q7	2227	1991	1772	1772
q8	2879	3082	2965	2965
q9	7465	7379	7233	7233
q10	3133	3443	2867	2867
q11	657	525	492	492
q12	694	790	646	646
q13	3683	3921	3182	3182
q14	308	299	270	270
q15	602	510	495	495
q16	655	695	641	641
q17	1338	1904	1284	1284
q18	7824	7505	7539	7505
q19	858	1171	1319	1171
q20	2052	2042	1898	1898
q21	5951	5298	5269	5269
q22	643	613	612	612
Total cold run time: 56700 ms
Total hot run time: 54170 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195509 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 35907353e54068821fa1ef0eb7032238f765e1a9, data reload: false

query1	1321	968	916	916
query2	6356	2393	2257	2257
query3	11130	4827	4929	4827
query4	32512	23371	23375	23371
query5	3551	623	447	447
query6	287	200	193	193
query7	4003	487	313	313
query8	288	234	220	220
query9	9382	2722	2727	2722
query10	434	310	249	249
query11	17422	15390	14939	14939
query12	155	107	101	101
query13	1537	500	388	388
query14	8973	6989	7027	6989
query15	264	214	183	183
query16	8247	668	457	457
query17	1566	783	608	608
query18	2176	429	318	318
query19	207	205	171	171
query20	120	123	116	116
query21	211	126	108	108
query22	4855	4500	4731	4500
query23	34398	34487	33653	33653
query24	6780	2268	2362	2268
query25	440	453	386	386
query26	891	267	156	156
query27	2294	457	340	340
query28	5246	2496	2500	2496
query29	525	563	476	476
query30	218	199	159	159
query31	951	867	823	823
query32	88	57	62	57
query33	480	362	302	302
query34	761	853	540	540
query35	822	832	740	740
query36	1027	1008	962	962
query37	124	105	78	78
query38	4312	4155	4126	4126
query39	1511	1444	1468	1444
query40	203	111	97	97
query41	54	52	50	50
query42	120	103	102	102
query43	524	486	477	477
query44	1332	841	855	841
query45	182	171	174	171
query46	874	1050	666	666
query47	1886	1954	1899	1899
query48	392	432	321	321
query49	717	497	409	409
query50	659	649	397	397
query51	6985	7040	7127	7040
query52	99	101	95	95
query53	229	250	186	186
query54	484	482	413	413
query55	85	78	78	78
query56	260	252	243	243
query57	1228	1226	1148	1148
query58	264	238	229	229
query59	3288	3263	3082	3082
query60	294	274	259	259
query61	155	121	127	121
query62	874	816	738	738
query63	225	194	187	187
query64	3593	1050	730	730
query65	3342	3272	3263	3263
query66	1088	420	313	313
query67	16500	15703	15467	15467
query68	9112	706	520	520
query69	492	298	256	256
query70	1151	1114	1132	1114
query71	431	283	256	256
query72	6459	3904	3883	3883
query73	664	751	357	357
query74	10189	8888	8747	8747
query75	4057	3139	2670	2670
query76	3608	1183	759	759
query77	759	363	286	286
query78	10124	10150	9321	9321
query79	3195	803	579	579
query80	595	531	441	441
query81	499	266	243	243
query82	688	144	120	120
query83	177	168	153	153
query84	251	92	83	83
query85	867	347	295	295
query86	396	321	300	300
query87	4432	4365	4247	4247
query88	4873	2194	2151	2151
query89	404	320	291	291
query90	1716	189	187	187
query91	133	137	108	108
query92	72	57	51	51
query93	1905	853	515	515
query94	642	409	294	294
query95	344	255	256	255
query96	489	605	285	285
query97	2886	2987	2766	2766
query98	222	200	205	200
query99	1419	1496	1355	1355
Total cold run time: 295052 ms
Total hot run time: 195509 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.7 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 35907353e54068821fa1ef0eb7032238f765e1a9, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.04
query3	0.24	0.07	0.06
query4	1.62	0.10	0.10
query5	0.41	0.42	0.44
query6	1.14	0.66	0.66
query7	0.03	0.02	0.01
query8	0.04	0.03	0.04
query9	0.58	0.51	0.53
query10	0.54	0.56	0.56
query11	0.13	0.10	0.10
query12	0.14	0.11	0.10
query13	0.61	0.61	0.59
query14	2.71	2.72	2.72
query15	0.89	0.83	0.83
query16	0.38	0.39	0.41
query17	0.97	1.05	1.07
query18	0.22	0.20	0.20
query19	1.89	1.89	2.02
query20	0.02	0.01	0.01
query21	15.36	0.93	0.57
query22	0.75	0.86	0.81
query23	15.14	1.55	0.60
query24	2.52	1.35	1.17
query25	0.16	0.11	0.07
query26	0.32	0.16	0.14
query27	0.04	0.05	0.04
query28	13.95	1.56	1.04
query29	12.60	3.88	3.24
query30	0.24	0.08	0.06
query31	2.84	0.60	0.38
query32	3.23	0.55	0.47
query33	3.04	3.08	3.05
query34	16.57	5.17	4.50
query35	4.59	4.49	4.50
query36	0.63	0.51	0.48
query37	0.10	0.06	0.05
query38	0.05	0.03	0.04
query39	0.03	0.02	0.03
query40	0.16	0.15	0.12
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.15 s
Total hot run time: 31.7 s

@HappenLee
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jan 13, 2025
@HappenLee
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 13, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 32515 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 794247a464b81c7958fa2b6b1faa11c076500e7c, data reload: false

------ Round 1 ----------------------------------
q1	17595	6252	6077	6077
q2	2051	304	175	175
q3	10421	1210	735	735
q4	10287	868	431	431
q5	8869	2189	1955	1955
q6	205	179	146	146
q7	895	776	601	601
q8	9243	1372	1165	1165
q9	5267	4897	4889	4889
q10	6765	2277	1876	1876
q11	497	267	263	263
q12	339	362	229	229
q13	17775	3719	3050	3050
q14	235	230	212	212
q15	580	507	504	504
q16	630	612	591	591
q17	563	848	328	328
q18	6901	6449	6283	6283
q19	2506	967	532	532
q20	301	313	193	193
q21	2942	2188	1967	1967
q22	374	333	313	313
Total cold run time: 105241 ms
Total hot run time: 32515 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6404	6245	6223	6223
q2	236	324	235	235
q3	2272	2646	2310	2310
q4	1417	1791	1382	1382
q5	4329	4740	4856	4740
q6	193	179	139	139
q7	2089	1978	1827	1827
q8	2637	2830	2680	2680
q9	7268	7187	7276	7187
q10	3072	3279	2736	2736
q11	573	515	497	497
q12	675	769	610	610
q13	3510	3876	3197	3197
q14	289	299	268	268
q15	560	507	521	507
q16	657	692	635	635
q17	1241	1727	1280	1280
q18	7701	7435	7282	7282
q19	790	1125	1106	1106
q20	2025	2072	1919	1919
q21	5686	5116	5020	5020
q22	643	587	605	587
Total cold run time: 54267 ms
Total hot run time: 52367 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 194148 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 794247a464b81c7958fa2b6b1faa11c076500e7c, data reload: false

query1	1311	971	922	922
query2	6426	2394	2275	2275
query3	11324	4738	4914	4738
query4	33462	23897	23089	23089
query5	3854	630	452	452
query6	288	203	189	189
query7	3979	482	310	310
query8	293	237	225	225
query9	9491	2666	2672	2666
query10	441	312	254	254
query11	17703	15160	15007	15007
query12	174	110	113	110
query13	1604	507	402	402
query14	10424	6736	7578	6736
query15	246	204	192	192
query16	8284	653	495	495
query17	1573	783	608	608
query18	2084	413	316	316
query19	222	180	158	158
query20	129	111	111	111
query21	205	130	104	104
query22	4675	4815	4362	4362
query23	34051	32962	33126	32962
query24	6236	2331	2295	2295
query25	460	450	415	415
query26	789	280	161	161
query27	2090	451	326	326
query28	5659	2453	2431	2431
query29	552	558	429	429
query30	214	191	155	155
query31	976	901	813	813
query32	72	61	60	60
query33	495	358	308	308
query34	769	848	522	522
query35	807	856	746	746
query36	1016	1039	972	972
query37	129	102	75	75
query38	4365	4295	4034	4034
query39	1520	1451	1498	1451
query40	224	114	101	101
query41	58	49	48	48
query42	131	107	103	103
query43	513	533	503	503
query44	1379	828	816	816
query45	185	174	168	168
query46	888	1050	640	640
query47	1911	1953	1814	1814
query48	406	427	324	324
query49	712	511	419	419
query50	658	660	408	408
query51	7269	7124	7140	7124
query52	102	102	102	102
query53	224	259	189	189
query54	483	495	426	426
query55	79	80	83	80
query56	258	288	258	258
query57	1239	1232	1147	1147
query58	246	248	235	235
query59	3160	3310	3073	3073
query60	276	277	283	277
query61	121	132	125	125
query62	855	798	753	753
query63	233	192	186	186
query64	2986	1047	642	642
query65	3390	3296	3265	3265
query66	836	422	303	303
query67	16295	15816	15486	15486
query68	7596	690	514	514
query69	482	293	252	252
query70	1120	1091	1126	1091
query71	443	290	262	262
query72	6315	3887	3822	3822
query73	641	750	357	357
query74	10128	9126	8771	8771
query75	4045	3149	2635	2635
query76	3610	1179	761	761
query77	755	374	374	374
query78	10034	10069	9280	9280
query79	3489	800	578	578
query80	665	535	441	441
query81	492	283	238	238
query82	640	152	120	120
query83	199	168	150	150
query84	278	92	129	92
query85	772	357	287	287
query86	361	299	277	277
query87	4381	4515	4419	4419
query88	4416	2138	2109	2109
query89	422	322	292	292
query90	1796	190	189	189
query91	137	131	108	108
query92	63	63	58	58
query93	1656	849	538	538
query94	644	406	287	287
query95	328	264	253	253
query96	478	612	275	275
query97	2874	2928	2820	2820
query98	232	210	203	203
query99	1607	1531	1404	1404
Total cold run time: 294608 ms
Total hot run time: 194148 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.62 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 794247a464b81c7958fa2b6b1faa11c076500e7c, data reload: false

query1	0.03	0.03	0.02
query2	0.07	0.03	0.03
query3	0.23	0.07	0.06
query4	1.63	0.11	0.11
query5	0.41	0.43	0.44
query6	1.14	0.65	0.65
query7	0.02	0.01	0.01
query8	0.04	0.04	0.04
query9	0.60	0.51	0.49
query10	0.54	0.56	0.55
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.60	0.61	0.60
query14	2.75	2.81	2.81
query15	0.88	0.82	0.83
query16	0.40	0.41	0.37
query17	1.05	1.01	1.03
query18	0.23	0.22	0.21
query19	1.99	1.87	1.94
query20	0.01	0.01	0.02
query21	15.36	0.95	0.59
query22	0.74	0.77	0.74
query23	15.21	1.46	0.54
query24	3.03	1.30	1.16
query25	0.17	0.29	0.10
query26	0.27	0.14	0.14
query27	0.05	0.04	0.05
query28	13.59	1.54	1.05
query29	12.57	3.86	3.24
query30	0.25	0.09	0.06
query31	2.83	0.57	0.39
query32	3.23	0.55	0.46
query33	3.09	3.00	3.09
query34	16.83	5.12	4.54
query35	4.51	4.51	4.50
query36	0.66	0.49	0.47
query37	0.09	0.06	0.05
query38	0.05	0.03	0.03
query39	0.04	0.02	0.02
query40	0.17	0.13	0.14
query41	0.07	0.02	0.03
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.77 s
Total hot run time: 31.62 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants