-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature](nereids) in predicate extract non constant expressions #46794
Merged
starocean999
merged 4 commits into
apache:master
from
yujun777:in-predicate-extract-column
Jan 13, 2025
Merged
[feature](nereids) in predicate extract non constant expressions #46794
starocean999
merged 4 commits into
apache:master
from
yujun777:in-predicate-extract-column
Jan 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
run buildall |
run performance |
TPC-H: Total hot run time: 32331 ms
|
TPC-DS: Total hot run time: 187843 ms
|
ClickBench: Total hot run time: 31.61 s
|
run buildall |
englefly
approved these changes
Jan 13, 2025
github-actions
bot
added
the
approved
Indicates a PR has been approved by one committer.
label
Jan 13, 2025
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 32356 ms
|
TPC-DS: Total hot run time: 195278 ms
|
ClickBench: Total hot run time: 31.44 s
|
run external |
starocean999
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
if an in predicate contains non-literal, backend process it will reduce performance. so we need to extract the non constant from the in predicate.
this pr add an expression rewrite rule InPredicateExtractNonConstant, it will extract all the non-constant out of the in predicate. for example:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)