Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](session var) add need forward for disable_inverted_index_v1_for_variant #46845

Merged
merged 1 commit into from
Jan 13, 2025
Merged

[fix](session var) add need forward for disable_inverted_index_v1_for_variant #46845

merged 1 commit into from
Jan 13, 2025

Conversation

airborne12
Copy link
Member

@airborne12 airborne12 commented Jan 12, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 12, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@airborne12
Copy link
Member Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32414 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bc974f9a4f27a40893e2d41530997ebbca868e34, data reload: false

------ Round 1 ----------------------------------
q1	17589	6589	5933	5933
q2	2047	289	167	167
q3	10962	1176	734	734
q4	10213	880	429	429
q5	7516	2104	1948	1948
q6	195	178	145	145
q7	885	737	593	593
q8	9237	1327	1161	1161
q9	5180	4914	4881	4881
q10	6791	2289	1840	1840
q11	502	271	257	257
q12	343	356	215	215
q13	17773	3661	2979	2979
q14	236	241	214	214
q15	545	493	505	493
q16	633	604	612	604
q17	562	832	327	327
q18	6855	6480	6445	6445
q19	1771	942	536	536
q20	305	319	197	197
q21	3010	2144	2011	2011
q22	381	334	305	305
Total cold run time: 103531 ms
Total hot run time: 32414 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6194	6206	6206	6206
q2	240	329	234	234
q3	2282	2625	2332	2332
q4	1400	1797	1333	1333
q5	4300	4684	4760	4684
q6	188	177	142	142
q7	2045	1958	1816	1816
q8	2587	2805	2672	2672
q9	7273	7170	7261	7170
q10	3041	3320	2700	2700
q11	571	517	487	487
q12	703	853	654	654
q13	3512	3799	3186	3186
q14	294	306	292	292
q15	557	508	504	504
q16	635	707	651	651
q17	1198	1728	1245	1245
q18	7686	7526	7280	7280
q19	769	1144	1028	1028
q20	1993	2018	1941	1941
q21	5750	5123	4982	4982
q22	636	607	588	588
Total cold run time: 53854 ms
Total hot run time: 52127 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 194186 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit bc974f9a4f27a40893e2d41530997ebbca868e34, data reload: false

query1	1302	977	919	919
query2	6258	2385	2291	2291
query3	10977	4459	4650	4459
query4	32993	23318	23162	23162
query5	3922	580	442	442
query6	292	197	185	185
query7	3980	482	304	304
query8	290	230	229	229
query9	9212	2714	2716	2714
query10	461	310	251	251
query11	17724	15240	14949	14949
query12	152	112	99	99
query13	1536	515	382	382
query14	9374	6888	7319	6888
query15	248	208	191	191
query16	8234	612	450	450
query17	1616	774	610	610
query18	2165	419	324	324
query19	215	187	162	162
query20	121	119	118	118
query21	241	123	107	107
query22	4930	4636	4646	4636
query23	34784	33248	33196	33196
query24	6929	2380	2362	2362
query25	484	448	402	402
query26	1171	270	153	153
query27	2436	468	334	334
query28	5462	2478	2470	2470
query29	698	558	426	426
query30	215	184	148	148
query31	961	896	814	814
query32	81	62	53	53
query33	491	386	297	297
query34	744	865	525	525
query35	826	809	758	758
query36	1001	1061	957	957
query37	123	107	76	76
query38	4119	4366	4201	4201
query39	1514	1428	1432	1428
query40	204	111	98	98
query41	56	50	49	49
query42	116	101	101	101
query43	515	544	495	495
query44	1369	835	830	830
query45	183	185	168	168
query46	855	1051	668	668
query47	1905	1907	1829	1829
query48	402	408	331	331
query49	751	489	390	390
query50	660	665	436	436
query51	7057	7103	7026	7026
query52	106	101	90	90
query53	217	254	180	180
query54	485	488	429	429
query55	88	83	82	82
query56	278	311	268	268
query57	1202	1202	1157	1157
query58	260	246	265	246
query59	3293	3405	3010	3010
query60	268	258	237	237
query61	111	112	133	112
query62	855	824	733	733
query63	232	196	197	196
query64	4242	1010	663	663
query65	3245	3191	3226	3191
query66	955	399	294	294
query67	16237	15830	15417	15417
query68	8914	696	517	517
query69	462	281	246	246
query70	1210	1146	1134	1134
query71	438	280	248	248
query72	6405	3753	3760	3753
query73	664	746	356	356
query74	10374	8753	8921	8753
query75	4053	3122	2646	2646
query76	3628	1127	755	755
query77	761	371	269	269
query78	9980	10026	9324	9324
query79	2990	806	614	614
query80	612	645	448	448
query81	499	270	236	236
query82	658	149	122	122
query83	180	165	148	148
query84	246	89	69	69
query85	767	340	298	298
query86	402	314	295	295
query87	4478	4298	4315	4298
query88	4514	2180	2152	2152
query89	408	318	293	293
query90	1848	184	184	184
query91	133	143	107	107
query92	68	55	51	51
query93	1823	865	522	522
query94	624	388	271	271
query95	335	252	242	242
query96	472	603	277	277
query97	2871	2948	2803	2803
query98	219	197	187	187
query99	1589	1484	1370	1370
Total cold run time: 297054 ms
Total hot run time: 194186 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.31 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bc974f9a4f27a40893e2d41530997ebbca868e34, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.03	0.04
query3	0.24	0.07	0.08
query4	1.62	0.10	0.10
query5	0.44	0.41	0.44
query6	1.17	0.66	0.64
query7	0.03	0.02	0.02
query8	0.04	0.03	0.03
query9	0.58	0.51	0.52
query10	0.57	0.55	0.56
query11	0.14	0.10	0.11
query12	0.14	0.11	0.11
query13	0.60	0.58	0.60
query14	2.71	2.83	2.75
query15	0.89	0.82	0.82
query16	0.40	0.39	0.36
query17	1.00	1.06	1.07
query18	0.21	0.21	0.21
query19	1.95	1.84	2.00
query20	0.01	0.00	0.02
query21	15.36	0.93	0.57
query22	0.75	0.74	0.70
query23	15.33	1.39	0.50
query24	3.25	1.36	1.08
query25	0.18	0.26	0.11
query26	0.18	0.14	0.14
query27	0.05	0.06	0.04
query28	14.46	1.48	1.04
query29	12.56	3.94	3.27
query30	0.25	0.10	0.07
query31	2.81	0.60	0.37
query32	3.25	0.56	0.46
query33	3.05	3.06	3.09
query34	16.62	5.13	4.46
query35	4.50	4.43	4.42
query36	0.76	0.47	0.48
query37	0.10	0.06	0.06
query38	0.04	0.04	0.04
query39	0.03	0.02	0.03
query40	0.16	0.13	0.12
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.7 s
Total hot run time: 31.31 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 12, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

csun5285
csun5285 approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@csun5285 csun5285 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shuke987
shuke987 approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@shuke987 shuke987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@airborne12 airborne12 merged commit 617c5e4 into apache:master Jan 13, 2025
34 of 35 checks passed
@airborne12 airborne12 deleted the fix1 branch January 13, 2025 03:40
github-actions bot pushed a commit that referenced this pull request Jan 13, 2025
@airborne12
[fix](session var) add need forward for disable_inverted_index_v1_for…
5011401 
…_variant (#46845)

Problem Summary:
disable_inverted_index_v1_for_variant session var need to forward to master.
@github-actions github-actions bot mentioned this pull request Jan 13, 2025
Open
github-actions bot pushed a commit that referenced this pull request Jan 13, 2025
@airborne12
[fix](session var) add need forward for disable_inverted_index_v1_for…
981edba 
…_variant (#46845)

Problem Summary:
disable_inverted_index_v1_for_variant session var need to forward to master.
@github-actions github-actions bot mentioned this pull request Jan 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csun5285 csun5285 csun5285 approved these changes

@shuke987 shuke987 shuke987 approved these changes

@morningman morningman morningman approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.x dev/3.0.x reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@airborne12 @Thearas @doris-robot @morningman @shuke987 @csun5285 @dataroaring