-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](job)Fix for Duplicate Scheduling of Tasks #46872
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
### Problem Description The current scheduling logic calculates the next scheduled time and adds it to the task queue when the condition triggerTime <= windowEndTimeMs is met. However, this can lead to a task being scheduled twice if its triggerTime is exactly equal to windowEndTimeMs: - The task is added to the current scheduling window. - At the same time, this timestamp becomes the startTime for the next scheduling window, causing the task to be scheduled again. ### Changes Made Updated the condition from triggerTime <= windowEndTimeMs to triggerTime < windowEndTimeMs. This ensures that the scheduling time doesn’t overlap with the window’s end time, preventing duplicate scheduling.
CalvinKirs
force-pushed
the
master-job-time-windewos
branch
from
January 13, 2025 03:56
78c61cc
to
df717fd
Compare
run buildall |
TPC-H: Total hot run time: 32607 ms
|
TPC-DS: Total hot run time: 188113 ms
|
ClickBench: Total hot run time: 31.62 s
|
run p0 |
zy-kkk
approved these changes
Jan 13, 2025
JNSimba
approved these changes
Jan 13, 2025
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Indicates a PR has been approved by one committer.
reviewed
labels
Jan 13, 2025
PR approved by anyone and no changes requested. |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
### Problem Description The current scheduling logic calculates the next scheduled time and adds it to the task queue when the condition triggerTime <= windowEndTimeMs is met. However, this can lead to a task being scheduled twice if its triggerTime is exactly equal to windowEndTimeMs: - The task is added to the current scheduling window. - At the same time, this timestamp becomes the startTime for the next scheduling window, causing the task to be scheduled again. ### Changes Made Updated the condition from triggerTime <= windowEndTimeMs to triggerTime < windowEndTimeMs. This ensures that the scheduling time doesn’t overlap with the window’s end time, preventing duplicate scheduling.
github-actions bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
### Problem Description The current scheduling logic calculates the next scheduled time and adds it to the task queue when the condition triggerTime <= windowEndTimeMs is met. However, this can lead to a task being scheduled twice if its triggerTime is exactly equal to windowEndTimeMs: - The task is added to the current scheduling window. - At the same time, this timestamp becomes the startTime for the next scheduling window, causing the task to be scheduled again. ### Changes Made Updated the condition from triggerTime <= windowEndTimeMs to triggerTime < windowEndTimeMs. This ensures that the scheduling time doesn’t overlap with the window’s end time, preventing duplicate scheduling.
CalvinKirs
added a commit
that referenced
this pull request
Jan 13, 2025
…46898) Cherry-picked from #46872 Co-authored-by: Calvin Kirs <[email protected]>
morningman
pushed a commit
that referenced
this pull request
Jan 17, 2025
### Problem Description The current scheduling logic calculates the next scheduled time and adds it to the task queue when the condition triggerTime <= windowEndTimeMs is met. However, this can lead to a task being scheduled twice if its triggerTime is exactly equal to windowEndTimeMs: - The task is added to the current scheduling window. - At the same time, this timestamp becomes the startTime for the next scheduling window, causing the task to be scheduled again. ### Changes Made Updated the condition from triggerTime <= windowEndTimeMs to triggerTime < windowEndTimeMs. This ensures that the scheduling time doesn’t overlap with the window’s end time, preventing duplicate scheduling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
The current scheduling logic calculates the next scheduled time and adds it to the task queue when the condition triggerTime <= windowEndTimeMs is met. However, this can lead to a task being scheduled twice if its triggerTime is exactly equal to windowEndTimeMs:
Changes Made
Updated the condition from triggerTime <= windowEndTimeMs to triggerTime < windowEndTimeMs. This ensures that the scheduling time doesn’t overlap with the window’s end time, preventing duplicate scheduling.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)