Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](third-party) Fix the build of protobuf #46978

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

adonis0147
Copy link
Contributor

@adonis0147 adonis0147 commented Jan 14, 2025

What problem does this PR solve?

Backport #31173

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 14, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@adonis0147
Copy link
Contributor Author

adonis0147 commented Jan 14, 2025

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.55% (8310/21555)
Line Coverage: 30.25% (68734/227216)
Region Coverage: 29.67% (35392/119278)
Branch Coverage: 25.43% (18192/71530)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d47945b9a9ea779f2c750fa29587e2e09dff1c67_d47945b9a9ea779f2c750fa29587e2e09dff1c67/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 48549 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d47945b9a9ea779f2c750fa29587e2e09dff1c67, data reload: false

------ Round 1 ----------------------------------
q1	17658	4391	4319	4319
q2	2076	152	144	144
q3	10274	1863	1932	1863
q4	10330	1237	1332	1237
q5	9130	3845	3889	3845
q6	240	124	122	122
q7	2043	1634	1588	1588
q8	9344	2733	2686	2686
q9	10096	9864	9682	9682
q10	8634	3536	3477	3477
q11	429	248	248	248
q12	475	286	296	286
q13	18356	3982	4014	3982
q14	353	313	324	313
q15	511	467	461	461
q16	555	473	453	453
q17	1123	939	870	870
q18	7158	6782	6877	6782
q19	1654	1573	1488	1488
q20	497	292	293	292
q21	4405	4155	4029	4029
q22	491	383	382	382
Total cold run time: 115832 ms
Total hot run time: 48549 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4308	4322	4303	4303
q2	321	224	223	223
q3	4156	4110	4133	4110
q4	2764	2756	2759	2756
q5	7188	7169	7163	7163
q6	241	120	117	117
q7	3236	2844	2902	2844
q8	4400	4469	4490	4469
q9	13695	13547	13625	13547
q10	4214	4281	4253	4253
q11	758	677	691	677
q12	1047	865	881	865
q13	6613	3743	3721	3721
q14	454	436	424	424
q15	501	448	445	445
q16	644	595	585	585
q17	3852	3844	3861	3844
q18	8722	8681	8801	8681
q19	1718	1621	1647	1621
q20	2365	2119	2111	2111
q21	8502	8511	8511	8511
q22	1023	960	915	915
Total cold run time: 80722 ms
Total hot run time: 76185 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 211681 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d47945b9a9ea779f2c750fa29587e2e09dff1c67, data reload: false

query1	928	428	380	380
query2	6554	2206	2104	2104
query3	6922	199	198	198
query4	23029	21718	21447	21447
query5	19734	6509	6512	6509
query6	283	226	234	226
query7	4332	302	313	302
query8	238	273	236	236
query9	3071	2626	2565	2565
query10	471	324	319	319
query11	15692	15088	14851	14851
query12	132	78	73	73
query13	1056	451	430	430
query14	17049	13274	13593	13274
query15	375	229	225	225
query16	6045	274	272	272
query17	1724	931	901	901
query18	900	335	334	334
query19	234	150	145	145
query20	104	99	99	99
query21	194	95	97	95
query22	5329	5063	4927	4927
query23	34004	33477	33476	33476
query24	7851	6323	6288	6288
query25	532	430	428	428
query26	1313	164	156	156
query27	2407	298	295	295
query28	6099	2296	2261	2261
query29	2928	2745	2822	2745
query30	244	173	166	166
query31	956	740	752	740
query32	70	59	58	58
query33	459	250	262	250
query34	864	487	469	469
query35	1122	913	937	913
query36	1355	1283	1231	1231
query37	175	58	61	58
query38	3023	2918	2946	2918
query39	1359	1339	1339	1339
query40	306	95	97	95
query41	49	38	38	38
query42	97	86	82	82
query43	622	535	591	535
query44	1156	712	714	712
query45	245	236	227	227
query46	1229	962	970	962
query47	1783	1696	1781	1696
query48	505	419	413	413
query49	653	370	379	370
query50	860	609	595	595
query51	4763	4661	4714	4661
query52	82	92	80	80
query53	225	188	185	185
query54	2629	2429	2471	2429
query55	88	83	85	83
query56	230	208	209	208
query57	1280	1190	1145	1145
query58	216	213	202	202
query59	3614	3273	3328	3273
query60	238	217	211	211
query61	100	94	98	94
query62	781	480	552	480
query63	204	172	174	172
query64	5864	1565	1344	1344
query65	3614	3568	3569	3568
query66	639	436	387	387
query67	15806	17089	15115	15115
query68	9559	644	630	630
query69	498	282	262	262
query70	1530	1379	1367	1367
query71	409	303	312	303
query72	6784	4796	4728	4728
query73	745	313	323	313
query74	6401	5859	5843	5843
query75	4887	3611	3733	3611
query76	5170	1116	1200	1116
query77	873	254	256	254
query78	12701	11763	11556	11556
query79	8609	648	653	648
query80	1698	398	387	387
query81	485	238	237	237
query82	1537	100	95	95
query83	168	133	134	133
query84	257	71	71	71
query85	903	317	316	316
query86	348	338	306	306
query87	3214	3040	3013	3013
query88	4648	2273	2294	2273
query89	470	267	279	267
query90	1970	212	209	209
query91	161	127	134	127
query92	56	53	49	49
query93	6365	554	586	554
query94	727	212	210	210
query95	1944	1931	1956	1931
query96	639	329	323	323
query97	6407	6432	6490	6432
query98	242	219	205	205
query99	2837	969	847	847
Total cold run time: 320277 ms
Total hot run time: 211681 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.58 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d47945b9a9ea779f2c750fa29587e2e09dff1c67, data reload: false

query1	0.03	0.03	0.02
query2	0.08	0.02	0.03
query3	0.25	0.04	0.04
query4	1.81	0.06	0.06
query5	0.53	0.52	0.52
query6	1.26	0.61	0.60
query7	0.01	0.01	0.01
query8	0.04	0.02	0.02
query9	0.53	0.48	0.49
query10	0.55	0.53	0.54
query11	0.12	0.09	0.09
query12	0.13	0.09	0.09
query13	0.63	0.60	0.61
query14	0.77	0.78	0.78
query15	0.78	0.76	0.76
query16	0.39	0.39	0.37
query17	1.00	1.02	1.03
query18	0.23	0.23	0.24
query19	1.85	1.84	1.80
query20	0.02	0.01	0.01
query21	15.49	0.56	0.56
query22	2.10	2.23	1.70
query23	17.28	0.90	1.14
query24	6.79	1.41	0.97
query25	0.37	0.10	0.04
query26	0.70	0.15	0.14
query27	0.04	0.05	0.04
query28	6.02	0.77	0.76
query29	12.60	2.16	2.34
query30	0.62	0.53	0.50
query31	2.81	0.39	0.38
query32	3.36	0.50	0.49
query33	3.08	3.03	3.06
query34	15.23	4.78	4.82
query35	4.85	4.84	4.84
query36	1.05	1.03	1.00
query37	0.06	0.04	0.05
query38	0.03	0.02	0.02
query39	0.02	0.01	0.02
query40	0.17	0.13	0.14
query41	0.07	0.02	0.01
query42	0.02	0.02	0.01
query43	0.02	0.02	0.02
Total cold run time: 103.79 s
Total hot run time: 30.58 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit d47945b9a9ea779f2c750fa29587e2e09dff1c67 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       22.0 seconds inserted 10000000 Rows, about 454K ops/s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 14, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@adonis0147 adonis0147 merged commit 5c6a56b into apache:branch-2.0 Jan 14, 2025
26 of 29 checks passed
@adonis0147 adonis0147 deleted the branch-2.0 branch January 14, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants