Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch-3.0: [Bug](function) fix wrong result when case when have more than 256 conditions and the… #47179 #47391

Merged
merged 1 commit into from
Jan 26, 2025
Merged

branch-3.0: [Bug](function) fix wrong result when case when have more than 256 conditions and the… #47179 #47391

merged 1 commit into from
Jan 26, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #47179

@BiteTheDDDDt
[Bug](function) fix wrong result when case when have more than 256 co…
7af5ddd 
…nditions and the… (#47179)

### What problem does this PR solve?
fix wrong result when case when have more than 256 conditions and then
column is not nullable
### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [x] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot requested a review from dataroaring as a code owner January 24, 2025 03:40
@Thearas
Copy link
Contributor

Thearas commented Jan 24, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jan 24, 2025
@Thearas
Copy link
Contributor

Thearas commented Jan 24, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41381 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7af5dddc94d24ea89a0be47865ff469de1acf2ff, data reload: false

------ Round 1 ----------------------------------
q1	17719	7857	7222	7222
q2	2073	170	153	153
q3	10656	1141	1215	1141
q4	10478	766	737	737
q5	8015	2961	2883	2883
q6	240	149	154	149
q7	1005	633	628	628
q8	9525	2016	2074	2016
q9	6820	6526	6516	6516
q10	8121	2346	2355	2346
q11	468	272	266	266
q12	410	227	211	211
q13	17799	3024	3014	3014
q14	242	205	212	205
q15	580	531	503	503
q16	694	616	610	610
q17	1004	530	602	530
q18	7399	6749	6697	6697
q19	1397	1047	1038	1038
q20	475	206	197	197
q21	4131	3344	3334	3334
q22	1098	985	1020	985
Total cold run time: 110349 ms
Total hot run time: 41381 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7254	7206	7213	7206
q2	326	237	250	237
q3	3199	3039	3064	3039
q4	2077	1814	1836	1814
q5	5844	5879	5876	5876
q6	221	140	144	140
q7	2260	1882	1865	1865
q8	3436	3563	3543	3543
q9	8989	8992	8988	8988
q10	3643	3597	3585	3585
q11	595	502	521	502
q12	800	591	603	591
q13	5320	3182	3198	3182
q14	301	290	272	272
q15	585	523	538	523
q16	713	687	686	686
q17	1839	1646	1630	1630
q18	8296	7978	7470	7470
q19	1657	1562	1560	1560
q20	2046	1821	1828	1821
q21	5314	5285	5304	5285
q22	1107	1036	1019	1019
Total cold run time: 65822 ms
Total hot run time: 60834 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193488 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7af5dddc94d24ea89a0be47865ff469de1acf2ff, data reload: false

query1	978	375	364	364
query2	6527	2210	2086	2086
query3	6705	217	218	217
query4	34106	23698	23587	23587
query5	4340	476	463	463
query6	280	184	188	184
query7	4626	318	334	318
query8	290	226	227	226
query9	9588	2715	2696	2696
query10	455	295	253	253
query11	18140	15367	15261	15261
query12	149	103	104	103
query13	1627	429	418	418
query14	9821	7769	7103	7103
query15	310	173	183	173
query16	8197	453	468	453
query17	1737	575	538	538
query18	2142	325	312	312
query19	384	163	154	154
query20	118	110	112	110
query21	213	110	116	110
query22	4602	4356	4440	4356
query23	35075	34023	34187	34023
query24	11214	2867	2878	2867
query25	662	410	399	399
query26	1460	169	176	169
query27	2814	338	344	338
query28	7917	2479	2516	2479
query29	944	440	433	433
query30	326	169	167	167
query31	1044	761	799	761
query32	101	64	63	63
query33	789	310	296	296
query34	931	505	516	505
query35	909	744	728	728
query36	1103	963	949	949
query37	131	80	75	75
query38	4097	3960	4046	3960
query39	1494	1439	1431	1431
query40	284	100	99	99
query41	53	47	51	47
query42	114	99	102	99
query43	561	509	510	509
query44	1278	797	798	797
query45	186	166	169	166
query46	1151	697	699	697
query47	1961	1808	1878	1808
query48	489	381	384	381
query49	1186	410	399	399
query50	828	416	415	415
query51	7195	7121	7146	7121
query52	102	93	93	93
query53	257	186	189	186
query54	1314	470	460	460
query55	84	79	80	79
query56	282	265	267	265
query57	1262	1145	1118	1118
query58	252	221	230	221
query59	3195	3279	3078	3078
query60	305	271	271	271
query61	163	143	149	143
query62	895	689	684	684
query63	233	191	191	191
query64	5347	756	769	756
query65	3319	3236	3289	3236
query66	1471	330	341	330
query67	16049	15503	15621	15503
query68	4552	590	588	588
query69	451	288	277	277
query70	1211	1150	1163	1150
query71	346	262	268	262
query72	6552	4215	4156	4156
query73	762	341	366	341
query74	10142	9068	9121	9068
query75	3418	2658	2713	2658
query76	2962	1013	1041	1013
query77	429	288	288	288
query78	10709	9624	9700	9624
query79	1570	612	603	603
query80	1159	448	430	430
query81	556	244	248	244
query82	955	130	119	119
query83	218	149	145	145
query84	243	80	80	80
query85	1346	318	307	307
query86	435	313	302	302
query87	4537	4379	4380	4379
query88	3766	2415	2383	2383
query89	414	297	297	297
query90	1996	187	188	187
query91	191	150	147	147
query92	62	51	52	51
query93	1544	572	552	552
query94	913	288	271	271
query95	366	261	263	261
query96	618	285	279	279
query97	3326	3248	3254	3248
query98	214	201	204	201
query99	1566	1318	1297	1297
Total cold run time: 303691 ms
Total hot run time: 193488 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.92 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7af5dddc94d24ea89a0be47865ff469de1acf2ff, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.04
query3	0.24	0.06	0.06
query4	1.62	0.10	0.10
query5	0.53	0.52	0.53
query6	1.13	0.72	0.74
query7	0.02	0.01	0.01
query8	0.03	0.03	0.03
query9	0.57	0.50	0.50
query10	0.57	0.56	0.57
query11	0.15	0.11	0.11
query12	0.16	0.11	0.12
query13	0.62	0.60	0.59
query14	3.03	3.00	2.96
query15	0.91	0.83	0.82
query16	0.38	0.37	0.38
query17	0.99	1.07	1.00
query18	0.24	0.22	0.22
query19	1.95	1.94	1.90
query20	0.01	0.01	0.02
query21	15.35	0.60	0.59
query22	2.76	2.80	2.17
query23	16.86	0.90	0.80
query24	3.70	1.37	1.35
query25	0.19	0.18	0.07
query26	0.48	0.14	0.14
query27	0.05	0.04	0.04
query28	9.63	1.12	1.09
query29	12.53	3.29	3.32
query30	0.25	0.06	0.06
query31	2.85	0.38	0.38
query32	3.26	0.48	0.47
query33	3.05	3.00	3.06
query34	16.81	4.60	4.52
query35	4.58	4.60	4.51
query36	0.68	0.49	0.50
query37	0.09	0.06	0.07
query38	0.04	0.03	0.04
query39	0.04	0.02	0.02
query40	0.16	0.12	0.12
query41	0.09	0.02	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.79 s
Total hot run time: 33.92 s

@dataroaring dataroaring merged commit e4eaf13 into branch-3.0 Jan 26, 2025
21 of 22 checks passed
@github-actions github-actions bot deleted the auto-pick-47179-branch-3.0 branch January 26, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring Awaiting requested review from dataroaring dataroaring is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Thearas @doris-robot @dataroaring @BiteTheDDDDt