Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [fix](Nereids) Use the schema saved during planning as the schema of the original target table #47337 #47402

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #47337

@github-actions github-actions bot requested a review from dataroaring as a code owner January 24, 2025 06:57
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jan 24, 2025
@hello-stephen
Copy link
Contributor

run buildall

@morrySnow morrySnow force-pushed the auto-pick-47337-branch-3.0 branch from bbeece8 to 0c9de65 Compare January 24, 2025 09:42
…the original target table (#47337)

Related PR: #47033 #45045

Problem Summary:

because schema change does not involve recreating the table object, but
rather rebuilding the full schema. So, we should use the schema saved
during planning as the schema of the original target table.
@morrySnow morrySnow force-pushed the auto-pick-47337-branch-3.0 branch from 0c9de65 to baa63dc Compare January 24, 2025 09:42
@morrySnow
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41243 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit baa63dc577609b61b58ee9297c89143393c81e5e, data reload: false

------ Round 1 ----------------------------------
q1	17591	7424	7287	7287
q2	2063	166	158	158
q3	10858	1177	1205	1177
q4	10275	749	724	724
q5	8095	2974	2890	2890
q6	240	156	147	147
q7	996	631	610	610
q8	9888	2024	2036	2024
q9	6812	6524	6554	6524
q10	7531	2338	2322	2322
q11	457	270	263	263
q12	400	211	209	209
q13	17768	3033	3006	3006
q14	253	213	213	213
q15	592	548	540	540
q16	655	579	585	579
q17	984	569	594	569
q18	7348	6626	6689	6626
q19	1262	1132	1009	1009
q20	482	199	194	194
q21	4244	3188	3183	3183
q22	1117	989	1005	989
Total cold run time: 109911 ms
Total hot run time: 41243 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7256	7197	7224	7197
q2	327	239	230	230
q3	3177	3023	3121	3023
q4	2132	1793	1888	1793
q5	5719	5736	5671	5671
q6	218	137	138	137
q7	2193	1821	1822	1821
q8	3358	3537	3488	3488
q9	8802	8917	8850	8850
q10	3617	3554	3541	3541
q11	581	496	492	492
q12	778	612	597	597
q13	3842	3116	3184	3116
q14	307	280	281	280
q15	579	528	524	524
q16	687	637	647	637
q17	1830	1607	1575	1575
q18	8204	7689	7234	7234
q19	1661	1553	1464	1464
q20	2063	1808	1827	1808
q21	5262	5158	5252	5158
q22	1108	1011	981	981
Total cold run time: 63701 ms
Total hot run time: 59617 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192605 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit baa63dc577609b61b58ee9297c89143393c81e5e, data reload: false

query1	989	382	364	364
query2	6511	2212	2139	2139
query3	6702	220	219	219
query4	34068	23580	23717	23580
query5	4399	470	470	470
query6	268	186	179	179
query7	4630	305	317	305
query8	281	221	223	221
query9	9724	2694	2692	2692
query10	501	268	278	268
query11	18189	15186	15225	15186
query12	156	103	104	103
query13	1648	436	433	433
query14	9711	7046	7121	7046
query15	251	177	175	175
query16	8101	469	499	469
query17	1634	591	572	572
query18	2131	302	311	302
query19	237	159	155	155
query20	117	108	111	108
query21	209	107	105	105
query22	4594	4330	4363	4330
query23	34715	33991	33861	33861
query24	11863	2896	2918	2896
query25	736	435	412	412
query26	1888	174	175	174
query27	2939	349	340	340
query28	8054	2411	2409	2409
query29	1109	476	455	455
query30	342	175	162	162
query31	1019	797	797	797
query32	99	58	60	58
query33	808	318	306	306
query34	919	504	543	504
query35	850	741	744	741
query36	1142	929	948	929
query37	290	77	79	77
query38	3949	3854	3945	3854
query39	1467	1431	1442	1431
query40	293	105	104	104
query41	56	53	52	52
query42	117	108	105	105
query43	572	517	516	516
query44	1289	802	804	802
query45	191	173	172	172
query46	1158	733	730	730
query47	1931	1843	1818	1818
query48	474	384	391	384
query49	1316	416	417	416
query50	829	418	418	418
query51	7283	7227	7094	7094
query52	108	100	96	96
query53	276	189	198	189
query54	1126	480	471	471
query55	86	82	81	81
query56	296	265	274	265
query57	1234	1118	1103	1103
query58	249	216	218	216
query59	3447	3090	3095	3090
query60	291	250	247	247
query61	146	110	118	110
query62	879	692	650	650
query63	221	201	196	196
query64	5151	677	653	653
query65	3270	3180	3254	3180
query66	1422	342	323	323
query67	16065	15673	15676	15673
query68	4657	587	564	564
query69	437	267	310	267
query70	1186	1113	1169	1113
query71	404	271	258	258
query72	6332	4090	3980	3980
query73	783	351	351	351
query74	10222	9114	9086	9086
query75	3393	2634	2680	2634
query76	2978	1098	1021	1021
query77	415	295	276	276
query78	10446	9589	9536	9536
query79	1336	616	604	604
query80	962	455	436	436
query81	549	235	238	235
query82	1089	123	116	116
query83	222	150	145	145
query84	234	83	88	83
query85	1290	307	305	305
query86	356	302	266	266
query87	4503	4345	4273	4273
query88	3546	2397	2351	2351
query89	401	297	298	297
query90	1943	190	191	190
query91	189	148	160	148
query92	64	52	51	51
query93	1096	551	539	539
query94	892	308	310	308
query95	369	260	261	260
query96	611	288	284	284
query97	3341	3178	3226	3178
query98	209	207	195	195
query99	1524	1349	1274	1274
Total cold run time: 302995 ms
Total hot run time: 192605 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.13 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit baa63dc577609b61b58ee9297c89143393c81e5e, data reload: false

query1	0.04	0.03	0.02
query2	0.06	0.03	0.03
query3	0.24	0.07	0.06
query4	1.63	0.10	0.10
query5	0.53	0.50	0.53
query6	1.13	0.73	0.72
query7	0.03	0.02	0.01
query8	0.04	0.03	0.05
query9	0.57	0.50	0.49
query10	0.55	0.56	0.55
query11	0.14	0.10	0.10
query12	0.15	0.10	0.10
query13	0.60	0.61	0.60
query14	2.72	2.85	2.88
query15	0.90	0.83	0.82
query16	0.39	0.37	0.39
query17	1.06	1.05	0.97
query18	0.24	0.22	0.23
query19	1.98	2.07	1.77
query20	0.02	0.01	0.00
query21	15.37	0.58	0.57
query22	2.99	2.39	1.30
query23	16.97	1.19	0.75
query24	2.95	1.64	0.87
query25	0.26	0.10	0.03
query26	0.50	0.15	0.15
query27	0.04	0.05	0.04
query28	10.17	1.12	1.09
query29	12.59	3.28	3.28
query30	0.24	0.06	0.06
query31	2.86	0.39	0.40
query32	3.25	0.46	0.45
query33	3.00	3.06	3.00
query34	16.83	4.49	4.55
query35	4.58	4.56	4.55
query36	0.65	0.49	0.49
query37	0.10	0.06	0.06
query38	0.05	0.03	0.04
query39	0.03	0.02	0.03
query40	0.15	0.13	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.75 s
Total hot run time: 32.13 s

@dataroaring dataroaring merged commit 0f897ed into branch-3.0 Jan 26, 2025
25 of 27 checks passed
@github-actions github-actions bot deleted the auto-pick-47337-branch-3.0 branch January 26, 2025 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants