Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch-2.1: [BugFix](Variant) limit cast elimination to one level cast #47778 #47955

Merged
merged 1 commit into from
Feb 19, 2025
Merged

branch-2.1: [BugFix](Variant) limit cast elimination to one level cast #47778 #47955

merged 1 commit into from
Feb 19, 2025
+8 −3

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #47778

@eldenmoon
[BugFix](Variant) limit cast elimination to one level cast (#47778)
ae95cec 
The expression like `cast(cast(v['a'] as bigint) as double) in (1.1,
1.2)` which contains 2 levels cast expr should not push down.Otherwise
leading to incorrect result or crash
@Thearas
Copy link
Contributor

Thearas commented Feb 17, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Feb 17, 2025
@Thearas
Copy link
Contributor

Thearas commented Feb 17, 2025

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.49% (9607/26327)
Line Coverage: 28.09% (79655/283613)
Region Coverage: 26.74% (40856/152779)
Branch Coverage: 23.49% (20705/88130)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ae95cec9b3bb225d04f752de5ee1a30ac3a58cf5_ae95cec9b3bb225d04f752de5ee1a30ac3a58cf5/report/index.html

@yiguolei yiguolei merged commit 7f3681b into branch-2.1 Feb 19, 2025
18 of 19 checks passed
@github-actions github-actions bot deleted the auto-pick-47778-branch-2.1 branch February 19, 2025 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Thearas @doris-robot @yiguolei @dataroaring @eldenmoon