Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [fix] fix cast literal to date like throw exception #48773

Open
wants to merge 4 commits into
base: branch-3.0
Choose a base branch
from

Conversation

yujun777
Copy link
Collaborator

@yujun777 yujun777 commented Mar 6, 2025

What problem does this PR solve?

when nereids cast invalid date literal to date like type, it will throws exceptions:

select '' = cast('2020-10-20' as date);
(1105, 'errCode = 2, detailMessage = date/datetime literal [] is invalid')

But old planner will not throw exceptions, so let neredis don't throw exceptions too.

This PR is pick code from: #40202

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@yujun777 yujun777 requested a review from dataroaring as a code owner March 6, 2025 11:00
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yujun777
Copy link
Collaborator Author

yujun777 commented Mar 6, 2025

run buildall

@yujun777
Copy link
Collaborator Author

yujun777 commented Mar 6, 2025

run buildall

@morrySnow morrySnow added usercase Important user case type label dev/3.0.x labels Mar 7, 2025
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 7, 2025
Copy link
Contributor

github-actions bot commented Mar 7, 2025

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Mar 7, 2025

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.x reviewed usercase Important user case type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants