Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhance](regression) Add check_runtime_filter_partition_prune_counter to support testing runtime filter partition pruning #48777

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[enhance](regression) Add check_runtime_filter_partition_prune_counter to support testing runtime filter partition pruning #48777

wants to merge 3 commits into from
+49 −4

Conversation

suxiaogang223
Copy link
Contributor

What problem does this PR solve?

Related PR: #47025

Release note

Add check_runtime_filter_partition_prune_counter to support testing runtime filter partition pruning

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@suxiaogang223
Add a new session variable `check_runtime_filter_partition_prune_coun…
f5d0c04 
…ter` to support testing runtime filter partition pruning
@Thearas
Copy link
Contributor

Thearas commented Mar 6, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@suxiaogang223
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity cloud ut coverage result:
Function Coverage: 82.15% (1063/1294)
Line Coverage: 65.69% (17632/26840)
Region Coverage: 65.13% (8689/13340)
Branch Coverage: 55.12% (4691/8510)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3aa317c9ff1cb021c9676acc796a2f3f5886e59e_3aa317c9ff1cb021c9676acc796a2f3f5886e59e_cloud/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 32844 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3aa317c9ff1cb021c9676acc796a2f3f5886e59e, data reload: false

------ Round 1 ----------------------------------
q1	17573	5659	5161	5161
q2	2057	305	169	169
q3	10405	1248	776	776
q4	10211	1021	539	539
q5	7539	2409	2387	2387
q6	201	170	138	138
q7	909	768	602	602
q8	9302	1342	1151	1151
q9	4982	4808	4609	4609
q10	6850	2313	1884	1884
q11	504	285	265	265
q12	355	368	218	218
q13	17769	3739	3124	3124
q14	248	231	225	225
q15	540	503	499	499
q16	632	613	575	575
q17	608	932	355	355
q18	6824	6498	6374	6374
q19	1529	941	581	581
q20	344	337	209	209
q21	3028	2240	2015	2015
q22	1020	1032	988	988
Total cold run time: 103430 ms
Total hot run time: 32844 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5296	5167	5211	5167
q2	253	333	233	233
q3	2146	2672	2318	2318
q4	1482	1844	1406	1406
q5	4340	4150	4118	4118
q6	217	168	127	127
q7	2007	1910	1735	1735
q8	2639	2695	2573	2573
q9	7221	7177	7263	7177
q10	3096	3245	2789	2789
q11	594	527	507	507
q12	691	724	604	604
q13	3612	3866	3284	3284
q14	292	301	274	274
q15	530	472	492	472
q16	656	693	687	687
q17	1224	1635	1343	1343
q18	7740	7606	7519	7519
q19	889	869	1061	869
q20	2015	2003	1896	1896
q21	5632	5107	4789	4789
q22	1126	1075	1061	1061
Total cold run time: 53698 ms
Total hot run time: 50948 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193107 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3aa317c9ff1cb021c9676acc796a2f3f5886e59e, data reload: false

query1	1373	1021	1008	1008
query2	6213	1930	1905	1905
query3	11133	4549	4660	4549
query4	53852	24964	23169	23169
query5	4993	548	491	491
query6	332	211	186	186
query7	4851	523	297	297
query8	296	244	221	221
query9	5273	2603	2594	2594
query10	433	322	268	268
query11	15213	15262	14947	14947
query12	160	111	108	108
query13	1036	522	395	395
query14	10487	7101	6671	6671
query15	210	214	204	204
query16	7143	706	510	510
query17	1097	749	607	607
query18	1588	421	333	333
query19	212	197	179	179
query20	141	125	126	125
query21	223	141	108	108
query22	4378	4659	4353	4353
query23	34214	33623	33443	33443
query24	6051	2458	2471	2458
query25	474	486	423	423
query26	735	282	164	164
query27	2075	492	346	346
query28	2851	2505	2453	2453
query29	597	586	460	460
query30	284	224	192	192
query31	881	883	819	819
query32	75	66	63	63
query33	466	386	310	310
query34	813	900	525	525
query35	798	863	777	777
query36	931	1001	897	897
query37	135	101	77	77
query38	4198	4225	4269	4225
query39	1487	1450	1461	1450
query40	204	118	109	109
query41	53	52	51	51
query42	130	113	111	111
query43	510	531	504	504
query44	1377	829	849	829
query45	179	179	165	165
query46	873	1038	678	678
query47	1842	1855	1784	1784
query48	384	427	324	324
query49	728	540	424	424
query50	741	781	439	439
query51	4320	4311	4271	4271
query52	110	112	98	98
query53	262	270	197	197
query54	531	535	427	427
query55	91	88	86	86
query56	278	271	278	271
query57	1137	1158	1106	1106
query58	265	238	239	238
query59	2672	2911	2666	2666
query60	299	272	283	272
query61	126	119	122	119
query62	754	763	701	701
query63	246	211	206	206
query64	2297	1065	743	743
query65	4568	4454	4440	4440
query66	745	399	301	301
query67	15786	15498	15306	15306
query68	7234	894	507	507
query69	537	308	280	280
query70	1213	1177	1136	1136
query71	500	314	291	291
query72	5904	3620	3745	3620
query73	1364	736	345	345
query74	9126	9195	8932	8932
query75	3749	3176	2715	2715
query76	4060	1220	783	783
query77	710	386	284	284
query78	10072	10069	9234	9234
query79	2635	816	599	599
query80	735	518	447	447
query81	479	269	218	218
query82	580	123	95	95
query83	175	168	148	148
query84	292	92	76	76
query85	790	355	305	305
query86	382	309	280	280
query87	4487	4583	4569	4569
query88	3544	2245	2230	2230
query89	422	315	281	281
query90	1762	213	215	213
query91	136	141	110	110
query92	70	58	59	58
query93	1924	1061	581	581
query94	673	415	310	310
query95	389	269	259	259
query96	480	567	282	282
query97	3365	3425	3286	3286
query98	236	208	197	197
query99	1435	1422	1260	1260
Total cold run time: 298670 ms
Total hot run time: 193107 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.51 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3aa317c9ff1cb021c9676acc796a2f3f5886e59e, data reload: false

query1	0.03	0.03	0.03
query2	0.10	0.04	0.05
query3	0.27	0.05	0.05
query4	1.61	0.07	0.07
query5	0.57	0.55	0.56
query6	1.19	0.73	0.74
query7	0.02	0.01	0.01
query8	0.06	0.07	0.04
query9	0.62	0.53	0.52
query10	0.59	0.58	0.58
query11	0.26	0.13	0.12
query12	0.25	0.13	0.13
query13	0.64	0.62	0.61
query14	2.65	2.67	2.76
query15	0.99	0.87	0.87
query16	0.38	0.38	0.37
query17	1.04	1.03	1.02
query18	0.18	0.18	0.18
query19	1.95	1.81	2.01
query20	0.01	0.01	0.01
query21	15.39	0.99	0.67
query22	0.93	1.08	0.83
query23	14.69	1.55	0.75
query24	5.28	0.62	0.30
query25	0.16	0.09	0.09
query26	0.56	0.23	0.18
query27	0.09	0.09	0.09
query28	11.05	1.22	0.57
query29	12.56	4.11	3.45
query30	0.27	0.09	0.07
query31	2.80	0.61	0.42
query32	3.23	0.59	0.50
query33	3.00	3.09	3.04
query34	16.50	5.21	4.50
query35	4.54	4.56	4.51
query36	0.63	0.52	0.49
query37	0.20	0.17	0.18
query38	0.16	0.15	0.15
query39	0.05	0.04	0.04
query40	0.19	0.16	0.15
query41	0.10	0.05	0.05
query42	0.06	0.04	0.04
query43	0.05	0.04	0.04
Total cold run time: 105.9 s
Total hot run time: 31.51 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 27.27% (3/11) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 46.82% (12523/26745)
Line Coverage 36.42% (106733/293056)
Region Coverage 35.46% (54516/153731)
Branch Coverage 30.82% (27412/88942)

@suxiaogang223
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity cloud ut coverage result:
Function Coverage: 82.15% (1063/1294)
Line Coverage: 65.71% (17637/26840)
Region Coverage: 65.16% (8692/13340)
Branch Coverage: 55.10% (4689/8510)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3c495ce0aa8ca5a365f2fc94f5592f20750e6d56_3c495ce0aa8ca5a365f2fc94f5592f20750e6d56_cloud/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 32248 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3c495ce0aa8ca5a365f2fc94f5592f20750e6d56, data reload: false

------ Round 1 ----------------------------------
q1	17671	5204	5111	5111
q2	2062	302	183	183
q3	10800	1227	748	748
q4	10306	1021	522	522
q5	8556	2371	2301	2301
q6	191	166	136	136
q7	896	750	614	614
q8	9325	1251	1073	1073
q9	5001	4576	4775	4576
q10	6804	2295	1884	1884
q11	466	270	258	258
q12	348	350	215	215
q13	17752	3697	3104	3104
q14	237	226	208	208
q15	540	492	474	474
q16	619	620	600	600
q17	583	852	352	352
q18	6856	6538	6284	6284
q19	1611	954	553	553
q20	329	324	198	198
q21	2773	2127	1905	1905
q22	1065	1005	949	949
Total cold run time: 104791 ms
Total hot run time: 32248 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5230	5147	5104	5104
q2	244	332	230	230
q3	2128	2630	2245	2245
q4	1397	1817	1343	1343
q5	4244	4115	4124	4115
q6	204	162	125	125
q7	1920	1921	1754	1754
q8	2640	2546	2498	2498
q9	7260	7185	7206	7185
q10	3011	3257	2772	2772
q11	579	506	492	492
q12	728	741	572	572
q13	3466	3895	3282	3282
q14	282	299	279	279
q15	550	504	507	504
q16	643	684	630	630
q17	1166	1589	1341	1341
q18	7806	7727	7490	7490
q19	832	835	893	835
q20	1965	2000	1865	1865
q21	5475	4998	4671	4671
q22	1090	1057	1042	1042
Total cold run time: 52860 ms
Total hot run time: 50374 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192226 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3c495ce0aa8ca5a365f2fc94f5592f20750e6d56, data reload: false

query1	1399	1011	986	986
query2	6326	1891	1900	1891
query3	11053	4421	4380	4380
query4	52464	24558	22973	22973
query5	5081	661	504	504
query6	365	226	199	199
query7	4881	516	298	298
query8	307	253	239	239
query9	5412	2573	2575	2573
query10	463	318	257	257
query11	15162	15193	14867	14867
query12	164	108	111	108
query13	1041	508	399	399
query14	10263	6274	6650	6274
query15	213	198	175	175
query16	7188	665	500	500
query17	1089	740	606	606
query18	1642	411	339	339
query19	213	209	175	175
query20	129	130	129	129
query21	228	130	108	108
query22	4565	4585	4540	4540
query23	34092	33606	33398	33398
query24	6158	2430	2437	2430
query25	486	487	396	396
query26	720	277	156	156
query27	2077	490	339	339
query28	2942	2493	2453	2453
query29	660	591	447	447
query30	280	219	191	191
query31	887	882	760	760
query32	71	63	66	63
query33	475	366	300	300
query34	774	849	538	538
query35	807	849	757	757
query36	940	992	907	907
query37	125	100	75	75
query38	4245	4304	4158	4158
query39	1472	1430	1435	1430
query40	210	119	106	106
query41	60	54	79	54
query42	125	111	108	108
query43	511	515	490	490
query44	1332	803	800	800
query45	178	174	170	170
query46	872	1041	643	643
query47	1834	1905	1825	1825
query48	391	427	321	321
query49	707	525	436	436
query50	709	767	433	433
query51	4308	4276	4295	4276
query52	117	109	100	100
query53	240	271	186	186
query54	507	511	450	450
query55	88	86	84	84
query56	292	299	277	277
query57	1160	1207	1135	1135
query58	245	241	247	241
query59	2765	2929	2885	2885
query60	316	285	307	285
query61	131	149	120	120
query62	712	741	700	700
query63	243	198	203	198
query64	2339	1097	715	715
query65	4612	4575	4463	4463
query66	737	394	294	294
query67	15906	15429	15278	15278
query68	6957	887	508	508
query69	523	301	263	263
query70	1231	1180	1156	1156
query71	510	297	270	270
query72	5737	3687	3885	3687
query73	1551	749	347	347
query74	9264	9214	8718	8718
query75	4095	3170	2701	2701
query76	4190	1188	759	759
query77	796	373	344	344
query78	10073	10141	9260	9260
query79	2623	830	585	585
query80	605	516	449	449
query81	509	262	222	222
query82	474	126	95	95
query83	206	169	152	152
query84	296	94	75	75
query85	761	356	309	309
query86	369	288	274	274
query87	4466	4605	4515	4515
query88	3606	2240	2246	2240
query89	401	312	279	279
query90	1797	209	207	207
query91	140	145	114	114
query92	73	65	59	59
query93	2046	1072	583	583
query94	671	432	305	305
query95	346	267	264	264
query96	491	569	272	272
query97	3375	3443	3324	3324
query98	229	208	202	202
query99	1441	1413	1297	1297
Total cold run time: 298358 ms
Total hot run time: 192226 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.58 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3c495ce0aa8ca5a365f2fc94f5592f20750e6d56, data reload: false

query1	0.03	0.03	0.03
query2	0.11	0.04	0.05
query3	0.28	0.05	0.05
query4	1.60	0.08	0.08
query5	0.56	0.54	0.54
query6	1.18	0.74	0.72
query7	0.02	0.01	0.02
query8	0.05	0.05	0.05
query9	0.64	0.52	0.53
query10	0.57	0.59	0.58
query11	0.26	0.12	0.13
query12	0.25	0.13	0.12
query13	0.64	0.61	0.62
query14	2.64	2.70	2.81
query15	1.01	0.88	0.87
query16	0.37	0.38	0.37
query17	1.05	1.04	1.03
query18	0.18	0.19	0.19
query19	1.99	1.94	1.94
query20	0.01	0.01	0.01
query21	15.36	0.98	0.69
query22	0.93	1.04	0.78
query23	14.73	1.54	0.79
query24	5.12	0.61	0.30
query25	0.17	0.09	0.09
query26	0.55	0.22	0.18
query27	0.09	0.09	0.08
query28	11.02	1.20	0.57
query29	12.54	4.13	3.44
query30	0.29	0.08	0.08
query31	2.82	0.61	0.43
query32	3.23	0.59	0.50
query33	3.09	3.03	3.07
query34	16.54	5.19	4.45
query35	4.52	4.53	4.46
query36	0.64	0.51	0.49
query37	0.20	0.18	0.16
query38	0.17	0.16	0.16
query39	0.05	0.04	0.04
query40	0.21	0.15	0.14
query41	0.11	0.05	0.06
query42	0.07	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 105.94 s
Total hot run time: 31.58 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 27.27% (3/11) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 46.83% (12524/26745)
Line Coverage 36.42% (106741/293056)
Region Coverage 35.47% (54531/153731)
Branch Coverage 30.82% (27415/88942)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dev/2.1.x-experimental dev/3.0.x-experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@suxiaogang223 @Thearas @doris-robot @hello-stephen @morningman