Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test](beut) add case when beut to test execute_short_circuit #48781

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Mryange
Copy link
Contributor

@Mryange Mryange commented Mar 6, 2025

What problem does this PR solve?

This PR(#47179) fixes a bug in the CASE WHEN statement. (When there are more than 255 conditions, it follows the execute_short_circuit path).
Here, this case is added to the beut.

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Mar 6, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Mryange
Copy link
Contributor Author

Mryange commented Mar 6, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32642 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit caadeb6033816a206c7f3a19c6f6791ef60ba16a, data reload: false

------ Round 1 ----------------------------------
q1	17584	5256	5033	5033
q2	2051	293	169	169
q3	10408	1359	717	717
q4	10221	1009	526	526
q5	7681	2397	2401	2397
q6	188	166	142	142
q7	901	757	611	611
q8	9317	1372	1200	1200
q9	4930	4700	4748	4700
q10	6813	2298	1908	1908
q11	480	287	269	269
q12	346	350	220	220
q13	17757	3681	3073	3073
q14	231	223	215	215
q15	539	495	489	489
q16	645	624	596	596
q17	566	853	360	360
q18	7345	6451	6342	6342
q19	1225	942	533	533
q20	327	329	196	196
q21	2834	2146	1954	1954
q22	1092	1038	992	992
Total cold run time: 103481 ms
Total hot run time: 32642 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5116	5147	5263	5147
q2	240	341	232	232
q3	2152	2668	2302	2302
q4	1422	1840	1383	1383
q5	4269	4109	4146	4109
q6	204	163	124	124
q7	1875	1922	1800	1800
q8	2641	2716	2597	2597
q9	7155	7149	7126	7126
q10	3035	3206	2769	2769
q11	597	507	517	507
q12	691	801	665	665
q13	3526	3986	3272	3272
q14	293	307	286	286
q15	518	474	477	474
q16	651	689	639	639
q17	1145	1594	1354	1354
q18	7938	7583	7389	7389
q19	814	811	855	811
q20	1976	2016	1875	1875
q21	5367	5034	4831	4831
q22	1129	1073	1054	1054
Total cold run time: 52754 ms
Total hot run time: 50746 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186004 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit caadeb6033816a206c7f3a19c6f6791ef60ba16a, data reload: false

query1	998	395	395	395
query2	6531	1990	2012	1990
query3	6792	216	220	216
query4	26530	23301	23232	23232
query5	4331	658	483	483
query6	311	197	202	197
query7	4605	489	296	296
query8	298	242	225	225
query9	8627	2566	2562	2562
query10	467	312	260	260
query11	16135	15149	14952	14952
query12	147	107	107	107
query13	1678	509	390	390
query14	9502	6498	6617	6498
query15	221	198	176	176
query16	7201	650	423	423
query17	1216	725	594	594
query18	1948	408	304	304
query19	198	192	158	158
query20	122	116	111	111
query21	207	123	108	108
query22	4109	4149	4328	4149
query23	33840	33108	32935	32935
query24	7676	2380	2418	2380
query25	536	463	402	402
query26	1224	267	154	154
query27	2141	492	320	320
query28	3901	2436	2407	2407
query29	775	537	430	430
query30	283	212	189	189
query31	922	825	771	771
query32	73	67	65	65
query33	550	357	326	326
query34	777	855	505	505
query35	790	803	726	726
query36	967	1007	903	903
query37	112	99	80	80
query38	4186	4025	4050	4025
query39	1427	1392	1443	1392
query40	210	112	102	102
query41	54	52	53	52
query42	124	103	111	103
query43	518	521	491	491
query44	1303	806	796	796
query45	175	172	163	163
query46	834	1013	630	630
query47	1748	1782	1726	1726
query48	372	405	292	292
query49	797	528	416	416
query50	686	715	413	413
query51	4217	4231	4155	4155
query52	102	98	95	95
query53	232	258	186	186
query54	500	507	417	417
query55	86	82	82	82
query56	269	261	262	261
query57	1115	1141	1044	1044
query58	252	234	235	234
query59	2601	2773	2874	2773
query60	288	267	266	266
query61	171	122	116	116
query62	812	740	652	652
query63	236	190	194	190
query64	4364	1008	656	656
query65	4471	4302	4308	4302
query66	1153	419	301	301
query67	15711	15596	15426	15426
query68	8725	877	502	502
query69	471	321	268	268
query70	1217	1099	1157	1099
query71	449	291	270	270
query72	5578	3543	3714	3543
query73	788	735	346	346
query74	8979	9371	8885	8885
query75	3784	3179	2705	2705
query76	3615	1172	745	745
query77	784	391	288	288
query78	9901	10250	9276	9276
query79	1594	857	602	602
query80	639	535	451	451
query81	479	253	218	218
query82	569	131	102	102
query83	175	178	159	159
query84	239	174	78	78
query85	770	360	303	303
query86	338	314	287	287
query87	4337	4597	4614	4597
query88	2851	2254	2260	2254
query89	389	312	283	283
query90	1974	213	215	213
query91	139	152	107	107
query92	80	63	57	57
query93	1160	1077	591	591
query94	683	386	302	302
query95	361	278	259	259
query96	567	563	280	280
query97	3268	3387	3290	3290
query98	218	208	208	208
query99	1400	1375	1260	1260
Total cold run time: 272276 ms
Total hot run time: 186004 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.12 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit caadeb6033816a206c7f3a19c6f6791ef60ba16a, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.04	0.04
query3	0.23	0.07	0.06
query4	1.61	0.10	0.10
query5	0.55	0.56	0.56
query6	1.19	0.72	0.71
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.60	0.53	0.50
query10	0.58	0.62	0.57
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.62	0.61	0.60
query14	2.70	2.85	2.72
query15	0.92	0.84	0.84
query16	0.39	0.37	0.38
query17	1.03	1.04	1.08
query18	0.21	0.20	0.20
query19	1.98	1.86	1.97
query20	0.01	0.01	0.02
query21	15.36	0.92	0.54
query22	0.75	1.19	0.77
query23	14.86	1.32	0.59
query24	7.14	1.81	0.82
query25	0.49	0.08	0.19
query26	0.57	0.18	0.14
query27	0.06	0.05	0.05
query28	9.96	0.83	0.42
query29	12.56	4.08	3.46
query30	0.24	0.08	0.06
query31	2.84	0.58	0.38
query32	3.23	0.56	0.47
query33	3.08	3.02	3.06
query34	15.84	5.18	4.52
query35	4.58	4.58	4.53
query36	0.66	0.48	0.48
query37	0.09	0.06	0.05
query38	0.04	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.13	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 105.8 s
Total hot run time: 31.12 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 14.29% (1/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 46.86% (12532/26745)
Line Coverage 36.46% (106852/293048)
Region Coverage 35.52% (54603/153724)
Branch Coverage 30.86% (27446/88936)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants