Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat](kerberos)Fix Kerberos Ticket Refresh Logic to Avoid Premature Credential Clearance in Multithreaded Environments #48785

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CalvinKirs
Copy link
Member

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…Credential Clearance in Multithreaded Environments
@Thearas
Copy link
Contributor

Thearas commented Mar 6, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@CalvinKirs
Copy link
Member Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33114 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3a35f8ef103fe10afe11b96d5e8ab53804f9113a, data reload: false

------ Round 1 ----------------------------------
q1	17760	5277	5042	5042
q2	2061	293	164	164
q3	10993	1260	742	742
q4	10275	1048	549	549
q5	8156	2312	2392	2312
q6	194	168	133	133
q7	892	756	607	607
q8	9610	1314	1118	1118
q9	5237	4940	4673	4673
q10	6831	2348	1923	1923
q11	506	285	259	259
q12	342	345	222	222
q13	17865	3723	3090	3090
q14	253	224	217	217
q15	541	501	482	482
q16	623	633	600	600
q17	585	853	347	347
q18	7113	6930	6819	6819
q19	2669	990	552	552
q20	318	318	202	202
q21	2872	2165	2072	2072
q22	1125	1064	989	989
Total cold run time: 106821 ms
Total hot run time: 33114 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5310	5145	5163	5145
q2	257	338	231	231
q3	2183	2669	2338	2338
q4	1476	1879	1373	1373
q5	4294	4140	4336	4140
q6	222	173	126	126
q7	2025	1977	1835	1835
q8	2674	2699	2658	2658
q9	7328	7392	7287	7287
q10	3070	3210	2676	2676
q11	565	515	498	498
q12	671	813	627	627
q13	3593	3922	3361	3361
q14	281	303	270	270
q15	524	479	467	467
q16	642	696	668	668
q17	1154	1618	1310	1310
q18	7934	7607	7512	7512
q19	855	842	965	842
q20	1940	2016	1875	1875
q21	5449	4776	4911	4776
q22	1095	1084	1016	1016
Total cold run time: 53542 ms
Total hot run time: 51031 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191202 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3a35f8ef103fe10afe11b96d5e8ab53804f9113a, data reload: false

query1	1367	1014	984	984
query2	6455	1974	1996	1974
query3	11035	4269	4445	4269
query4	53820	25586	22943	22943
query5	5170	542	474	474
query6	347	183	174	174
query7	5086	496	285	285
query8	319	233	236	233
query9	6336	2551	2569	2551
query10	443	313	257	257
query11	15178	15200	14872	14872
query12	157	111	107	107
query13	1149	503	392	392
query14	10241	6389	6517	6389
query15	209	196	183	183
query16	7033	634	475	475
query17	1101	731	572	572
query18	1524	415	308	308
query19	204	207	184	184
query20	128	126	129	126
query21	215	126	113	113
query22	4329	4303	4452	4303
query23	33789	33610	33338	33338
query24	6263	2447	2430	2430
query25	452	470	391	391
query26	692	280	154	154
query27	2089	484	334	334
query28	3187	2476	2461	2461
query29	572	552	430	430
query30	272	223	193	193
query31	877	860	787	787
query32	72	59	59	59
query33	433	372	300	300
query34	747	860	493	493
query35	786	840	748	748
query36	968	1008	904	904
query37	113	102	75	75
query38	4198	4090	4307	4090
query39	1475	1435	1433	1433
query40	209	114	102	102
query41	53	51	52	51
query42	123	109	110	109
query43	508	516	497	497
query44	1326	829	819	819
query45	182	173	164	164
query46	868	1038	649	649
query47	1826	1875	1787	1787
query48	386	431	303	303
query49	700	530	421	421
query50	704	746	432	432
query51	4274	4317	4257	4257
query52	112	99	97	97
query53	224	262	187	187
query54	486	493	428	428
query55	85	90	91	90
query56	280	264	262	262
query57	1180	1155	1151	1151
query58	249	248	239	239
query59	2728	2893	2865	2865
query60	288	320	278	278
query61	118	115	133	115
query62	726	760	690	690
query63	225	192	193	192
query64	1497	1045	660	660
query65	4557	4441	4435	4435
query66	715	437	298	298
query67	15812	15503	15371	15371
query68	7125	871	512	512
query69	544	305	265	265
query70	1174	1143	1066	1066
query71	497	279	259	259
query72	5934	3638	3767	3638
query73	1363	744	342	342
query74	9020	9021	8737	8737
query75	3789	3154	2773	2773
query76	4261	1200	735	735
query77	632	355	275	275
query78	9915	9990	9276	9276
query79	3026	819	598	598
query80	646	520	435	435
query81	475	258	225	225
query82	445	125	97	97
query83	275	167	146	146
query84	289	99	149	99
query85	772	341	299	299
query86	336	303	305	303
query87	4490	4400	4409	4400
query88	2845	2185	2214	2185
query89	419	313	277	277
query90	1978	212	205	205
query91	133	137	105	105
query92	71	61	60	60
query93	1805	1074	582	582
query94	694	422	282	282
query95	344	264	252	252
query96	476	552	272	272
query97	3370	3401	3322	3322
query98	212	210	200	200
query99	1442	1363	1243	1243
Total cold run time: 298069 ms
Total hot run time: 191202 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.87 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3a35f8ef103fe10afe11b96d5e8ab53804f9113a, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.62	0.10	0.10
query5	0.56	0.55	0.54
query6	1.24	0.71	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.58	0.52	0.51
query10	0.58	0.60	0.59
query11	0.15	0.11	0.11
query12	0.15	0.11	0.11
query13	0.62	0.60	0.59
query14	2.66	2.82	2.68
query15	0.93	0.86	0.85
query16	0.39	0.38	0.37
query17	1.02	1.02	0.99
query18	0.21	0.20	0.19
query19	1.95	1.83	1.97
query20	0.01	0.01	0.01
query21	15.35	0.89	0.52
query22	0.75	1.10	0.63
query23	15.10	1.36	0.59
query24	7.03	1.75	0.98
query25	0.50	0.25	0.09
query26	0.54	0.15	0.14
query27	0.05	0.04	0.05
query28	9.98	0.82	0.42
query29	12.52	4.14	3.43
query30	0.25	0.09	0.06
query31	2.82	0.58	0.39
query32	3.24	0.55	0.46
query33	3.06	3.01	3.12
query34	15.86	5.11	4.45
query35	4.54	4.52	4.52
query36	0.66	0.50	0.48
query37	0.09	0.07	0.06
query38	0.05	0.04	0.03
query39	0.04	0.02	0.02
query40	0.17	0.13	0.13
query41	0.09	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.02	0.02
Total cold run time: 105.82 s
Total hot run time: 30.87 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants