[fix](cloud) retry read_at when corruption using file cache #48786
+167
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhengyu <[email protected]>
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
gavinchou
reviewed
Mar 6, 2025
| return file_cache_key_from_path(seg_path).to_string(); | ||
| } | ||
|
|
||
| Status PageIO::read_and_decompress_page_with_file_cache_retry(const PageReadOptions& opts, |
There was a problem hiding this comment.
where is this function is called?
| @@ -229,5 +235,50 @@ Status PageIO::read_and_decompress_page_(const PageReadOptions& opts, PageHandle | |||
| return Status::OK(); | |||
| } | |||
|
|
|||
| io::UInt128Wrapper file_cache_key_from_path(const std::string& seg_path) { | |||
There was a problem hiding this comment.
is it mandatory to introduce file cache to PageIO?
Signed-off-by: zhengyu <[email protected]>
Signed-off-by: zhengyu <[email protected]>
Signed-off-by: zhengyu <[email protected]>
gavinchou
reviewed
Mar 6, 2025
| Slice body; | ||
| PageFooterPB footer; | ||
| RETURN_IF_ERROR( | ||
| PageIO::read_and_decompress_page(opts, &_sk_index_handle, &body, &footer)); | ||
| RETURN_IF_ERROR(PageIO::read_and_decompress_page_with_file_cache_retry( |
There was a problem hiding this comment.
it's better that we expand read_and_decompress_page_with_file_cache_retry() in segment.cpp
instead of hacking page_io.h/cpp.
the low level IO should not notice "file cache".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)