Skip to content

Commit

Permalink
comments
Browse files Browse the repository at this point in the history
  • Loading branch information
adithyachakilam committed Nov 5, 2024
1 parent 69ea344 commit bba9486
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,6 @@ public void testCreateTaskIOConfig()
)
);

Assert.assertEquals(ioConfig.getTaskDuration(), Duration.standardMinutes(30));
Assert.assertEquals(Duration.standardMinutes(30), ioConfig.getTaskDuration());
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ public class KafkaConsumerMonitor extends AbstractMonitor
.put("records-consumed-total", "kafka/consumer/recordsConsumed")
.build();
private static final String TOPIC_TAG = "topic";
private static final String DATASOURCE_TAG = "datasource";
private static final Set<String> TOPIC_METRIC_TAGS = ImmutableSet.of("client-id", TOPIC_TAG);

private final KafkaConsumer<?, ?> consumer;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,7 @@ protected KafkaRecordSupplier newTaskRecordSupplier(final TaskToolbox toolbox)

final KafkaRecordSupplier recordSupplier =
new KafkaRecordSupplier(props, configMapper, kafkaIndexTaskIOConfig.getConfigOverrides(),
kafkaIndexTaskIOConfig.isMultiTopic()
);
kafkaIndexTaskIOConfig.isMultiTopic());

if (toolbox.getMonitorScheduler() != null) {
toolbox.getMonitorScheduler().addMonitor(recordSupplier.monitor());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ public class KafkaRecordSupplierTest
private static KafkaTopicPartition PARTITION_1 = new KafkaTopicPartition(false, null, 1);

private static String TOPIC = "topic";
private static String STREAM = "stream";
private static int TOPIC_POS_FIX = 0;
private static TestingCluster ZK_SERVER;
private static TestBroker KAFKA_SERVER;
Expand Down

0 comments on commit bba9486

Please sign in to comment.