remove search auto strategy, estimateSelectivity of BitmapColumnIndex (…

…#15550)

* remove search auto strategy, estimateSelectivity of BitmapColumnIndex

* more cleanup

benchmarks/src/test/java/org/apache/druid/benchmark/DictionaryEncodedStringIndexSupplierBenchmark.java

@@ -145,6 +145,5 @@ private Iterable<Integer> intGenerator()
   public void doValueSetCheck(Blackhole blackhole, BenchmarkState state)
   {
     BitmapColumnIndex bitmapIndex = state.stringValueSetIndex.forSortedValuesUtf8(state.values);
-    bitmapIndex.estimateSelectivity(10_000_000);
   }
 }

docs/querying/searchquery.md

@@ -126,10 +126,6 @@ are unique.
 queryableIndexSegment, and then evaluates search predicates. If some filters support bitmap indexes, the cursor can read
 only the rows which satisfy those filters, thereby saving I/O cost. However, it might be slow with filters of low selectivity.
 
-- "auto" strategy uses a cost-based planner for choosing an optimal search strategy. It estimates the cost of index-only
-and cursor-based execution plans, and chooses the optimal one. Currently, it is not enabled by default due to the overhead
-of cost estimation.
-
 ## Server configuration
 
 The following runtime properties apply:

processing/src/main/java/org/apache/druid/query/filter/ArrayContainsElementFilter.java

@@ -40,7 +40,6 @@
 import org.apache.druid.segment.BaseLongColumnValueSelector;
 import org.apache.druid.segment.ColumnInspector;
 import org.apache.druid.segment.ColumnProcessors;
-import org.apache.druid.segment.ColumnSelector;
 import org.apache.druid.segment.ColumnSelectorFactory;
 import org.apache.druid.segment.DimensionSelector;
 import org.apache.druid.segment.column.ColumnCapabilities;
@@ -271,12 +270,6 @@ public VectorValueMatcher makeVectorMatcher(VectorColumnSelectorFactory factory)
     ).makeMatcher(predicateFactory);
   }
 
-  @Override
-  public boolean supportsSelectivityEstimation(ColumnSelector columnSelector, ColumnIndexSelector indexSelector)
-  {
-    return Filters.supportsSelectivityEstimation(this, column, columnSelector, indexSelector);
-  }
-
   @Override
   public boolean canVectorizeMatcher(ColumnInspector inspector)
   {

processing/src/main/java/org/apache/druid/query/filter/BooleanFilter.java

@@ -19,7 +19,6 @@
 
 package org.apache.druid.query.filter;
 
-import org.apache.druid.segment.ColumnSelector;
 import org.apache.druid.segment.ColumnSelectorFactory;
 
 import java.util.HashSet;
@@ -70,14 +69,4 @@ default Set<String> getRequiredColumns()
     return allColumns;
   }
 
-  @Override
-  default boolean supportsSelectivityEstimation(ColumnSelector columnSelector, ColumnIndexSelector indexSelector)
-  {
-    for (Filter filter : getFilters()) {
-      if (!filter.supportsSelectivityEstimation(columnSelector, indexSelector)) {
-        return false;
-      }
-    }
-    return true;
-  }
 }

processing/src/main/java/org/apache/druid/query/filter/EqualityFilter.java

@@ -44,7 +44,6 @@
 import org.apache.druid.segment.ColumnInspector;
 import org.apache.druid.segment.ColumnProcessorFactory;
 import org.apache.druid.segment.ColumnProcessors;
-import org.apache.druid.segment.ColumnSelector;
 import org.apache.druid.segment.ColumnSelectorFactory;
 import org.apache.druid.segment.DimensionSelector;
 import org.apache.druid.segment.column.ColumnCapabilities;
@@ -267,12 +266,6 @@ public VectorValueMatcher makeVectorMatcher(VectorColumnSelectorFactory factory)
     ).makeMatcher(new EqualityPredicateFactory(matchValueEval));
   }
 
-  @Override
-  public boolean supportsSelectivityEstimation(ColumnSelector columnSelector, ColumnIndexSelector indexSelector)
-  {
-    return Filters.supportsSelectivityEstimation(this, column, columnSelector, indexSelector);
-  }
-
   @Override
   public boolean canVectorizeMatcher(ColumnInspector inspector)
   {

processing/src/main/java/org/apache/druid/query/filter/Filter.java

@@ -24,7 +24,6 @@
 import org.apache.druid.query.BitmapResultFactory;
 import org.apache.druid.query.filter.vector.VectorValueMatcher;
 import org.apache.druid.segment.ColumnInspector;
-import org.apache.druid.segment.ColumnSelector;
 import org.apache.druid.segment.ColumnSelectorFactory;
 import org.apache.druid.segment.index.BitmapColumnIndex;
 import org.apache.druid.segment.vector.VectorColumnSelectorFactory;
@@ -70,37 +69,6 @@ default VectorValueMatcher makeVectorMatcher(VectorColumnSelectorFactory factory
     throw new UOE("Filter[%s] cannot vectorize", getClass().getName());
   }
 
-  /**
-   * Estimate selectivity of this filter.
-   * This method can be used for cost-based query planning like in {@link org.apache.druid.query.search.AutoStrategy}.
-   * To avoid significant performance degradation for calculating the exact cost,
-   * implementation of this method targets to achieve rapid selectivity estimation
-   * with reasonable sacrifice of the accuracy.
-   * As a result, the estimated selectivity might be different from the exact value.
-   *
-   * @param indexSelector Object used to retrieve indexes
-   *
-   * @return an estimated selectivity ranging from 0 (filter selects no rows) to 1 (filter selects all rows).
-   *
-   * @see Filter#getBitmapColumnIndex(ColumnIndexSelector)
-   */
-  default double estimateSelectivity(ColumnIndexSelector indexSelector)
-  {
-    return getBitmapColumnIndex(indexSelector).estimateSelectivity(indexSelector.getNumRows());
-  }
-
-  /**
-   * Indicates whether this filter supports selectivity estimation.
-   * A filter supports selectivity estimation if it supports bitmap index and
-   * the dimension which the filter evaluates does not have multi values.
-   *
-   * @param columnSelector Object to check the dimension has multi values.
-   * @param indexSelector  Object used to retrieve bitmap indexes
-   *
-   * @return true if this Filter supports selectivity estimation, false otherwise.
-   */
-  boolean supportsSelectivityEstimation(ColumnSelector columnSelector, ColumnIndexSelector indexSelector);
-
   /**
    * Returns true if this filter can produce a vectorized matcher from its "makeVectorMatcher" method.
    * @param inspector Supplies type information for the selectors this filter will match against

processing/src/main/java/org/apache/druid/query/filter/InDimFilter.java

@@ -54,7 +54,6 @@
 import org.apache.druid.query.lookup.LookupExtractor;
 import org.apache.druid.segment.ColumnInspector;
 import org.apache.druid.segment.ColumnProcessors;
-import org.apache.druid.segment.ColumnSelector;
 import org.apache.druid.segment.ColumnSelectorFactory;
 import org.apache.druid.segment.DimensionHandlerUtils;
 import org.apache.druid.segment.column.ColumnIndexSupplier;
@@ -364,12 +363,6 @@ public Filter rewriteRequiredColumns(Map<String, String> columnRewrites)
     }
   }
 
-  @Override
-  public boolean supportsSelectivityEstimation(ColumnSelector columnSelector, ColumnIndexSelector indexSelector)
-  {
-    return Filters.supportsSelectivityEstimation(this, dimension, columnSelector, indexSelector);
-  }
-
   @Override
   public String toString()
   {

processing/src/main/java/org/apache/druid/query/filter/NullFilter.java

@@ -35,7 +35,6 @@
 import org.apache.druid.query.filter.vector.VectorValueMatcherColumnProcessorFactory;
 import org.apache.druid.segment.ColumnInspector;
 import org.apache.druid.segment.ColumnProcessors;
-import org.apache.druid.segment.ColumnSelector;
 import org.apache.druid.segment.ColumnSelectorFactory;
 import org.apache.druid.segment.column.ColumnIndexSupplier;
 import org.apache.druid.segment.column.TypeSignature;
@@ -158,12 +157,6 @@ public VectorValueMatcher makeVectorMatcher(VectorColumnSelectorFactory factory)
     ).makeMatcher(NullPredicateFactory.INSTANCE);
   }
 
-  @Override
-  public boolean supportsSelectivityEstimation(ColumnSelector columnSelector, ColumnIndexSelector indexSelector)
-  {
-    return Filters.supportsSelectivityEstimation(this, column, columnSelector, indexSelector);
-  }
-
   @Override
   public boolean canVectorizeMatcher(ColumnInspector inspector)
   {

processing/src/main/java/org/apache/druid/query/filter/RangeFilter.java

@@ -43,7 +43,6 @@
 import org.apache.druid.query.ordering.StringComparators;
 import org.apache.druid.segment.ColumnInspector;
 import org.apache.druid.segment.ColumnProcessors;
-import org.apache.druid.segment.ColumnSelector;
 import org.apache.druid.segment.ColumnSelectorFactory;
 import org.apache.druid.segment.column.ColumnIndexSupplier;
 import org.apache.druid.segment.column.ColumnType;
@@ -358,12 +357,6 @@ public VectorValueMatcher makeVectorMatcher(VectorColumnSelectorFactory factory)
     ).makeMatcher(getPredicateFactory());
   }
 
-  @Override
-  public boolean supportsSelectivityEstimation(ColumnSelector columnSelector, ColumnIndexSelector indexSelector)
-  {
-    return Filters.supportsSelectivityEstimation(this, column, columnSelector, indexSelector);
-  }
-
   @Override
   public boolean canVectorizeMatcher(ColumnInspector inspector)
   {