-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE: 28.0.0 release notes #15173
Conversation
docs/do-not-merge.md
Outdated
|
||
# Upgrade notes and incompatible changes | ||
|
||
## Upgrade notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should do something a bit different than previous releases before we finally publish these release notes, where this section is about upgrading from Druid 27, and then we also should include the upgrade notices from the previous few releases as well, just copied in from earlier release notes. So that way we have all the information in one place to cover like a year worth of upgrades. I don't think this needs to be added yet, we can wait until the last minute before publishing, but I think it would be helpful since operators don't always upgrade every release
docs/do-not-merge.md
Outdated
|
||
## SQL planner improvements | ||
|
||
Druid uses Apache Calcite for SQL planning and optimization. Starting in Druid 28.0.0, the Calcite version has been upgraded from 1.21 to 1.35. This upgrade brings in many bug fixes in SQL planning from Calcite. As part of the upgrade, the behavior of type inference for [dynamic parameters](#dynamic-parameters) and the [recommended syntax for UNNEST](#new-syntax-for-sql-unnest) have changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this reads kind of funny, the updated recommendation for unnest isn't directly related to the calcite upgrade afaik, rather it is just less likely to run into problems with complicated queries if you use the more verbose cross join syntax. maybe we should just drop this line since we go over dynamic parameter changes immediately after (or move the part about it being related to calcite upgrade into that section)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clintropolis Since the updated recommendation for unnest isn't directly related to the calcite upgrade, I think we should move it to "SQL UNNEST and ingestion flattening".
Closing PR 15173 in favor of #15315. |
Draft PR used to collaborate on the release notes so that we can use the comment/suggestion system.