Add api for Retrieving unused segments #15415

zachjsh · 2023-11-22T22:11:59Z

Description

This pr adds an api for retrieving unused segments for a particular datasource. The api supports pagination by the addition of limit and lastSegmentId parameters. The resulting unused segments are returned with optional sortOrder, ASC or DESC with respect to the matching segments id, start time, and end time, or not returned in any guarenteed order if sortOrder is not specified

GET /druid/coordinator/v1/datasources/{dataSourceName}/unusedSegments?interval={interval}&limit={limit}&lastSegmentId={lastSegmentId}&sortOrder={sortOrder}

Returns a list of unused segments for a datasource in the cluster contained within an optionally specified interval.
Optional parameters for limit and lastSegmentId can be given as well, to limit results and enable paginated results.
The results may be sorted in either ASC, or DESC order depending on specifying the sortOrder parameter.

dataSourceName: The name of the datasource
interval: the specific interval to search for unused segments for.
limit: the maximum number of unused segments to return information about. This property helps to
support pagination
lastSegmentId: the last segment id from which to search for results. All segments returned are > this segment
lexigraphically if sortOrder is null or ASC, or < this segment lexigraphically if sortOrder is DESC.
sortOrder: Specifies the order with which to return the matching segments by start time, end time. A null
value indicates that order does not matter.

Release note

Release note entry removed as this API will be removed. Please see #15721.

This PR has:

* fix checkstyle * refactor * remove deadcode

…ments

server/src/test/java/org/apache/druid/server/http/DataSourcesResourceTest.java

abhishekrb19

Did an initial pass on API design

server/src/main/java/org/apache/druid/metadata/SegmentsMetadataManager.java

server/src/main/java/org/apache/druid/server/http/DataSourcesResource.java

abhishekrb19 · 2023-11-23T01:06:59Z

server/src/main/java/org/apache/druid/server/http/DataSourcesResource.java

+  public Response getIntervalsWithUnusedSegmentsOrAllUnusedSegmentsPerIntervals(
+      @PathParam("dataSourceName") String dataSourceName,
+      @QueryParam("simple") String simple,
+      @QueryParam("full") String full,


Could we include the API in the public-facing docs https://github.com/apache/druid/blob/master/docs/api-reference/legacy-metadata-api.md?

server/src/main/java/org/apache/druid/server/http/DataSourcesResource.java

abhishekrb19 · 2023-11-23T01:27:31Z

server/src/main/java/org/apache/druid/server/http/DataSourcesResource.java

+  @Path("/{dataSourceName}/unused/intervals")
+  @Produces(MediaType.APPLICATION_JSON)
+  @ResourceFilters(DatasourceResourceFilter.class)
+  public Response getIntervalsWithUnusedSegmentsOrAllUnusedSegmentsPerIntervals(


I see we're following the same API patterns in this file written over a decade ago, but I'm wondering if it'd be better to move away from the pattern where an API does multiple things and returns different shapes of responses depending on the parameters specified. For example, in this case, IMO it'd be cleaner to have two different sets of API endpoints each serving only one functionality:

getIntervalsWithUnusedSegments()

getUnusedSegmentsInInterval() where the interval is optional similar to other parameters

What do you think?

updated, now there are 3 apis

…ments

server/src/test/java/org/apache/druid/server/http/DataSourcesResourceTest.java

server/src/main/java/org/apache/druid/server/http/MetadataResource.java

abhishekrb19

Looks good overall. Left a few suggestions and test cases to consider adding. Thanks, @zachjsh!

server/src/main/java/org/apache/druid/metadata/SQLMetadataConnector.java

server/src/main/java/org/apache/druid/metadata/storage/derby/DerbyConnector.java

server/src/main/java/org/apache/druid/metadata/SqlSegmentsMetadataQuery.java

abhishekrb19 · 2023-12-05T20:21:12Z

server/src/test/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinatorTest.java

@@ -3050,19 +3106,20 @@ private List<DataSegment> createAndGetUsedYearSegments(final int startYear, fina

  private ImmutableList<DataSegment> retrieveUnusedSegmentsUsingMultipleIntervalsAndLimit(


Should this method be renamed to include offset in its name, or perhaps could use a simpler name?

server/src/test/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinatorTest.java

abhishekrb19 · 2023-12-05T20:29:50Z

server/src/test/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinatorTest.java

+    int offset = 10;
+    List<DataSegment> expectedSegments = segments.stream().sorted((Comparator<DataSegment>) (o1, o2) -> {
+      long o1Start = o1.getInterval().getStartMillis();
+      long o2Start = o2.getInterval().getStartMillis();


Do we actually need this custom comparator? createAndGetUsedYearSegments() already returns a list of segments sorted by start date. So I think this should suffice:

final List<DataSegment> expectedSegments = segments.stream().skip(offset).collect(Collectors.toList());

abhishekrb19 · 2023-12-05T20:35:31Z

server/src/test/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinatorTest.java

+    Assert.assertEquals(expectedSegments.size(), actualUnusedSegments.size());
+    Assert.assertTrue(expectedSegments.containsAll(actualUnusedSegments));
+  }
+


For test coverage, can we also please include new or extend existing tests for the following scenarios:

non-empty interval, non-null limit and non-null offset

multiple intervals, non-null limit and non-null offset

multiple intervals exceeding MAX_INTERVALS_PER_BATCH, non-null limit and non-null offset (the offset in this case would be ignored)

server/src/main/java/org/apache/druid/server/http/MetadataResource.java

server/src/test/java/org/apache/druid/server/http/MetadataResourceTest.java

Co-authored-by: Abhishek Radhakrishnan <[email protected]>

…ments

abhishekrb19

LGTM! Should we also add a release note entry for this new API?

jon-wei · 2023-12-06T19:37:26Z

server/src/main/java/org/apache/druid/metadata/SegmentsMetadataManager.java

+  Iterable<DataSegment> iterateAllUnusedSegmentsForDatasource(
+      String datasource,
+      @Nullable Interval interval,
+      @Nullable Integer limit,


I think it might be a good idea to go ahead and add a sort order now too

Thanks! Good suggestion. Added

…ments

abhishekrb19 · 2023-12-07T18:08:48Z

server/src/main/java/org/apache/druid/metadata/SqlSegmentsMetadataManager.java

+   * @param interval        The intervals to search over
+   * @param limit           The limit of segments to return
+   * @param offset          The offset to use when retrieving matching segments.
+   * @param orderByStartEnd Specifies the order with which to return the matching segments by start time, end time. A


An enum type would be a better choice for the direction of order by? Similar to OrderByColumnSpec#Direction

Thanks! Added new enum

abhishekrb19 · 2023-12-08T01:48:54Z

For performance-reasons, I think it'd be best if we don't use OFFSET on the segments table. Using OFFSET to page through results in a cluster with large number of segments will become a bottleneck. An alternative idea is to leverage the indices id, start and end built for the segments table along with the uniqueness of segment id via the primary key constraint, we can guarantee a stable sort and page through batched results from a client.

Instead of an OFFSET based paginated query:

SELECT "start", "end", "id"
FROM druid_segments
WHERE dataSource = 'foo' AND "start" >= '2023-01-01' AND "end" < '2024-01-01'
ORDER BY 1, 2
LIMIT 100
OFFSET 10000

We can do a cursor-based query:

SELECT "start", "end", "id"
FROM druid_segments
WHERE dataSource = 'foo' AND "start" >= '2023-01-01' AND "end" < '2024-01-01' AND id > 'foo_2023-02-24T07:00:00.000Z_2023-02-24T08:00:00.000Z_2023-11-20T23:04:26.856Z'
ORDER BY 1, 2, 3
LIMIT 100

The execution plans for these two queries are both simple from EXPLAIN PLAN, but the first query has to read, count and then discard results because of OFFSET, so it'll take longer especially for larger values of OFFSET. With the second query, an API caller should pass in the last segment id from a previous batch (if any); they can also narrow down the search interval as they batch through results as another optimization.

…ments

zachjsh · 2023-12-09T14:41:15Z

For performance-reasons, I think it'd be best if we don't use OFFSET on the segments table. Using OFFSET to page through results in a cluster with large number of segments will become a bottleneck. An alternative idea is to leverage the indices id, start and end built for the segments table along with the uniqueness of segment id via the primary key constraint, we can guarantee a stable sort and page through batched results from a client.

Instead of an OFFSET based paginated query:
SELECT "start", "end", "id"
FROM druid_segments
WHERE dataSource = 'foo' AND "start" >= '2023-01-01' AND "end" < '2024-01-01'
ORDER BY 1, 2
LIMIT 100
OFFSET 10000
We can do a cursor-based query:
SELECT "start", "end", "id"
FROM druid_segments
WHERE dataSource = 'foo' AND "start" >= '2023-01-01' AND "end" < '2024-01-01' AND id > 'foo_2023-02-24T07:00:00.000Z_2023-02-24T08:00:00.000Z_2023-11-20T23:04:26.856Z'
ORDER BY 1, 2, 3
LIMIT 100
The execution plans for these two queries are both simple from EXPLAIN PLAN, but the first query has to read, count and then discard results because of OFFSET, so it'll take longer especially for larger values of OFFSET. With the second query, an API caller should pass in the last segment id from a previous batch (if any); they can also narrow down the search interval as they batch through results as another optimization.

Good suggestion, updated.

abhishekrb19 · 2023-12-10T21:16:08Z

docs/api-reference/legacy-metadata-api.md

@@ -248,6 +248,12 @@ Returns full segment metadata for a specific segment in the cluster.

 Return the tiers that a datasource exists in.

+`GET /druid/coordinator/v1/datasources/{dataSourceName}/unusedSegments?interval={interval}&limit={limit}&lastSegmentId={lastSegmentId}&sortOrder={sortOrder}`
+
+Returns a list of unused segments for a datasource in the cluster contained within an optionally specified interval.


To make the API behavior clear in the absence of all the optional parameters, maybe specify what the defaults for the no interval, no limit, etc. Also, it'd be good to include an example for these params, so a user knows what to specify for params like sortOrder (wish we had an open API spec in Druid :)).

abhishekrb19 · 2023-12-10T21:17:27Z

server/src/main/java/org/apache/druid/metadata/SQLMetadataConnector.java

+  /**
+   * @return the string offset clause
+   */
+  public String getOffsetClause(int offset)


Unused offset method, so remove it

abhishekrb19 · 2023-12-10T21:22:57Z

server/src/main/java/org/apache/druid/metadata/SegmentsMetadataManager.java

+   * iterates the returned iterable only once rather than several times.
+   *
+   * @param datasource    the name of the datasource.
+   * @param interval      the interval to search over.


Suggested change

* @param interval the interval to search over.

* @param interval an optional interval to search over. If none is specified, {@link org.apache.druid.java.util.common.Intervals#ETERNITY}

* should be used.

abhishekrb19 · 2023-12-10T21:24:02Z

server/src/main/java/org/apache/druid/metadata/SegmentsMetadataManager.java

+   *
+   * @param datasource    the name of the datasource.
+   * @param interval      the interval to search over.
+   * @param limit         the maximum number of results to return.


Since this is an interface method, could you specify what the default behavior should be for these other optional parameters?

abhishekrb19 · 2023-12-10T21:31:25Z

server/src/main/java/org/apache/druid/metadata/SqlSegmentsMetadataQuery.java


    if (compareAsString) {
      appendConditionForIntervalsAndMatchMode(sb, intervals, matchMode, connector);
    }

+    if (sortOrder != null) {
+      sb.append(StringUtils.format(" ORDER BY start %2$s, %1$send%1$s %2$s",


To guarantee stable pagination, we should also include id here in the ORDER BY clause if it's specified; otherwise, the result set can be garbled between multiple pages

thanks, fixed

abhishekrb19 · 2023-12-10T21:46:17Z

server/src/test/java/org/apache/druid/metadata/SortOrderTest.java

+  }
+
+  @Test
+  public void test_invalid()


Suggested change

public void test_invalid()

public void testInvalid()

abhishekrb19 · 2023-12-10T21:50:59Z

server/src/main/java/org/apache/druid/metadata/SortOrder.java

+import java.util.stream.Collectors;
+
+/**
+ * specifies the sort order when doing metadata store queries.


Suggested change

* specifies the sort order when doing metadata store queries.

* Specifies the sort order when doing metadata store queries.

abhishekrb19 · 2023-12-10T21:56:46Z

server/src/main/java/org/apache/druid/metadata/SqlSegmentsMetadataQuery.java

  )
  {
    // Check if the intervals all support comparing as strings. If so, bake them into the SQL.
    final boolean compareAsString = intervals.stream().allMatch(Intervals::canCompareEndpointsAsStrings);

    final StringBuilder sb = new StringBuilder();
-    sb.append("SELECT payload FROM %s WHERE used = :used AND dataSource = :dataSource");
+    sb.append("SELECT payload FROM %s WHERE used = :used AND dataSource = :dataSource %s");


Do we need the trailing %s? If we add the necessary sql clauses conditionally we don't need this, right?

server/src/main/java/org/apache/druid/metadata/SqlSegmentsMetadataQuery.java

abhishekrb19 · 2023-12-10T22:01:44Z

server/src/main/java/org/apache/druid/metadata/SqlSegmentsMetadataQuery.java

+        .createQuery(StringUtils.format(
+            sb.toString(),
+            dbTables.getSegmentsTable(),
+            lastSegmentId == null


Please see my comment about moving this block above

…ments

abhishekrb19

Looks good to me after the last batch of comments are addressed. Thanks, @zachjsh!

abhishekrb19 · 2023-12-11T16:24:51Z

server/src/test/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinatorTest.java

@@ -3048,21 +3159,23 @@ private List<DataSegment> createAndGetUsedYearSegments(final int startYear, fina
    return segments;
  }

-  private ImmutableList<DataSegment> retrieveUnusedSegmentsUsingMultipleIntervalsAndLimit(
+  private ImmutableList<DataSegment> retrieveUnusedSegmentsUsingMultipleIntervalsLimitAndOffset(


There's no offset anymore; maybe we can simply call this method retrieveUnusedSegments?

abhishekrb19 · 2023-12-11T16:29:47Z

server/src/test/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinatorTest.java

+  }
+
+  @Test
+  public void testRetrieveUnusedSegmentsUsingNoIntervalsNoLimitNoOffset() throws IOException


Adjust the test method names since there's no offset?

abhishekrb19 · 2023-12-11T16:30:56Z

server/src/test/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinatorTest.java

        null
    );
    Assert.assertEquals(segments.size(), actualUnusedSegments.size());
    Assert.assertTrue(segments.containsAll(actualUnusedSegments));
  }

+  @Test
+  public void testRetrieveUnusedSegmentsUsingNoIntervalsAndNoLimitAndOffset() throws IOException


Offset -> last segment id here and below

Suggested change

public void testRetrieveUnusedSegmentsUsingNoIntervalsAndNoLimitAndOffset() throws IOException

public void testRetrieveUnusedSegmentsUsingNoIntervalsAndNoLimitAndNoLastSegmentId() throws IOException

abhishekrb19 · 2023-12-11T16:32:19Z

server/src/main/java/org/apache/druid/metadata/SqlSegmentsMetadataManager.java

+   * This call does not return any information about realtime segments.
+   *
+   * @param datasource      The name of the datasource
+   * @param interval        The intervals to search over


Suggested change

* @param interval The intervals to search over

* @param interval an optional interval to search over.

abhishekrb19 · 2023-12-11T16:32:50Z

server/src/main/java/org/apache/druid/metadata/SqlSegmentsMetadataManager.java

+   *
+   * @param datasource      The name of the datasource
+   * @param interval        The intervals to search over
+   * @param limit           The limit of segments to return


Suggested change

* @param limit The limit of segments to return

* @param limit an optional maximum number of results to return. If none is specified, the results are not limited.

abhishekrb19 · 2023-12-11T16:40:31Z

server/src/main/java/org/apache/druid/server/http/MetadataResource.java

+    final Iterable<DataSegment> authorizedSegments =
+        AuthorizationUtils.filterAuthorizedResources(req, unusedSegments, raGenerator, authorizerMapper);
+
+    // sort by earliest start interval first, then end interval. DataSegment are sorted in this same order due to


Do we need this comment here since the sorting actually happens inside iterateAllUnusedSegmentsForDatasource? Also, this is missing last segment id in the sort by criteria

abhishekrb19 · 2023-12-11T16:48:37Z

server/src/main/java/org/apache/druid/server/http/MetadataResource.java

+    }
+
+    SortOrder theSortOrder = sortOrder == null ? null : SortOrder.fromValue(sortOrder);
+


Could we also add a validation check for lastSegmentId if it's non-nul? We could use org.apache.druid.timeline.SegmentId#tryParse utility to validate the id and throw an invalid input exception if the result of the tryParse is null (the id failed to parse)

abhishekrb19 · 2023-12-11T16:51:13Z

server/src/test/java/org/apache/druid/server/http/MetadataResourceTest.java

+    // test valid datasource with interval filter limit and offset - returns unused segments for that datasource within
+    // interval upto limit starting at offset


Suggested change

// test valid datasource with interval filter limit and offset - returns unused segments for that datasource within

// interval upto limit starting at offset

// test valid datasource with interval filter limit and last segment id - returns unused segments for that datasource within

// interval upto limit starting at last segment id

server/src/main/java/org/apache/druid/server/http/MetadataResource.java

zachjsh added 3 commits November 22, 2023 12:19

* stuff

1d135e7

* add tests

c2d52f2

* fix checkstyle * refactor * remove deadcode

Merge remote-tracking branch 'apache/master' into retreive-unused-seg…

190a379

…ments

zachjsh changed the title ~~Retreive unused segments~~ Add api for Retreiving unused segments Nov 22, 2023

zachjsh changed the title ~~Add api for Retreiving unused segments~~ Add api for Retrieving unused segments Nov 22, 2023

zachjsh requested review from abhishekrb19 and jon-wei November 22, 2023 22:23

zachjsh marked this pull request as ready for review November 22, 2023 22:33

github-advanced-security bot found potential problems Nov 22, 2023

View reviewed changes

server/src/test/java/org/apache/druid/server/http/DataSourcesResourceTest.java Fixed Show fixed Hide fixed

server/src/test/java/org/apache/druid/server/http/DataSourcesResourceTest.java Fixed Show fixed Hide fixed

abhishekrb19 reviewed Nov 23, 2023

View reviewed changes

zachjsh added 2 commits December 1, 2023 13:02

Merge remote-tracking branch 'apache/master' into retreive-unused-seg…

49cbe5a

…ments

* review comments

49c1c1a

github-actions bot added the Area - Documentation label Dec 4, 2023

zachjsh requested a review from abhishekrb19 December 4, 2023 19:43

github-advanced-security bot found potential problems Dec 4, 2023

View reviewed changes

server/src/test/java/org/apache/druid/server/http/DataSourcesResourceTest.java Fixed Show fixed Hide fixed

* move api to MetadataResource

bf15374

github-advanced-security bot found potential problems Dec 5, 2023

View reviewed changes

server/src/main/java/org/apache/druid/server/http/MetadataResource.java Fixed Show fixed Hide fixed

* fix failing test

90362c3

abhishekrb19 reviewed Dec 5, 2023

View reviewed changes

zachjsh and others added 3 commits December 5, 2023 17:45

Apply suggestions from code review

af81f10

Co-authored-by: Abhishek Radhakrishnan <[email protected]>

* address review comments

3950732

Merge remote-tracking branch 'apache/master' into retreive-unused-seg…

002f00e

…ments

zachjsh requested a review from abhishekrb19 December 5, 2023 23:12

abhishekrb19 approved these changes Dec 6, 2023

View reviewed changes

abhishekrb19 added the Area - Metadata label Dec 6, 2023

jon-wei reviewed Dec 6, 2023

View reviewed changes

zachjsh added 2 commits December 7, 2023 03:39

* address review comments

5ada621

Merge remote-tracking branch 'apache/master' into retreive-unused-seg…

c82ab4a

…ments

abhishekrb19 reviewed Dec 7, 2023

View reviewed changes

zachjsh added 3 commits December 9, 2023 09:36

* address review comments

68a98dd

* update docs

6675228

Merge remote-tracking branch 'apache/master' into retreive-unused-seg…

82259c6

…ments

zachjsh added 2 commits December 9, 2023 13:25

* fix spellcheck

c92aaf1

* fix spelling check failure

817d8be

abhishekrb19 reviewed Dec 10, 2023

View reviewed changes

abhishekrb19 added the Release Notes label Dec 10, 2023

zachjsh added 2 commits December 11, 2023 04:21

* address review comments

0ea6b5a

Merge remote-tracking branch 'apache/master' into retreive-unused-seg…

ff0e5c5

…ments

abhishekrb19 approved these changes Dec 11, 2023

View reviewed changes

zachjsh added 2 commits December 11, 2023 13:16

* review comments

a23b044

* address one more comment

d6685a9

github-advanced-security bot found potential problems Dec 11, 2023

View reviewed changes

server/src/main/java/org/apache/druid/server/http/MetadataResource.java Dismissed Show dismissed Hide dismissed

zachjsh merged commit ab7d9bc into apache:master Dec 11, 2023
83 checks passed

zachjsh deleted the retreive-unused-segments branch December 11, 2023 21:32

abhishekrb19 added the Needs web console change Backend API changes that would benefit from frontend support in the web console label Jan 18, 2024

abhishekrb19 mentioned this pull request Jan 18, 2024

Remove documentation for unused segments retrieval API #15721

Merged

1 task

abhishekrb19 removed Release Notes Needs web console change Backend API changes that would benefit from frontend support in the web console labels Jan 18, 2024

LakshSingla added this to the 29.0.0 milestone Jan 29, 2024

		@@ -3050,19 +3106,20 @@ private List<DataSegment> createAndGetUsedYearSegments(final int startYear, fina

		private ImmutableList<DataSegment> retrieveUnusedSegmentsUsingMultipleIntervalsAndLimit(

	* @param interval the interval to search over.
	* @param interval an optional interval to search over. If none is specified, {@link org.apache.druid.java.util.common.Intervals#ETERNITY}
	* should be used.

	* specifies the sort order when doing metadata store queries.
	* Specifies the sort order when doing metadata store queries.

	public void testRetrieveUnusedSegmentsUsingNoIntervalsAndNoLimitAndOffset() throws IOException
	public void testRetrieveUnusedSegmentsUsingNoIntervalsAndNoLimitAndNoLastSegmentId() throws IOException

	* @param interval The intervals to search over
	* @param interval an optional interval to search over.

	* @param limit The limit of segments to return
	* @param limit an optional maximum number of results to return. If none is specified, the results are not limited.

		}

		SortOrder theSortOrder = sortOrder == null ? null : SortOrder.fromValue(sortOrder);

		// test valid datasource with interval filter limit and offset - returns unused segments for that datasource within
		// interval upto limit starting at offset

Add api for Retrieving unused segments #15415

Add api for Retrieving unused segments #15415

Conversation

zachjsh commented Nov 22, 2023 • edited by abhishekrb19 Loading

Description

Release note

abhishekrb19 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abhishekrb19 Nov 23, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abhishekrb19 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abhishekrb19 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abhishekrb19 commented Dec 8, 2023 • edited Loading

zachjsh commented Dec 9, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abhishekrb19 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zachjsh commented Nov 22, 2023 •

edited by abhishekrb19

Loading

abhishekrb19 Nov 23, 2023 •

edited

Loading

abhishekrb19 commented Dec 8, 2023 •

edited

Loading