Provide default implementation for RowFunction evalDimension method #15452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating to latest master
gianm
reviewed
Nov 30, 2023
processing/src/main/java/org/apache/druid/segment/transform/RowFunction.java
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @Test | ||
| public void defaultEvalDimensionTest() | ||
| { | ||
| Row row = new Row() |
Check warning
Code scanning / CodeQL
Inconsistent compareTo Warning test
abhishekagarwal87
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR: #13947 introduced a function evalDimension() in the interface RowFunction.
There was no default implementation added for this interface which causes all the implementations and custom transforms to fail and require to implement their own version of evalDimension method. This PR adds a default implementation in the interface which allows the evalDimension to return value as a Singleton array of eval result.
Fixed the bug ...
#13947 is a breaking change for custom transform RowFunction implementations.
Renamed the class ...
None
Added a forbidden-apis entry ...
None
Release note
Default implementation for evalDimension method in RowFunction.
Key changed/added classes in this PR
MyFooOurBarTheirBazThis PR has: