Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean useless InterruptedException warn in ingestion task log #15519

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

fectrain
Copy link
Contributor

@fectrain fectrain commented Dec 8, 2023

Fixes #15518.

Description

Eliminate the useless InterruptedException warn caused by the close of KafkaEmitter

Release note

Clean useless InterruptedException warn in ingestion task log


Key changed/added classes in this PR
  • KafkaEmitter

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Copy link
Member

@asdf2014 asdf2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Although there is another way to avoid the InterruptedException exception to resolve this problem, which is to replace shutdownNow() with shutdown() in the close() method. However, it might lead to an inability to exit normally. Therefore, it is necessary to use awaitTermination() to wait for a period of time, and still inevitably call the shutdownNow() method. Hence, current solution that does not change the previous behavior might be a not bad option so far 😄

@asdf2014 asdf2014 merged commit c9be1cb into apache:master Dec 15, 2023
53 checks passed
@LakshSingla LakshSingla added this to the 29.0.0 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unnecessary warning stack logs during normal exit of ingestion tasks
3 participants