Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support iterable for druid lookups-cached-single extension #16124

Conversation

TessaIO
Copy link
Contributor

@TessaIO TessaIO commented Mar 14, 2024

Relates to #15936.

Description

This PR aims to change the behavior of the druid lookups-cached-single extension. In fact, we aim to introduce the option to iterate over fetched data from the dataFetcher. We need this in the case of loadingLookups, that's why these changes don't impact the pollingLookup feature.
I also added the handling of a use case where the data exists in Druid but not in the actual data fetcher, which is in our use-case JDBC Data fetcher.

Release note


Key changed/added classes in this PR
  • Support iterating over fetched data for the loadinglookups for the druid lookups-cached-single extension

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@TessaIO TessaIO force-pushed the feature-support-iterable-for-lookups-cached-single branch 2 times, most recently from a646858 to bb4cf65 Compare March 19, 2024 10:48
@TessaIO TessaIO force-pushed the feature-support-iterable-for-lookups-cached-single branch from bb4cf65 to c5d54dd Compare March 19, 2024 10:50
@TessaIO
Copy link
Contributor Author

TessaIO commented Mar 19, 2024

ping @cryptoe. Can you also drop a quick review on this?

Copy link

This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the [email protected] list.
Thank you for your contributions.

@github-actions github-actions bot added the stale label May 19, 2024
Copy link

This pull request/issue has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant