-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSQ WF: Pass a flag from broker to determine operator chain transformation #17443
Merged
cryptoe
merged 7 commits into
apache:master
from
Akshat-Jain:msq-wf-pass-flag-from-broker-for-operator-transformation
Nov 12, 2024
Merged
MSQ WF: Pass a flag from broker to determine operator chain transformation #17443
cryptoe
merged 7 commits into
apache:master
from
Akshat-Jain:msq-wf-pass-flag-from-broker-for-operator-transformation
Nov 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area - Batch Ingestion
Area - Querying
Area - MSQ
For multi stage queries - https://github.com/apache/druid/issues/12262
labels
Nov 4, 2024
cryptoe
reviewed
Nov 7, 2024
...sions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/DataSourcePlan.java
Outdated
Show resolved
Hide resolved
...s-core/multi-stage-query/src/main/java/org/apache/druid/msq/util/MultiStageQueryContext.java
Show resolved
Hide resolved
cryptoe
approved these changes
Nov 7, 2024
...sions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/DataSourcePlan.java
Outdated
Show resolved
Hide resolved
…owOperatorQueryKit with query context
cryptoe
reviewed
Nov 11, 2024
...re/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/WindowOperatorQueryKit.java
Outdated
Show resolved
Hide resolved
cryptoe
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest changes LGTM.
jtuglu-netflix
pushed a commit
to jtuglu-netflix/druid
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area - Batch Ingestion
Area - MSQ
For multi stage queries - https://github.com/apache/druid/issues/12262
Area - Querying
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #17433, we had to move the operator-chain-transformation logic to the MSQ worker layer to ensure backward compatibility. But it wasn't ideal since such logic shouldn't be a responsibility of the worker.
On further offline discussion, an alternative was suggested that we can pass a flag from the broker during query execution.
If MSQ controller sees the flag, then it does the operator transformation. Otherwise it doesn't do the operator transformation.
This relies on the upgrade order of the different services. This allows us to achieve backward compatibility since brokers are upgraded after indexers/middlemanagers, so passing a flag is essentially passing info whether all indexers/middlemanagers have been upgraded or not - hence helps us achieve backward compatibility.
This PR has: