Refactor: Move some classes from sql to processing & server for reusability
#17542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g with other server clients.
…okerServiceModule.
github-actions
bot
added
Area - Batch Ingestion
Area - Querying
Area - MSQ
abhishekrb19
changed the title
sql to processing & server for reusabilitysql to processing & server for reusability
kfaraz
reviewed
Dec 6, 2024
| public class ClientSqlQueryTest | ||
| { | ||
| @Test | ||
| public void testSerde() throws JsonProcessingException |
There was a problem hiding this comment.
There should be a test in SqlQueryTest to test inter-conversion between SqlQuery and ClientSqlQuery.
There was a problem hiding this comment.
Done. Also, fixed a related bug with parameters caught in the unit test.
abhishekrb19
force-pushed
the
refactor_broker_classes
branch
from
ea7a58d to
0616081
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains non-functional / refactoring changes of the following classes in the
sqlmodule:ExplainPlanandExplainAttributesfromsql/src/main/java/org/apache/druid/sql/httptoprocessing/src/main/java/org/apache/druid/query/explainsql/src/main/java/org/apache/druid/sql/SqlTaskStatus.java->processing/src/main/java/org/apache/druid/query/http/SqlTaskStatus.javaprocessing/src/main/java/org/apache/druid/query/http/ClientSqlQuery.javathat is effectively a thin POJO version ofSqlQueryin thesqlmodule but without any of the Calcite functionality and business logic.BrokerClient,BrokerClientImplandBrokerclasses fromsql/src/main/java/org/apache/druid/sql/clienttoserver/src/main/java/org/apache/druid/client/broker.BrokerServiceModulethat provided theBrokerClient. The functionality is now contained inServiceClientModulein theserverpackage itself which provides all the clients as well.This is done so that we can reuse the said classes in #17353 without brining in Calcite and other dependencies to the Overlord.
This PR has: