remove druid.expressions.useStrictBooleans in favor of always being true #17568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianm
reviewed
Dec 17, 2024
| @@ -39,9 +34,6 @@ public class ExpressionProcessingConfig | |||
| "druid.expressions.homogenizeNullMultiValueStringArrays"; | |||
| public static final String ALLOW_VECTORIZE_FALLBACK = "druid.expressions.allowVectorizeFallback"; | |||
|
|
|||
| @JsonProperty("useStrictBooleans") | |||
| private final boolean useStrictBooleans; | |||
There was a problem hiding this comment.
IMO, we should keep the config here, and use it for exactly one thing: to log a warning on startup if it's set to false. Just a little hint for people that upgrade without reading the release notes, and end up wondering why behavior changed.
There was a problem hiding this comment.
ah, that's reasonable, will add it back
gianm
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
driud.expressions.useStrictBooleanshas been deprecated, this PR removes it effectively setting it to always be true. With this it means that Druid always handles boolean types as longs with 1 for true and 0 for false, and expression logical operations behave in sql compatible manner.Related #17575
I have not updated the docs yet because docs on this are intertwined with discussion about
druid.generic.useDefaultValueForNullanddruid.generic.useThreeValueLogicForNativeFilters, so I will address them all in one shot in a follow-up after everything is removed.Release note
Skipping writing the release note for just this PR, i think it makes sense to have a combined release note for when this,
druid.generic.useDefaultValueForNull, anddruid.generic.useThreeValueLogicForNativeFiltersare all removed.