Remove code for CuratorLoadQueuePeon #17657
Merged
+67
−1,513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptoe
approved these changes
Jan 23, 2025
|
Thanks for the review, @cryptoe ! |
317brian
pushed a commit
to 317brian/druid
that referenced
this pull request
Jan 28, 2025
ZK-based segment loading was completely disabled in apache#16360 and apache#15705. This PR removes all related code which is now unused. Changes: - Remove CuratorLoadQueuePeon and CuratorLoadQueuePeonTest - Refactor DruidCoordinatorTest to use a TestLoadQueuePeon instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZK-based segment loading was completely disabled in #16360 and #15705.
This PR removes all related code which is now unused.
Changes
CuratorLoadQueuePeonandCuratorLoadQueuePeonTestDruidCoordinatorTestto use aTestLoadQueuePeoninstead