fix: codestyle

apache · Aug 22, 2024 · 7c16ac9 · 7c16ac9
1 parent c6e53c9
commit 7c16ac9
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 8 deletions.
diff --git a/...g/apache/flink/cdc/runtime/operators/schema/coordinator/SchemaRegistryRequestHandler.java b/...g/apache/flink/cdc/runtime/operators/schema/coordinator/SchemaRegistryRequestHandler.java
@@ -133,14 +133,14 @@ public CompletableFuture<CoordinationResponse> handleSchemaChangeRequest(
             if (schemaManager.isOriginalSchemaChangeEventRedundant(event)) {
                 LOG.info("Event {} has been addressed before, ignoring it.", event);
                 finishCurrentSchemaChangeRequest();
-                return CompletableFuture.completedFuture(wrap(SchemaChangeResponse.DUPLICATE()));
+                return CompletableFuture.completedFuture(wrap(SchemaChangeResponse.duplicate()));
             }
             schemaManager.applyOriginalSchemaChange(event);
             List<SchemaChangeEvent> derivedSchemaChangeEvents =
                     calculateDerivedSchemaChangeEvents(request.getSchemaChangeEvent());
             if (derivedSchemaChangeEvents.isEmpty()) {
                 finishCurrentSchemaChangeRequest();
-                return CompletableFuture.completedFuture(wrap(SchemaChangeResponse.IGNORED()));
+                return CompletableFuture.completedFuture(wrap(SchemaChangeResponse.ignored()));
             } else {
                 derivedSchemaChangeEvents.forEach(
                         e -> {
@@ -156,13 +156,13 @@ public CompletableFuture<CoordinationResponse> handleSchemaChangeRequest(
                         });
                 currentDerivedSchemaChangeEvents = new ArrayList<>(derivedSchemaChangeEvents);
                 return CompletableFuture.completedFuture(
-                        wrap(SchemaChangeResponse.ACCEPTED(derivedSchemaChangeEvents)));
+                        wrap(SchemaChangeResponse.accepted(derivedSchemaChangeEvents)));
             }
         } else {
             LOG.info(
                     "Schema Registry is busy processing a schema change request, could not handle request {} for now.",
                     request);
-            return CompletableFuture.completedFuture(wrap(SchemaChangeResponse.BUSY()));
+            return CompletableFuture.completedFuture(wrap(SchemaChangeResponse.busy()));
         }
     }
 

diff --git a/...c/main/java/org/apache/flink/cdc/runtime/operators/schema/event/SchemaChangeResponse.java b/...c/main/java/org/apache/flink/cdc/runtime/operators/schema/event/SchemaChangeResponse.java
@@ -41,19 +41,19 @@ public class SchemaChangeResponse implements CoordinationResponse {
 
     private final ResponseCode responseCode;
 
-    public static SchemaChangeResponse ACCEPTED(List<SchemaChangeEvent> schemaChangeEvents) {
+    public static SchemaChangeResponse accepted(List<SchemaChangeEvent> schemaChangeEvents) {
         return new SchemaChangeResponse(schemaChangeEvents, ResponseCode.ACCEPTED);
     }
 
-    public static SchemaChangeResponse BUSY() {
+    public static SchemaChangeResponse busy() {
         return new SchemaChangeResponse(Collections.emptyList(), ResponseCode.BUSY);
     }
 
-    public static SchemaChangeResponse DUPLICATE() {
+    public static SchemaChangeResponse duplicate() {
         return new SchemaChangeResponse(Collections.emptyList(), ResponseCode.DUPLICATE);
     }
 
-    public static SchemaChangeResponse IGNORED() {
+    public static SchemaChangeResponse ignored() {
         return new SchemaChangeResponse(Collections.emptyList(), ResponseCode.IGNORED);
     }
 
@@ -111,6 +111,20 @@ public String toString() {
                 + '}';
     }
 
+    /**
+     * Schema Change Response status code.
+     *
+     * <p>- Accepted: Requested schema change request has been accepted exclusively. Any other
+     * schema change requests will be blocked.
+     *
+     * <p>- Busy: Schema registry is currently busy processing another schema change request.
+     *
+     * <p>- Duplicate: This schema change request has been submitted before, possibly by another
+     * paralleled subTask.
+     *
+     * <p>- Ignored: This schema change request has been assessed, but no actual evolution is
+     * required. Possibly caused by LENIENT mode or merging table strategies.
+     */
     public enum ResponseCode {
         ACCEPTED,
         BUSY,